From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43982: strerror return value Date: Wed, 14 Oct 2020 06:20:19 +0200 Message-ID: <87zh4pzbek.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17880"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43982@debbugs.gnu.org To: Philipp Klaus Krause Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 06:21:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSYHl-0004XK-1N for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 06:21:09 +0200 Original-Received: from localhost ([::1]:46848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSYHk-0007QB-3c for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 00:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSYHe-0007Pl-NE for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 00:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSYHe-0006hY-Ct for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 00:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSYHe-0001Vm-8j for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 00:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 04:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43982 X-GNU-PR-Package: emacs Original-Received: via spool by 43982-submit@debbugs.gnu.org id=B43982.16026492325732 (code B ref 43982); Wed, 14 Oct 2020 04:21:02 +0000 Original-Received: (at 43982) by debbugs.gnu.org; 14 Oct 2020 04:20:32 +0000 Original-Received: from localhost ([127.0.0.1]:49669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYH9-0001UO-U2 for submit@debbugs.gnu.org; Wed, 14 Oct 2020 00:20:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYH7-0001U6-Uj for 43982@debbugs.gnu.org; Wed, 14 Oct 2020 00:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pPvqaziol6ia1n1RjtOVUFICHLmUSonzxW+OEDfLeMg=; b=b3Lzh2Gi+/zqznWSKPig8HudWn ItpV0uNDlFF1g9DbjonFjEx+ZXpMJiZscrJP/UyppFELAJDnnAdEWH59UNBsiYat8o+07J65jEvK/ UIIhKTW/20notNd8h72UWOf5VDfJnYd/qSq5QfbpPCvshkCSpG2nFQxEjTQcnj0Bvqyc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSYGy-0004nQ-Ki; Wed, 14 Oct 2020 06:20:23 +0200 X-Now-Playing: B. Fleischmann's _Welcome Tourist (1)_: "A Letter from Home" In-Reply-To: (Philipp Klaus Krause's message of "Tue, 13 Oct 2020 21:15:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190467 Archived-At: Philipp Klaus Krause writes: > This is just a very minor issue. > > emacs contains two calls to strerror where the result is assigned > to a char *. However, according to the strerror specification, the > string returned by strerror should never be changed, so it would be > better to use const char * instead. > > See the attached patch for the trivial fix. [...] > - char *s = strerror (errno); > + const char *s = strerror (errno); Makes sense; I've now applied this to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no