From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44981: 28.0.50; Restore nnimap-split-download-body? Date: Fri, 04 Dec 2020 10:45:12 +0000 Message-ID: <87zh2tyhmv.fsf@tcd.ie> References: <87y2iip3ky.fsf@ericabrahamsen.net> <878sag4i4f.fsf@gnus.org> <87v9djsqxl.fsf@ericabrahamsen.net> <87k0tzz4wf.fsf@gnus.org> <87k0ty92ge.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44981@debbugs.gnu.org To: eric@ericabrahamsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 04 11:46:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl8bM-00047l-0y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Dec 2020 11:46:12 +0100 Original-Received: from localhost ([::1]:49928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl8bK-0007ev-IO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Dec 2020 05:46:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl8bC-0007eZ-Cl for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 05:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kl8bC-0003By-5w for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 05:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kl8bC-0002Jv-38 for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 05:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Dec 2020 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44981 X-GNU-PR-Package: emacs Original-Received: via spool by 44981-submit@debbugs.gnu.org id=B44981.16070787226671 (code B ref 44981); Fri, 04 Dec 2020 10:46:02 +0000 Original-Received: (at 44981) by debbugs.gnu.org; 4 Dec 2020 10:45:22 +0000 Original-Received: from localhost ([127.0.0.1]:42949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl8aY-0001jF-Bk for submit@debbugs.gnu.org; Fri, 04 Dec 2020 05:45:22 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:36717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl8aW-0001bS-CF for 44981@debbugs.gnu.org; Fri, 04 Dec 2020 05:45:20 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id f190so6643620wme.1 for <44981@debbugs.gnu.org>; Fri, 04 Dec 2020 02:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=88fT5YRKL3Lw4Q1LtARmV3l66W3yvnSD6i8f5oDxk2c=; b=AhvVNDRBNu6beYIKfkiWlmouCAZs1NZDtF8rHgCvdY1w6kJBeW3pVIE3qAGYvXvxXP CtE8rsHbnpiUWNRCEL9CQDzZprpogJ8mMuXZPFofHN3Vg3xOn9J+Y+hb1CuhZ/qd/sEa Hxb65GAOXDTsbUh56bUlOvEcbWMm0G1bhLL0tD3rnlbGuG6mQMNGL0eLGdCC9Y3CUCc6 gV94qXVkduQDF35VtUOp/f4IazEE7FoLOzEfi/ooOfHo+EJhrsTi8l8LtvpqNXgoOIHO W6KPgNTrfFjYpwXnY4CEON3hSbtKVJtv1eWboh+Y5FHTdCk6Kk7nG6u9Y2pNOXqoWAiu p4Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=88fT5YRKL3Lw4Q1LtARmV3l66W3yvnSD6i8f5oDxk2c=; b=Yjn4ZEaW8NhHL5m9ygcQXyHsVT82JqCsHQNg+/owv0YotOxAcugbOHP2MDMzCsfI2i e7vPmbfBOLR7GBmTF6uVUlx+49zk6orekqn9bJQ+tp635AbLhdos2bZlokvfhvaLIcsH M6GVXPt8omjZqykfaY0rzswI+bsKq0kug/Ly+xn+MHZDZxjLjf3yp4qfWkxTBESxLQ7a EbRIBTf+ry/9PvAn1PWirZY6EK4vv5A7NF8zrIi+Wi4BU5V2ddOS5FIR34ps7QGKSRfj dS6UCwPwrF88Oe/LR1GjFQ0c7EOrRAUoWKc0qupzGI0zvMLsEBmVq663Xeo41oIHoN7b /jDw== X-Gm-Message-State: AOAM533ObI4I7vFBtG/j0zGX9wlIR3GEW/4d0HIAqMcE4Z1yANKOoQvH lrA4eeQndZosCaw5ib5w9gQnew== X-Google-Smtp-Source: ABdhPJxP1az/F8kog3WpBYAMil3U5LUGtkPb+Xb4di62Co+IgA1SGZE60SHBFUEoNYcPPOrpktizKw== X-Received: by 2002:a05:600c:14c6:: with SMTP id i6mr3591675wmh.180.1607078714506; Fri, 04 Dec 2020 02:45:14 -0800 (PST) Original-Received: from localhost ([51.37.99.191]) by smtp.gmail.com with ESMTPSA id v12sm3015023wrt.4.2020.12.04.02.45.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 02:45:13 -0800 (PST) In-Reply-To: <87k0ty92ge.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 03 Dec 2020 10:20:01 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194962 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for cleaning this up, Eric. Could someone please look into the following byte-compilation warning? In spam-setup-widening: gnus/spam.el:1234:11: Warning: =E2=80=98nnimap-split-download-body-defaul= t=E2=80=99 is an obsolete variable (as of 28.1); use =E2=80=98nnimap-split-download-bo= dy=E2=80=99 instead. I was thinking of the following change: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=spam.diff diff --git a/lisp/gnus/spam.el b/lisp/gnus/spam.el index 96a7da2313..8634fa680d 100644 --- a/lisp/gnus/spam.el +++ b/lisp/gnus/spam.el @@ -44,12 +44,9 @@ ;;; for the definitions of group content classification and spam processors (require 'gnus) -(eval-when-compile (require 'hashcash)) - -;; for nnimap-split-download-body-default -(eval-when-compile (require 'nnimap)) - -(eval-when-compile (require 'cl-lib)) +(eval-when-compile + (require 'cl-lib) + (require 'hashcash)) ;; autoload query-dig (autoload 'query-dig "dig") @@ -1230,8 +1227,9 @@ spam-generic-score ;;; set up IMAP widening if it's necessary (defun spam-setup-widening () + (defvar nnimap-split-download-body) (when (spam-widening-needed-p) - (setq nnimap-split-download-body-default t))) + (setq nnimap-split-download-body t))) (defun spam-widening-needed-p (&optional force-symbols) (let (found) --=-=-= Content-Type: text/plain But Ted explicitly changed spam-setup-widening in 2003 to use nnimap-split-download-body-default instead of nnimap-split-download-body, to avoid modifying a user option. I don't know what spam-setup-widening is meant to do, and by extension I don't know what TRT to do here is. Either way, loading nnimap in eval-when-compile "for a variable" is definitely dubious. Ideas? Thanks, -- Basil --=-=-=--