From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19031: 24.4; find-file in icomplete-mode shows completions with no input Date: Tue, 08 Dec 2020 10:51:04 +0200 Organization: LINKOV.NET Message-ID: <87zh2o7krj.fsf@mail.linkov.net> References: <864mu464pa.fsf@beta.iola.dk> <87r1o5luz9.fsf@gnus.org> <878sabf6fu.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28226"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 19031@debbugs.gnu.org, Andrii Kolomoiets To: Ole Laursen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 08 10:11:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmZ2F-0007Fx-6O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Dec 2020 10:11:51 +0100 Original-Received: from localhost ([::1]:43618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmZ2E-0004vS-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Dec 2020 04:11:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmZ1V-0004sn-MV for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 04:11:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmZ1S-0003iQ-HY for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 04:11:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmZ1S-0005Kr-CE for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2020 04:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Dec 2020 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19031 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 19031-submit@debbugs.gnu.org id=B19031.160741863220460 (code B ref 19031); Tue, 08 Dec 2020 09:11:02 +0000 Original-Received: (at 19031) by debbugs.gnu.org; 8 Dec 2020 09:10:32 +0000 Original-Received: from localhost ([127.0.0.1]:56549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmZ0x-0005Jp-Lo for submit@debbugs.gnu.org; Tue, 08 Dec 2020 04:10:32 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:39457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmZ0u-0005JK-R1 for 19031@debbugs.gnu.org; Tue, 08 Dec 2020 04:10:30 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AD371C000C; Tue, 8 Dec 2020 09:10:20 +0000 (UTC) In-Reply-To: (Ole Laursen's message of "Mon, 7 Dec 2020 12:43:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195317 Archived-At: > I originally reported this because I found it jarring to get a bunch > of completions without having entered anything. In my home dir it > basically shows me garbage (dot files that I'm never interested in). > > Would it not be possible to make a difference between the case where > find-file provides some default text (current dir) and where I have > entered some input? The variable literally says -on-no-input. I tried to handle this case with the following patch, but it doesn't work because read-file-name-default resets `minibuffer-default' to nil, so icomplete doesn't know what was initial input in the minibuffer. diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 676917b9da..47bd8f90a4 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -579,7 +579,10 @@ icomplete-exhibit (goto-char (point-max)) ; Insert the match-status information: (when (and (or icomplete-show-matches-on-no-input - (> (icomplete--field-end) (icomplete--field-beg))) + (if (stringp minibuffer-default) + (/= (icomplete--field-end) (+ (icomplete--field-beg) + (length minibuffer-default))) + (> (icomplete--field-end) (icomplete--field-beg)))) (or ;; Don't bother with delay after certain number of chars: (> (- (point) (icomplete--field-beg))