From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: bzg@gnu.org, 45198@debbugs.gnu.org
Subject: bug#45198: 28.0.50; Sandbox mode
Date: Sun, 13 Dec 2020 11:14:53 +0000 [thread overview]
Message-ID: <87zh2iyn2q.fsf@gmail.com> (raw)
In-Reply-To: <jwvlfe2mj6c.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 12 Dec 2020 23:25:27 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> > You cannot usefully call error from redisplay.
>>> Hmm... but this is at the entrance to redisplay, so I though it should
>>> still be safe at that point. If it's a problem we can replace the above
>>> with
>>> if (emacs_is_sandboxed)
>>> return;
>> Yes, I think this is what we should do in this case.
>
> With the change I just installed into `master`, I can now get
> `elisp-flymake-byte-compile` to use sandboxing successfully with the
> revised patch below.
Fantastic!
> Besides the above change, I made the same change in `Fdo_auto_save`
> (i.e. `do-auto-save` was made to just silently do nothing instead of
> signaling an error since it seemed to be too much trouble to change its
> callers to avoid calling it when sandboxed).
>
> I'm still worried that there remain wide open security holes, tho.
First, I wouldn't worry that terribly. This is certainly and
improvement. I won't be bitten again like that time I accidentally
typed (delete-directory ".") at macroexpand time.
That said, as you said the whitelisting approach is the safest one.
It'd be nice if you we a way to identify system calls and block all by
default. Then whitelist a bunch of calls (checking arguments). Not
sure if this can be done portably/systematically, though. Chroot also
comes to mind, but it's only for linux, right?
João
next prev parent reply other threads:[~2020-12-13 11:14 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 18:01 bug#45198: 28.0.50; Sandbox mode Stefan Monnier
2020-12-12 19:48 ` Eli Zaretskii
2020-12-12 21:06 ` Stefan Monnier
2020-12-13 3:29 ` Eli Zaretskii
2020-12-13 4:25 ` Stefan Monnier
2020-12-13 11:14 ` João Távora [this message]
2020-12-13 17:07 ` Philipp Stephani
2020-12-13 15:31 ` Mattias Engdegård
2020-12-13 17:09 ` Philipp Stephani
2020-12-13 17:04 ` Philipp Stephani
2020-12-13 17:57 ` Stefan Monnier
2020-12-13 18:13 ` Philipp Stephani
2020-12-13 18:43 ` Stefan Monnier
2020-12-14 11:05 ` Philipp Stephani
2020-12-14 14:44 ` Stefan Monnier
2020-12-14 15:37 ` Philipp Stephani
2020-12-19 22:41 ` Philipp Stephani
2020-12-19 23:16 ` Stefan Monnier
2020-12-20 12:28 ` Philipp Stephani
2020-12-22 10:57 ` Philipp Stephani
2020-12-22 14:43 ` Stefan Monnier
2020-12-19 18:18 ` Philipp Stephani
2021-04-10 17:44 ` Philipp Stephani
2020-12-19 22:22 ` Philipp Stephani
2020-12-20 15:09 ` Eli Zaretskii
2020-12-20 18:14 ` Philipp Stephani
2020-12-20 18:29 ` Eli Zaretskii
2020-12-20 18:39 ` Philipp Stephani
2020-12-29 13:50 ` Philipp Stephani
2020-12-29 15:43 ` Eli Zaretskii
2020-12-29 16:05 ` Philipp Stephani
2020-12-29 17:09 ` Eli Zaretskii
2020-12-31 15:05 ` Philipp Stephani
2020-12-31 16:50 ` Eli Zaretskii
2021-04-10 19:11 ` Philipp Stephani
2020-12-13 18:52 ` Stefan Monnier
2020-12-13 20:13 ` João Távora
2020-12-14 11:12 ` Mattias Engdegård
2020-12-14 13:44 ` Philipp Stephani
2020-12-14 14:48 ` Stefan Monnier
2020-12-14 15:59 ` Mattias Engdegård
2020-12-17 13:08 ` Philipp Stephani
2020-12-17 17:55 ` Mattias Engdegård
2020-12-18 15:21 ` Philipp Stephani
2020-12-18 18:50 ` Mattias Engdegård
2020-12-19 15:08 ` Philipp Stephani
2020-12-19 17:19 ` Mattias Engdegård
2020-12-19 18:11 ` Stefan Monnier
2020-12-19 18:46 ` Mattias Engdegård
2020-12-19 19:48 ` João Távora
2020-12-19 21:01 ` Stefan Monnier
2020-12-20 13:15 ` Mattias Engdegård
2020-12-20 14:02 ` Stefan Monnier
2020-12-20 14:12 ` Mattias Engdegård
2020-12-20 15:08 ` Stefan Monnier
2020-12-22 11:12 ` Philipp Stephani
2020-12-28 8:23 ` Stefan Kangas
2020-12-29 13:58 ` Philipp Stephani
2020-12-30 14:59 ` Mattias Engdegård
2020-12-30 15:36 ` Alan Third
2021-04-17 15:26 ` Mattias Engdegård
2021-04-17 15:44 ` Philipp
2021-04-17 15:57 ` Eli Zaretskii
2021-04-17 16:10 ` Philipp
2021-04-17 16:15 ` Eli Zaretskii
2021-04-17 16:19 ` Eli Zaretskii
2021-04-17 16:20 ` Philipp Stephani
2021-04-17 16:33 ` Eli Zaretskii
2021-04-17 19:14 ` Philipp Stephani
2021-04-17 19:23 ` Eli Zaretskii
2021-04-17 19:52 ` Philipp
2021-04-18 6:20 ` Eli Zaretskii
2021-04-18 9:11 ` Philipp Stephani
2021-04-18 9:23 ` Eli Zaretskii
2021-04-17 17:48 ` Mattias Engdegård
2021-04-17 18:21 ` Stefan Monnier
2021-04-17 18:59 ` Mattias Engdegård
2021-04-17 19:42 ` Philipp
2021-04-17 19:57 ` Alan Third
2021-04-19 15:41 ` Mattias Engdegård
2021-04-17 19:19 ` Philipp Stephani
2021-04-17 17:22 ` Mattias Engdegård
2021-04-17 17:57 ` Stefan Monnier
2021-04-17 19:21 ` Philipp Stephani
2021-04-17 19:16 ` Philipp Stephani
2021-04-17 16:58 ` Stefan Monnier
2021-04-17 17:14 ` Eli Zaretskii
2021-04-17 17:53 ` Stefan Monnier
2021-04-17 18:15 ` Eli Zaretskii
2021-04-17 18:47 ` Stefan Monnier
2021-04-17 19:14 ` Eli Zaretskii
2021-04-17 20:26 ` Stefan Monnier
2021-04-18 6:24 ` Eli Zaretskii
2021-04-18 14:25 ` Stefan Monnier
2021-07-05 19:12 ` Philipp
2021-09-17 12:13 ` Mattias Engdegård
2021-09-17 13:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-17 19:49 ` Mattias Engdegård
2022-09-11 11:28 ` Lars Ingebrigtsen
2022-09-13 12:37 ` mattiase
2022-09-13 12:53 ` João Távora
2022-09-13 13:02 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh2iyn2q.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=45198@debbugs.gnu.org \
--cc=bzg@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.