From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Thu, 18 Mar 2021 13:41:04 +0000 Message-ID: <87zgz0wpe7.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri linkov To: 47234@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 14:43:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMsve-0000lJ-KA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 14:43:10 +0100 Original-Received: from localhost ([::1]:38490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMsvd-0006KD-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 09:43:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMsub-00055O-D7 for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 09:42:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMsub-0001nm-1Y for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 09:42:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMsuY-0001y3-Hd; Thu, 18 Mar 2021 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: juri@linkov.net, rudalics@gmx.at, bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47234 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: juri linkov , martin rudalics Original-Received: via spool by submit@debbugs.gnu.org id=B.16160748777487 (code B ref -1); Thu, 18 Mar 2021 13:42:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Mar 2021 13:41:17 +0000 Original-Received: from localhost ([127.0.0.1]:45414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMsto-0001wf-QV for submit@debbugs.gnu.org; Thu, 18 Mar 2021 09:41:17 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMstm-0001wX-RQ for submit@debbugs.gnu.org; Thu, 18 Mar 2021 09:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMstm-0004HU-FD for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 09:41:14 -0400 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:43658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMsti-0001CT-Kh for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 09:41:13 -0400 Original-Received: by mail-wm1-x32c.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so3388311wmj.2 for ; Thu, 18 Mar 2021 06:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=aalRJqdd8RnPsv2SPxMd69dm9NIANkVPbtXAdeEZhPU=; b=egxMcZQu3ljYxdD9OKiORqu0cWkwmjgTn8v5qL+oRNOy2FhstlmYRDc80AV6XIYBvf Tw9SRCkPrF2ICLwyeHZXCWSJg4lCknBEiCyuehpuLT5xA09UVlcEDSr9+Dg4lNmBBSA8 Jz3kRUvDAYPuw/xH35kb7KnRd2c6cehV86j10xsJEkX1HH3tRYw8VKSdL68O1lFL3ay+ PE7FuR84ZxcyCXsfgMIV083vUwhkho5v/FvzTgFHNcbZepMtlyoMW4jXmCZcBZeOieci Xv5xScjnHTfYUtGEp/+YqgmWJW05d6gBpccS538j+P58y++310CGenk+kTjTkUaSLVQx i3jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=aalRJqdd8RnPsv2SPxMd69dm9NIANkVPbtXAdeEZhPU=; b=mSBhqR+q0iqI35al2r+fCguYg+f4am2fDU4iAe6KI26puuAfeZW6vDhxeob2G9u0Q7 Xyqke2ouKL6DLmTjOZekMdzlbLmHqAD69yQWBMx55nbnjcGDDjuQw+iDdLpzM2NyvpqG UfRmlgSX+cGIUmBnxBta+Mmrhm5lhuKSqYGKCc8tpKzMPy3QTFMx7w/HThjHWogRDRVX dCqskrHqaOXWk6KyrI60SW8Sdv+BqzU0HxS3K/zb7g/c2a5P/5vwfbD2jL51cNDj8BR5 ICMiZivqDylvJHR3YT4EAvasQ2iGl00dVtPSPQ4RIN18JAM3EHjnNoGE50hcBtJh7usP G3Cg== X-Gm-Message-State: AOAM532vS7IQipPNo4U+sPAW6VJE2BwS2NiTYt0KmyUF5hHSLMpckWSr BCCE6q0VyF4OtqNrF99ux2CPu/R8g7ZZyw== X-Google-Smtp-Source: ABdhPJw2Q0yXLuLR4FWcc5ZJeDYLRDzzvXt2htSVbkmaiDpbP2Z99kX1v1j5HlMulc4nVvGmnO9yYQ== X-Received: by 2002:a05:600c:2254:: with SMTP id a20mr3886428wmm.115.1616074866007; Thu, 18 Mar 2021 06:41:06 -0700 (PDT) Original-Received: from localhost ([51.37.106.140]) by smtp.gmail.com with ESMTPSA id u8sm3113101wrr.42.2021.03.18.06.41.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 06:41:05 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202594 Archived-At: X-Debbugs-Cc: Juri Linkov , Martin Rudalics In a build --without-x: 0. ./src/emacs -Q 1. (frame-inner-height) C-j Debugger entered--Lisp error: (void-function tab-bar-height) tab-bar-height(# t) frame-inner-height() (progn (frame-inner-height)) eval((progn (frame-inner-height)) t) elisp--eval-last-sexp(t) eval-last-sexp(t) eval-print-last-sexp(nil) funcall-interactively(eval-print-last-sexp nil) call-interactively(eval-print-last-sexp nil nil) command-execute(eval-print-last-sexp) The obvious band-aid is to check (fboundp 'tab-bar-height) in frame-inner-height, but shouldn't we count 1 line when tab-bar-mode is enabled even --without-x? IOW, can/should tab-bar-height or similar be defined regardless of HAVE_WINDOW_SYSTEM? What's TRT here? Thanks, -- Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu) of 2021-03-18 built on tia Repository revision: ce1b4acd71e962b6a72a779ee04cb5aeb6ceb6f2 Repository branch: master System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-nox --enable-checking=structs --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SOUND THREADS XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: mouse-wheel-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print debug backtrace help-mode tool-bar find-func cl-loaddefs cl-lib term/xterm xterm byte-opt gv bytecomp byte-compile cconv regexp-opt mwheel iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs)