From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#47244: 28.0.50; SIGSEGV in long-runnning Emacs Date: Sat, 10 Apr 2021 10:53:56 -0400 Message-ID: <87zgy6b37f.fsf@md5i.com> References: <87im5ofp3z.fsf@md5i.com> <87czv6q1f8.fsf@md5i.com> <233daa4b-ca64-955f-2612-49a0503b1938@gmx.at> <8735w2p8oc.fsf@md5i.com> <5181da75-e80d-22e0-bdcb-a0ffdc1bac6a@gmx.at> <5c4e5857-6a76-b8e8-204b-b4a855e95a16@gmx.at> <8f4516d5-1080-71bb-7da7-acf7832d5529@gmx.at> <87r1jlvnrc.fsf@md5i.com> <871rbkn6op.fsf@md5i.com> <83pmz493ag.fsf@gnu.org> <41cb6395-808f-8e82-ea47-db7a854aadee@gmx.at> <87v98vmax8.fsf@md5i.com> <5725d757-8b8f-905b-45aa-8fecac6d0566@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23425"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Welsh Duggan , "schwab@linux-m68k.org" , "47244@debbugs.gnu.org" <47244@debbugs.gnu.org>, Michael Welsh Duggan To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 10 16:55:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVF1O-0005yW-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Apr 2021 16:55:38 +0200 Original-Received: from localhost ([::1]:56340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVF1M-00018E-Vy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Apr 2021 10:55:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVF0n-00017n-Uj for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2021 10:55:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVF0n-00066r-NI for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2021 10:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVF0n-0000GT-KV for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2021 10:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2021 14:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47244 X-GNU-PR-Package: emacs Original-Received: via spool by 47244-submit@debbugs.gnu.org id=B47244.1618066447940 (code B ref 47244); Sat, 10 Apr 2021 14:55:01 +0000 Original-Received: (at 47244) by debbugs.gnu.org; 10 Apr 2021 14:54:07 +0000 Original-Received: from localhost ([127.0.0.1]:53016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVEzu-0000F6-TZ for submit@debbugs.gnu.org; Sat, 10 Apr 2021 10:54:07 -0400 Original-Received: from md5i.com ([75.151.244.229]:48058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVEzs-0000EZ-Ng for 47244@debbugs.gnu.org; Sat, 10 Apr 2021 10:54:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=34OfaWWmoENiWf+F36zD1YheE2j4WjrI9h1S1wpctAY=; b=bLFR64DDOQeD+4jS9uWHEBOtfW /4CCR09c8NZ+F4/7aHB5WaSkGMHuBk7v2U2gejfLgpIDbl7Z0sB5maACxU5qHiTKtmVXpidTrGJJ9 WTJNpCxXEhjS5i5ccCf+YYd1J; Original-Received: from abode.md5i.com ([192.168.177.1] helo=miko) by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lVEzl-004Jes-1t; Sat, 10 Apr 2021 10:53:56 -0400 In-Reply-To: <5725d757-8b8f-905b-45aa-8fecac6d0566@gmx.at> (martin rudalics's message of "Sat, 10 Apr 2021 09:15:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203797 Archived-At: martin rudalics writes: >> I've tried to recreate a problem with this patch and have successfully >> failed. I'll continue using it for a few days, and I will let you know >> if I see any problems, but I think that protecting window_list() from >> quit fixes the problem(s) I reported. > > Your impatience revealed this bug and your patience located it. I now > attach a clean patch which also protects the occurrence in window_list_1 > although that one doesn't appear so vulnerable - likely because quitting > always eats the maybe_quit from window_list first. If you don't see any > problems with it within a week or so, I'll install it. Sure. But I will say that I think protecting the nconc in window_list_1 is not as important, as it, by itself, does not modify any global state. In point of fact, it only modifies a local variable. It may be that window_loop or replace_buffer_in_windows_safely should be so protected instead, but I can't say that with any degree of certainty. -- Michael Welsh Duggan (md5i@md5i.com)