From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Mon, 24 May 2021 20:13:41 +0100 Message-ID: <87zgwkhrmi.fsf@gmail.com> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87a6olazff.fsf@gmail.com> <93d2cfe9-bae8-bf94-486f-7569aa31491d@daniel-mendler.de> <874kesj6k6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , dgutov@yandex.ru, monnier@iro.umontreal.ca, "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 21:15:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llG2s-0001A3-3r for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 21:15:22 +0200 Original-Received: from localhost ([::1]:55282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llG2q-0007zP-RZ for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 15:15:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llG1K-00075Y-41 for emacs-devel@gnu.org; Mon, 24 May 2021 15:13:46 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:40640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llG1I-0001VO-Hy for emacs-devel@gnu.org; Mon, 24 May 2021 15:13:45 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id f6-20020a1c1f060000b0290175ca89f698so11979813wmf.5 for ; Mon, 24 May 2021 12:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WYJcM8/DajMV0FP7Cylc/vzl46wcnstDBP0czUYEW90=; b=kb7iVyY42/lIV1NFzudzP7sZJAfTvFjmpJKtNeBJBtCd9O45y6DXiW2eW730jXGuYZ BEQ61sURlIGxyKNmxo2q15ZWqq7Xde6FgKoXLfGkwIkSzUsq4COE1/h6T27eYtBwkcXI rBZKwFg+HHBpg9bneZzbP75ND25erMWf7FqGpKKRfpWtWgR8QBVdpOln6fMDIZaNISsg IjB3V2h2WoX4wnsyJZ6Vb4rM2t8LGlYhoClFP0VsWlvftCkCv8c0RtVSUiTkWVBzroMa qFMKnggnWj3A5b3BLZo9n9oUaFlKzd9eh1bbnx+irBjkAKst8esUxD98UGXDSH5mUu63 QJQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WYJcM8/DajMV0FP7Cylc/vzl46wcnstDBP0czUYEW90=; b=mwVIGSwBc1VuEIujlfXOHgw5dgm+zqEhAJ1lcS/Zl8HOd9ePEfwcYD7WYWzKmVdnfH cHj09Y5IBO/AlureUco064k+iTmiP2v7rZcfJfj5S2lMs6rWnOHD6Wu8J4JddKAIbl2g Hnvq4lW+/GQh7m6M7OnO3i38osSRAVcmMCwOYMsPzLgoHP8NDa7EIxTDnOWNHBou7OY7 a8+stPxe/SvU8VXbMZpSrUUpHktVtfYech4HaqV1/AGexA2KGs5YeD0QGisZX1fxUzLD PQOWvy7yPO/4SzYrntLnp0L6aXvKCs7VVrw2yolkw0NnouLbuEWSYRQ3q8V3LCc0WmVZ AEYg== X-Gm-Message-State: AOAM531A3DCgxXKXu7KHeZwdPd5MqR+vPzWvqOZMuxDClXtuyRVs4BaO xCAyKouPE68NbUbeku+GhnNiv0UgUSg= X-Google-Smtp-Source: ABdhPJy7b2zmZmHJgVe1pG/WhuBwYizRj0CjXFd275VjXI9Zvd+2aXoR2p6DVJcb5ml8JUfNrwYXWg== X-Received: by 2002:a7b:c34a:: with SMTP id l10mr20752971wmj.46.1621883623117; Mon, 24 May 2021 12:13:43 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id f8sm8388662wmg.43.2021.05.24.12.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 12:13:42 -0700 (PDT) In-Reply-To: <874kesj6k6.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Mon, 24 May 2021 20:05:45 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269797 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Daniel Mendler writes: > >> On 5/23/21 11:54 PM, Jo=C3=A3o T=C3=A1vora wrote: > >> But regarding merging or not merging the patch, I don't agree with your >> argument of taking this as leverage which makes the discussion more or >> less difficult. > > I'm not taking this as "leverage", I just don't think icomplete.el > should embark into what I consider (and apparently others) a misdesigned > API. We should strive to come up with maintainable and reliable > systems, not just merge something because it happens to work and look > nice (which is plain to see that it does). By the way, another reason not to merge your patch as it is originally is that it seems to affixate too many prospects, way way more than are shown. My alternative patch should, in principle, only annotate the candidates that are to be displayed. It also does suffix alignment (but not prefix yet). So my view is that there are edges to polish in multiple angles and we shouldn't rush this. Jo=C3=A3o