From: Timothy <tecosaur@gmail.com>
To: Morgan Willcock <mwillcock@precedence.co.uk>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil
Date: Tue, 31 Aug 2021 19:59:52 +0800 [thread overview]
Message-ID: <87zgsxom7k.fsf@gmail.com> (raw)
In-Reply-To: <20210817230735.13336-1-mwillcock@precedence.co.uk>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
Hi Morgan,
> I’ve attached a patch to fix an issue where tab characters are generated by
> the ASCII exporter when `indent-tabs-mode’ has its default value of t.
Thanks for finding this bug, fixing it, and sending us it 🙂. I was able to
reproduce your test case with “emacs -Q” (thanks for that, by the way).
As you suspected, with the small number of changed lines, this would be fine to
accept without FSF assignment.
However, your “patch” seems to consist of a diff at the bottom of your email and
a commit message at the top?? It would be preferable if you could provide a
“proper” patch, that way you can get attribution for your help instead of just
someone committing it on your behalf.
All the best,
Timothy
next prev parent reply other threads:[~2021-08-31 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 23:07 [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil Morgan Willcock
2021-08-31 11:59 ` Timothy [this message]
2021-08-31 12:42 ` Morgan Willcock
2021-08-31 12:54 ` Timothy
2021-09-19 13:13 ` Timothy
2021-09-19 15:30 ` Morgan Willcock
2021-09-19 17:02 ` Timothy
-- strict thread matches above, loose matches on Subject: below --
2021-08-17 22:28 Morgan Willcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgsxom7k.fsf@gmail.com \
--to=tecosaur@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mwillcock@precedence.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.