From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: ELPA: New package: nano-theme Date: Wed, 29 Sep 2021 06:24:20 +0000 Message-ID: <87zgrvucff.fsf@posteo.net> References: <87bl4c6197.fsf@posteo.net> <8735po5ywp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30896"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Nicolas P. Rougier (inria)" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 29 08:26:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVT2s-0007tU-81 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 08:26:22 +0200 Original-Received: from localhost ([::1]:38904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVT2r-0006zK-AJ for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Sep 2021 02:26:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVT14-0005P6-Ah for emacs-devel@gnu.org; Wed, 29 Sep 2021 02:24:30 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVT10-0001nj-Sg for emacs-devel@gnu.org; Wed, 29 Sep 2021 02:24:30 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7167F240029 for ; Wed, 29 Sep 2021 08:24:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1632896663; bh=tW3Vwc1xXozNbNK4VBYjT/yJ6a53A0UT7Ru0HAsEIG0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=dUHp5rlr6QVhja9W8hXZYjPHeaEIQu9fyHMAfVjF0LCt32Z57piNpk9JVHn4sxmJf kDf6fn+48/YIvC4PzipPHIEEDQpS6gLavZxd9b/4LLye/Ke+uxPud7ySsro8zzr15k fOWRJQ93o8MdjhWKvkto3T9HwHvVIVzOYchI03jyNDxKVrcejST394nHUs7VgABWts VplnZVaiakXlqCtDEcL+uuhVciVWf11ut/wnFaM6ujblWVeAfKWGODPyMnZO7NXgMH Jb7MVdtXXGWipizpmyB7mjao6UvvdWKqTmj0mV/ZzMGibwVWMB2lHkBx0mJ499rKj4 rfhRLq+Ysrdlw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HK5ts685Wz9rxB; Wed, 29 Sep 2021 08:24:21 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (Nicolas P. Rougier's message of "Wed, 29 Sep 2021 07:07:40 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275765 Archived-At: "Nicolas P. Rougier (inria)" writes: >>>> Furthermore, I wonder why you define the commands nano-light and >>>> nano-dark, instead of two themes, nano-light and nano-dark (along >>>> the >>>> same lines of what modus-themes currently does). You could also >>>> turn >>>> nano-setup into a custom theme, so that the user can easily enable >>>> and >>>> disable it. >>> >>> Maybe I need to read the documentation on what a theme can set. For >>> example, I set the face for the minibuffer (0 & 1) and echo area (0 >>> & >>> 1) and I wasn't sure how to specify this in a theme. Same for >>> underline to be set at descent line, etc. >> >> Not directly, but you could define a custom option/minor mode that >> is >> activated as part of the theme to change these things too. > > But then you need to load the theme and activate the minor mode, do > you?. Having a (nano-light) command is more direct in my opinion and > in any case, user is free to only load the theme the regular way. No, a custom theme can enable a custom option (via custom-theme-set-variables), and since every minor mode is also a user option, you can enable a minor mode as part of a theme. >>>> - Lines 363ff. seem to be indented unconventionally. Maybe add a >>>> .dir-locals.el to make sure everyone is using the same >>>> whitespace >>>> configuration. > > I had a mix of space and tabs for unknown reason. Hopefully it has > been fixed. > > Nicolas > -- Philip Kaludercic