script-representative-chars for emoji

script-representative-chars for emoji

[Robert Pluim]

Hi,

I added the following

        (emoji #x1F300 #x1F600 #xFE0F)))

to script-representative-chars when creating the emoji script, but Iʼm
now wondering if that #xFE0F was a mistake, as there are fonts that
can represent emoji that won't have a glyph for VS-16. Iʼve not
noticed any negative effects so far, but perhaps we should remove it
in emacs-28?

Thanks

Robert
-- 

Re: script-representative-chars for emoji

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Gmane-Reply-To-List: yes
> Date: Mon, 04 Oct 2021 16:55:38 +0200
> 
> Hi,
> 
> I added the following
> 
>         (emoji #x1F300 #x1F600 #xFE0F)))
> 
> to script-representative-chars when creating the emoji script, but Iʼm
> now wondering if that #xFE0F was a mistake, as there are fonts that
> can represent emoji that won't have a glyph for VS-16. Iʼve not
> noticed any negative effects so far, but perhaps we should remove it
> in emacs-28?

Didn't we add VS-16 to have sequences that begin with non-Emoji
character and end in VS-16 displayed in Emoji font, the change you did
in font_ranges?  If you remove it, what happens to the likes of U+25AB
followed by U+FE0F ?

Re: script-representative-chars for emoji

[Robert Pluim]

>>>>> On Mon, 04 Oct 2021 19:37:56 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Gmane-Reply-To-List: yes
    >> Date: Mon, 04 Oct 2021 16:55:38 +0200
    >> 
    >> Hi,
    >> 
    >> I added the following
    >> 
    >> (emoji #x1F300 #x1F600 #xFE0F)))
    >> 
    >> to script-representative-chars when creating the emoji script, but Iʼm
    >> now wondering if that #xFE0F was a mistake, as there are fonts that
    >> can represent emoji that won't have a glyph for VS-16. Iʼve not
    >> noticed any negative effects so far, but perhaps we should remove it
    >> in emacs-28?

    Eli> Didn't we add VS-16 to have sequences that begin with non-Emoji
    Eli> character and end in VS-16 displayed in Emoji font, the change you did
    Eli> in font_ranges?  If you remove it, what happens to the likes of U+25AB
    Eli> followed by U+FE0F ?

We added it to the emoji script, but that doesnʼt mean it needs to be
in script-representative-chars. U+25AB U+FE0F is still composed
correctly and displays with the colourful emoji glyph if I remove it
from there.

Robert
-- 

Re: script-representative-chars for emoji

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 04 Oct 2021 18:55:55 +0200
> 
>     >> I added the following
>     >> 
>     >> (emoji #x1F300 #x1F600 #xFE0F)))
>     >> 
>     >> to script-representative-chars when creating the emoji script, but Iʼm
>     >> now wondering if that #xFE0F was a mistake, as there are fonts that
>     >> can represent emoji that won't have a glyph for VS-16. Iʼve not
>     >> noticed any negative effects so far, but perhaps we should remove it
>     >> in emacs-28?
> 
>     Eli> Didn't we add VS-16 to have sequences that begin with non-Emoji
>     Eli> character and end in VS-16 displayed in Emoji font, the change you did
>     Eli> in font_ranges?  If you remove it, what happens to the likes of U+25AB
>     Eli> followed by U+FE0F ?
> 
> We added it to the emoji script, but that doesnʼt mean it needs to be
> in script-representative-chars. U+25AB U+FE0F is still composed
> correctly and displays with the colourful emoji glyph if I remove it
> from there.

Then I'm okay with removing it.

Re: script-representative-chars for emoji

[Robert Pluim]

>>>>> On Mon, 04 Oct 2021 20:07:15 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> We added it to the emoji script, but that doesnʼt mean it needs to be
    >> in script-representative-chars. U+25AB U+FE0F is still composed
    >> correctly and displays with the colourful emoji glyph if I remove it
    >> from there.

    Eli> Then I'm okay with removing it.

Done.

Robert
--