From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Emacs Lisp code formatting Date: Sun, 07 Nov 2021 02:37:25 +0100 Message-ID: <87zgqglp9m.fsf@web.de> References: <87mtmmlgr6.fsf@gnus.org> <87lf23o5qh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18431"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 07 02:38:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjX8G-0004Zm-4H for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Nov 2021 02:38:04 +0100 Original-Received: from localhost ([::1]:40918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjX8E-0007kQ-QA for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Nov 2021 21:38:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjX7i-00074h-6Z for emacs-devel@gnu.org; Sat, 06 Nov 2021 21:37:30 -0400 Original-Received: from mout.web.de ([212.227.15.3]:57749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjX7g-0003Ab-ES for emacs-devel@gnu.org; Sat, 06 Nov 2021 21:37:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1636249046; bh=9okLM8Q4dM5e9mMR3qXL96DgCYX5o1seT41eAQqjanw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=k/sTsYW3Zh5fuOHZ3Rrg9lB5c8TDOXbxGXANNqumwObFkdO3cjEh2tJ/3eLZtyRZW Xtko+iDDLiipF6f61JKIfFNlaSoAhwQyB6A9kXPBZd/OjoaJvCw+UapZJx9hJvDOdO +jMkxGpgFAKAS8LoXPsUANvuZRFIW/gOwZmaeqZc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([92.208.225.87]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MlbHC-1mIgpY1UkE-00iZrW; Sun, 07 Nov 2021 02:37:26 +0100 In-Reply-To: <87lf23o5qh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Nov 2021 00:34:14 +0100") X-Provags-ID: V03:K1:pHM0SVEpCjaI8yZx2UiybzMOmSrk5981rLRO90iVa8ndV6iJuY2 kwl97aRlzzRAyaab3n6OqnMSFV1iJq2/USKyQ5z6tXWndtHhaavt2HH+iSyqh+RGjFt8vGL 4DBVGjBvRM5vucxqYfJTwdoW/MMY0l0qYC1VWzW6PbM166PcTilZDJkBi/Pn6GqLJ+zexuE dChd053v3ut8lY04mWtTA== X-UI-Out-Filterresults: notjunk:1;V03:K0:N2Uq0OWaczk=:/UuJ5hfWeExkEro2984c64 wNGc6v/i0vGa5ZyS55NWEH/fTm/6aeSVISiSjH9GMUKn7Foi5yHojwCOrWtDTOainy/qptAQA uMxgFmLor4VmHEPp/lq+JqB5M/T8oJ+7C+NaO86wB4cUes+NZXoImry2xugbH6K/TCQ/A5XQ+ wkwHU7g0OPg+FKPiS4CyEt+y9hdhnPh5fw3aeUxAh9jzDCO0KzXiLQXzWIYiHXv6Xa/Q67J5c 79R0aEYsA0IYYu42GbA5CanPLfNPv6h6A/SBEHtYQT93VgkT1tiwyZTQ8D2yYYMyDqHOSdujn PD3+yIAjg02A8GHUsqzbNt7BRWjYmllF2elweKu7PI0u4QCVVBSyohifiR7SH4jXHPQCiAW8A Ol33pUPV4FcW7qJ88hFgNFvu9VE1A29UvI/qX9+0lmNLMzZdmBTli+UnTDUMBPD3KHY1LZeGe tOFw0hZfMTzXMzOj//Yi/aN1oH50w42ZO4Drlc/+Q8u7P4v9HtdrHzqVePingt78CnKN03XHJ WPho95ai+Sa9SL1aO4p7Yl3qb1MeP/aVl2/vRpJC9njFFtOvPVm6zKlNND+NzhVqtI5/rzwvB Ftf5iPEqONBLVpduHblGGEd1fq6yRJ0gNunNsgQWiFOwYaq7PVaBa3RmZMMWjaoyEUQExBYle 7fOy094sEUM+nJ5oMTu31VElnFhHaiNJJS5KYX4P1BYC3ljtQSgaco/80jgF6Cm88vvcFfPFw /Fk5ZA1oHvOeRnr5x8ooximEIWXumyTCJB3qJcjUlnueJkSrEpjh4FBXRh6xnFkZfWp1zXs5 Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278903 Archived-At: Lars Ingebrigtsen writes: > with `pp-emacs-lisp-code'. Cool - thanks for that. May I ask why something like (pp-emacs-lisp-code '(when t 1)) fails - can you have a look please? Seems there is a minor problem with edebug spec inspection. (wrong-type-argument listp t) car(t) (consp (car edebug)) (and (consp (car edebug)) (eq (car (car edebug)) '&rest)) (if (and (consp (car edebug)) (eq (car (car edebug)) '&rest)) (pp--insert-binding (car-safe (prog1 sexp (setq sexp (cdr sexp))))) (if (null (car sexp)) (insert "()") (pp--insert-lisp (car sexp))) (car-safe (prog1 sexp (setq sexp (cdr sexp))))) (while (and (cl-plusp indent) sexp) (insert " ") (if (and (consp (car edebug)) (eq (car (car edebug)) '&rest)) (pp--insert-binding (car-safe (prog1 sexp (setq sexp (cdr sexp))))) (if (null (car sexp)) (insert "()") (pp--insert-lisp (car sexp))) (car-safe (prog1 sexp (setq sexp (cdr sexp))))) (car-safe (prog1 edebug (setq edebug (cdr edebug)))) (setq indent (1- indent))) pp--format-definition((t 1) 1 t) (if indent (pp--format-definition sexp indent edebug) (let ((prev 0)) (while sexp (let ((start (point))) (pp--insert (if (> prev 1) "\n" " ") (car-safe (prog1 sexp (setq sexp ...)))) (setq prev (count-lines start (point))))))) (let* ((sym (car sexp)) (edebug (get sym 'edebug-form-spec)) (indent (get sym 'lisp-indent-function)) (doc (get sym 'doc-string-elt))) (if (eq indent 'defun) (progn (setq indent 2))) (if doc (progn (setq indent (1- doc)))) (if (and (not indent) (eq sym 'closure)) (progn (setq indent 0))) (pp--insert "(" sym) (car-safe (prog1 sexp (setq sexp (cdr sexp)))) (if indent (pp--format-definition sexp indent edebug) (let ((prev 0)) (while sexp (let ((start (point))) (pp--insert (if (> prev 1) "\n" " ") (car-safe (prog1 sexp ...))) (setq prev (count-lines start (point))))))) (insert ")")) pp--format-function((when t 1)) [...] Thanks, Michael.