bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Hi all,

yanking text from clipboard into Emacs doesn't work for me.  Yanking
control@debbugs.gnu.org into Emacs looks like this:

[-- Attachment #2: yank.png --]
[-- Type: image/png, Size: 7623 bytes --]

[-- Attachment #3: Type: text/plain, Size: 272 bytes --]


Steps to reproduce:
1) Start Emacs with emacs -Q (from a MinGW64 shell)
2) Open Windows Editor
3) Enter control@debbugs.gnu.org in Editor
4) Mark and Copy in Editor
5) Yank in scratch with C-y

This is Emacs 990aad47 from master.

Can others reproduce this?

Best, Arash

bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

[Lars Ingebrigtsen]

Arash Esbati <arash@gnu.org> writes:

> Steps to reproduce:
> 1) Start Emacs with emacs -Q (from a MinGW64 shell)
> 2) Open Windows Editor
> 3) Enter control@debbugs.gnu.org in Editor
> 4) Mark and Copy in Editor
> 5) Yank in scratch with C-y

Does reverting 5e66c75e0 fix the issue?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Arash Esbati <arash@gnu.org> writes:
>
>> Steps to reproduce:
>> 1) Start Emacs with emacs -Q (from a MinGW64 shell)
>> 2) Open Windows Editor
>> 3) Enter control@debbugs.gnu.org in Editor
>> 4) Mark and Copy in Editor
>> 5) Yank in scratch with C-y
>
> Does reverting 5e66c75e0 fix the issue?

I've reverted it now and will have to reexamine the problem before
attempting a new fix.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

[Arash Esbati]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Arash Esbati <arash@gnu.org> writes:
>>
>>> Steps to reproduce:
>>> 1) Start Emacs with emacs -Q (from a MinGW64 shell)
>>> 2) Open Windows Editor
>>> 3) Enter control@debbugs.gnu.org in Editor
>>> 4) Mark and Copy in Editor
>>> 5) Yank in scratch with C-y
>>
>> Does reverting 5e66c75e0 fix the issue?
>
> I've reverted it now and will have to reexamine the problem before
> attempting a new fix.

Thanks, I also just tried it and 5e66c75e0 is the problematic change.
I'm closing this report for now.

Best, Arash

bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 08 Nov 2021 12:27:43 +0100
> Cc: 51685@debbugs.gnu.org
> 
> >> 1) Start Emacs with emacs -Q (from a MinGW64 shell)
> >> 2) Open Windows Editor
> >> 3) Enter control@debbugs.gnu.org in Editor
> >> 4) Mark and Copy in Editor
> >> 5) Yank in scratch with C-y
> >
> > Does reverting 5e66c75e0 fix the issue?
> 
> I've reverted it now and will have to reexamine the problem before
> attempting a new fix.

Whatever you do, don't decode the selection text on MS-Windows.  It is
already decoded (see w32-get-clipboard-data), and
selection-coding-system is UTF-16 on MS-Windows, so decoding a decoded
string by that will not do anything useful ;-)

The existing code carefully side-steps the decoding by looking at the
foreign-selection property on the string, which the Windows code
doesn't set.  But your changes removed that test, and thus caused the
clipboard text to be decoded on Windows.

bug#51685: 29.0.50; Yanking from clipboard broken (Win10)

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> The existing code carefully side-steps the decoding by looking at the
> foreign-selection property on the string, which the Windows code
> doesn't set.  But your changes removed that test, and thus caused the
> clipboard text to be decoded on Windows.

Ah, I see.  Thanks for the explanation.  I plan on getting my Windows
VMs up and running again (I'm in the middle of switching some computers
here) so that I can do some testing on Windows too, and then I'll
attempt the fix again.  😀

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no