From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: xenodasein@tutanota.de, Emacs Devel <emacs-devel@gnu.org>
Subject: Re: The new keymap functions
Date: Sun, 14 Nov 2021 19:00:14 +0100 [thread overview]
Message-ID: <87zgq64nyp.fsf@gnus.org> (raw)
In-Reply-To: <jwvh7cevjgx.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 14 Nov 2021 10:41:58 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> We presumably want to keep doing this for backwards compatibility, so I
>> guess adding a new optional parameter to `define-key' to really set it
>> to nil if requested is the way to go? (And the same in the sparse-map
>> case.)
>
> That's right: the best way to write a "remove key-binding" function is
> most likely to make `define-key` accept a special
> `:internal-remove-binding` value for the binding: for char-tables and
> arrays you can just make it store a nil in the table, and for cons
> cells, it should remove the cons-cell (which will probably require more
> changes to the code, tho maybe you can get away with calling `delq` to
> remove the cons cell rather than having to remember the previous
> cons-cell so your can `setcdr` it).
Yup. But I added a REMOVE parameter to `define-key' instead -- that
seems cleaner than a new magical value.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-14 18:00 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 18:59 The new keymap functions xenodasein--- via Emacs development discussions.
2021-11-14 0:42 ` Lars Ingebrigtsen
2021-11-14 4:56 ` Lars Ingebrigtsen
2021-11-14 15:41 ` Stefan Monnier
2021-11-14 18:00 ` Lars Ingebrigtsen [this message]
2021-11-14 12:04 ` xenodasein--- via Emacs development discussions.
-- strict thread matches above, loose matches on Subject: below --
2021-11-13 6:56 Lars Ingebrigtsen
2021-11-13 7:31 ` Stefan Kangas
2021-11-13 7:50 ` Lars Ingebrigtsen
2021-11-13 11:36 ` Joost Kremers
2021-11-13 12:07 ` Lars Ingebrigtsen
2021-11-15 13:01 ` Dmitry Gutov
2021-11-15 16:53 ` Lars Ingebrigtsen
2021-11-16 7:28 ` Lars Ingebrigtsen
2021-11-16 14:08 ` Eli Zaretskii
2021-11-16 14:24 ` Lars Ingebrigtsen
2021-11-16 15:13 ` Eli Zaretskii
2021-11-16 15:19 ` Lars Ingebrigtsen
2021-11-16 17:16 ` Eli Zaretskii
2021-11-17 7:30 ` Lars Ingebrigtsen
2021-11-13 15:09 ` Stefan Monnier
2021-11-13 15:24 ` Lars Ingebrigtsen
2021-11-14 3:17 ` Lars Ingebrigtsen
2021-11-14 5:05 ` Phil Sainty
2021-11-14 5:14 ` Lars Ingebrigtsen
2021-11-14 7:15 ` Eli Zaretskii
2021-11-14 10:53 ` Lars Ingebrigtsen
2021-11-14 11:01 ` Lars Ingebrigtsen
2021-11-14 7:41 ` Yuri Khan
2021-11-15 4:52 ` Richard Stallman
2021-11-15 5:14 ` Lars Ingebrigtsen
2021-11-16 4:05 ` Richard Stallman
2021-11-16 7:38 ` Lars Ingebrigtsen
2021-11-17 4:16 ` Richard Stallman
2021-11-17 7:55 ` Lars Ingebrigtsen
2021-11-16 20:14 ` Juri Linkov
2021-11-17 4:16 ` Richard Stallman
2021-11-17 7:36 ` Lars Ingebrigtsen
2021-11-17 8:10 ` Juri Linkov
2021-11-17 9:42 ` Robert Pluim
2021-11-17 17:03 ` Juri Linkov
2021-11-18 9:15 ` Lars Ingebrigtsen
2021-11-18 10:25 ` Robert Pluim
2021-11-18 10:33 ` Lars Ingebrigtsen
2021-11-18 10:37 ` Lars Ingebrigtsen
2021-11-18 10:54 ` Robert Pluim
2021-11-18 10:59 ` Lars Ingebrigtsen
2022-11-15 18:38 ` Juri Linkov
2022-11-17 7:31 ` Juri Linkov
2022-11-17 8:35 ` Robert Pluim
2022-11-17 15:04 ` Robert Pluim
2022-11-17 17:29 ` Juri Linkov
2022-11-18 8:33 ` Robert Pluim
2022-11-18 15:41 ` Robert Pluim
2023-03-17 14:48 ` Robert Pluim
2023-03-18 18:04 ` Juri Linkov
2023-03-20 8:54 ` Robert Pluim
2021-11-17 20:57 ` Bob Rogers
2021-11-18 3:53 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgq64nyp.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=xenodasein@tutanota.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.