all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Add command to browse xwidget history
Date: Mon, 15 Nov 2021 10:40:11 +0100	[thread overview]
Message-ID: <87zgq5bvus.fsf@gmail.com> (raw)
In-Reply-To: <87a6i62e45.fsf@yahoo.com> (Po Lu's message of "Mon, 15 Nov 2021 13:15:54 +0800")

>>>>> On Mon, 15 Nov 2021 13:15:54 +0800, Po Lu <luangruo@yahoo.com> said:

    Po> +@findex xwidget-webkit-browse-history
    Po> +@cindex history of webkit buffers
    Po> +  The command @code{xwidget-webkit-browse-history} displays a buffer
    Po> +containing a list of pages once loaded by the current WebKit buffer,

'previously loaded'

    Po> +and lets you navigate to those pages by hitting @kbd{RET}.
    Po> +
    Po> +It is bound to @kbd{H}.
    Po> +
    Po>  @node Browse-URL
    Po>  @subsection  Following URLs
    Po>  @cindex World Wide Web
    Po> diff --git a/etc/NEWS b/etc/NEWS
    Po> index 312fc18f4f..cda29650c0 100644
    Po> --- a/etc/NEWS
    Po> +++ b/etc/NEWS
    Po> @@ -486,6 +486,12 @@ This mode acts similarly to incremental search, and allows to search
    Po>  the contents of a WebKit widget.  In xwidget-webkit mode, it is bound
    Po>  to 'C-s' and 'C-r'.
 
    Po> ++++
    Po> +*** New command 'xwidget-webkit-browse-history'.
    Po> +This command displays a buffer containing the page load history of
    Po> +the current WebKit widget, and allows you to navigate to various
    Po> +points in history.
    Po> +

Short phrases are better: 'allows you to navigate it'

    Po> +               (when (get-buffer "*Xwidget WebKit History*")
    Po> +                 (with-current-buffer "*Xwidget WebKit History*"
    Po> +                   (revert-buffer)))

Minor optimisation: use `when-let'. Avoid repetition. DRY 😄

Robert
-- 



  reply	other threads:[~2021-11-15  9:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a6i62e45.fsf.ref@yahoo.com>
2021-11-15  5:15 ` Add command to browse xwidget history Po Lu
2021-11-15  9:40   ` Robert Pluim [this message]
2021-11-15  9:58     ` Po Lu
2021-11-15 12:56   ` Eli Zaretskii
2021-11-15 12:58     ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgq5bvus.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.