From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string. Date: Tue, 04 Jan 2022 16:44:55 +0100 Message-ID: <87zgoby07c.fsf@gmail.com> References: <164071493472.13037.4763332286147886616@vcs2.savannah.gnu.org> <20211228180855.231F5C002EE@vcs2.savannah.gnu.org> <87h7aj1vlf.fsf@gmail.com> <83czl7blbn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1565"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 04 16:46:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4m1B-000Ady-FV for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Jan 2022 16:46:33 +0100 Original-Received: from localhost ([::1]:52344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4m19-0005wj-HC for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Jan 2022 10:46:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4lzh-0004zw-5Q for emacs-devel@gnu.org; Tue, 04 Jan 2022 10:45:01 -0500 Original-Received: from [2a00:1450:4864:20::432] (port=43588 helo=mail-wr1-x432.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4lzf-0001To-Gc; Tue, 04 Jan 2022 10:45:00 -0500 Original-Received: by mail-wr1-x432.google.com with SMTP id o3so18815240wrh.10; Tue, 04 Jan 2022 07:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=q99cunaEV2HZCIuasspDhJy48x6sS/fYAZYsrdH75FE=; b=T4isret997uuAamFq1pen0W0KaIt8FW7zqVerMX3/pHY5Gkk619lFbQ48Tc2f2Syaw OZeZaVbmEwr6RMJE1S32hlYiOMjpklaAutbd8sunzIs58xAzpX9E8TZ0zK8fBWKqeM+a LA3NfxKFx3HHLY8Xj4VqlznoU0VWbud2F7fZMeA+iYhGx6NgJ42czAhKs+Pn7ZK6a7Ii WUxT8RT2fjCNOIalQR/fI+upOPV/GaoUW0F2yaik9iznNr+M6guzSF/IKxuIbmpBCEMU JDLY040i1jKW/iW/wjMRtQ/sgTHMCsbBVmft5xsBPfhWxa3aauSisOxUFn9o+DcAmdne ZBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=q99cunaEV2HZCIuasspDhJy48x6sS/fYAZYsrdH75FE=; b=FqqaAI7MsCZwc9itHdujd3Kz2WWxVWFBqywHZYwcYFeZc1aVZk0yaXozQWw9qYozHA R/BM5Pj02Li/EIBxBIQy7MxFbY+Q1oKGBZxnDojNmhY+N7ax+F5Svw2jlsf/ja6D+tc0 x2BB8URRIHXQogLrkQsjWHEm/A3reWtX9LtA41XwVgYYxCQuZ+NcrTIq5id2GvSydCo3 NR+B91AcTWjmvDLjYuqJLIa4dHXDPrA1RVdOByqIXTLA4B/TVQoE2aBXB2oiixiwqB6T 5XLItQLNzXvSTDOACKImeUMAWTfS7NbFyVBrERPr8Bx1eIFTPBL2WVngZAVq9kthNNo1 0IYA== X-Gm-Message-State: AOAM533GEsq7Nii3p4ijtz46FY+sA6PH1SvNb17Y7QakV1YblQe5YNnD 0bOj6F8aYledHjodyZ+U58zqkKj0uAI= X-Google-Smtp-Source: ABdhPJxrRkQipYvqh0CMZoi3k5+qoTml8XL8+Zv1ft77CfTmWerWIEeNPNRzvNmfH65XjTkP8MMsBg== X-Received: by 2002:adf:d0cd:: with SMTP id z13mr42813525wrh.103.1641311097198; Tue, 04 Jan 2022 07:44:57 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:b7b1:2297:22b1:5565]) by smtp.gmail.com with ESMTPSA id p18sm9203894wmq.23.2022.01.04.07.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 07:44:56 -0800 (PST) In-Reply-To: <83czl7blbn.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 04 Jan 2022 16:57:16 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::432 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=rpluim@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284159 Archived-At: >>>>> On Tue, 04 Jan 2022 16:57:16 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eli Zaretskii >> Date: Tue, 04 Jan 2022 14:25:32 +0100 >> Eli> -The key strokes are separated by a space character. Eli> +The key strokes are separated by space characters. >> >> This is ambiguous now. >> ELISP> (key-valid-p "a") >> t ELISP> (key-valid-p "a b") >> t ELISP> (key-valid-p "a b") >> nil >> >> Either we say 'single spaces', or we set OMIT-NULLS to t in the call >> to `split-string' inside `key-valid-p'. Eli> Feel free to improve ambiguous wording, no discussion is needed. I asked because we had a looooong discussion about this back in November with no clear outcome, except that the code now only allows 1 space :-) Done as a0263cfee3 Robert --