From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
Date: Tue, 04 Jan 2022 16:44:55 +0100 [thread overview]
Message-ID: <87zgoby07c.fsf@gmail.com> (raw)
In-Reply-To: <83czl7blbn.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 04 Jan 2022 16:57:16 +0200")
>>>>> On Tue, 04 Jan 2022 16:57:16 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>
>> Date: Tue, 04 Jan 2022 14:25:32 +0100
>>
Eli> -The key strokes are separated by a space character.
Eli> +The key strokes are separated by space characters.
>>
>> This is ambiguous now.
>>
ELISP> (key-valid-p "a")
>> t
ELISP> (key-valid-p "a b")
>> t
ELISP> (key-valid-p "a b")
>> nil
>>
>> Either we say 'single spaces', or we set OMIT-NULLS to t in the call
>> to `split-string' inside `key-valid-p'.
Eli> Feel free to improve ambiguous wording, no discussion is needed.
I asked because we had a looooong discussion about this back in
November with no clear outcome, except that the code now only allows 1
space :-)
Done as a0263cfee3
Robert
--
prev parent reply other threads:[~2022-01-04 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164071493472.13037.4763332286147886616@vcs2.savannah.gnu.org>
[not found] ` <20211228180855.231F5C002EE@vcs2.savannah.gnu.org>
2022-01-04 13:25 ` master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string Robert Pluim
2022-01-04 14:57 ` Eli Zaretskii
2022-01-04 15:44 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgoby07c.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.