From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 1e15500daf: Avoid a compilation warning in eval.c Date: Sun, 13 Feb 2022 08:41:29 +0100 Message-ID: <87zgmvz00m.fsf@gnus.org> References: <164473722933.14008.9727236307853911285@vcs2.savannah.gnu.org> <20220213072709.94934C00891@vcs2.savannah.gnu.org> <875ypjmdhf.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6608"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 13 08:42:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ9Wf-0001X7-MW for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 08:42:29 +0100 Original-Received: from localhost ([::1]:50870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJ9We-0003DA-7x for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 02:42:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJ9Vu-0002Wj-JY for emacs-devel@gnu.org; Sun, 13 Feb 2022 02:41:42 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=39948 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJ9Vs-0005Ox-Mx for emacs-devel@gnu.org; Sun, 13 Feb 2022 02:41:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=m8nf7bykVRYlf+UMq9DjA6xPi/KODnLLe8Mk3AGCTZg=; b=eqcu6UWdr8keePCVtwujxBvsih 9QIskzucWNsfFAuUn8v6YvQr0xkGnVGjKn+Z76r0gNXVEpY0GVukldlxhOWa4b8n+lGXFO79kWPiy 2HklUxTIA4QSXCFS/bGZibpHeQr6ggIc16uFK3blEY+iFC6PTrSoNbErI3aJftVXr4OM=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ9Vl-0000Aw-Da; Sun, 13 Feb 2022 08:41:36 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUqEwhaPya8on7/ //8YYY7rAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YCDQcoLO6pDU4AAAGuSURBVCjPbZLBjptADIb/ iQCpnEDKRIR7D7tPMVPBHjhBxYwazkHa8hS02pXanqAqq4ZTU4Wo+ClrSNVe6jmMPtm/bdkG4EFo iHaLxTyZlIF+SlYQ8rt8/SF6zlfYJpDaSdQCbploqZNk9Xjms6k/fjp1qwgOQuXcEqw6dfulaYY8 lUoWLpRrmrE4+aoaDZx4MOPxkOmmMoB/GFw5+WltC6hYG7OfMl2bAYgv5zozWS7TiqHpHqvDvqRu x1CdzD3FBXWWwb5MDVU9dT7DuaORRjs+c1G/7+rrlbJTYxiG80DXa/Vj4qLx1PfEplTAHfR5SD9n 2+aLpoNkiJUdOewIMwty8fAFIr6I9LinEm9G5PEFJm0OMzbZ6jH7+2LGq4w1v0R4x62pyFsA4bs4 J+VsGGaE5a6gFgsUSgauplZsoCIop5SaFAQQCC0i5O+xQsjTLIYD3AISgYSxTwQXKIWqNI0tpTxq 1jZfidq6YFCRJMswDS0niOJ5R/RCttNQgT+/PfN8bLuukXqOUw/rGlP65tEMb1mwm/YTmgv+Yw4C bHE7HT4KaZaX/4HkL/yz3+Tqj3Pi43mBAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTAyLTEzVDA3 OjQwOjQ0KzAwOjAwRbmJAQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wMi0xM1QwNzo0MDo0NCsw MDowMDTkMb0AAAAASUVORK5CYII= X-Now-Playing: Revolting Cocks's _Beers, Steers & Queers (remixes)_: "Beers, Steers & Queers (Take 'Em Right Off Mix)" In-Reply-To: <875ypjmdhf.fsf@yahoo.com> (Po Lu's message of "Sun, 13 Feb 2022 15:29:00 +0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286204 Archived-At: Po Lu writes: >> non-local, this is fine, but if it ever reverts to being >> local we may end up using this entry "in the wrong >> direction". */ >> - ; >> + {}; >> } >> break; >> } > > That's kind of ugly -- how about removing the else branch entirely, just > leaving the comment? I assumed that Stefan was still pondering what to do here, and I just wanted to avoid the compilation warning meanwhile. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no