From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master c3e064013e: (loadhist_initialize): Minor refactoring Date: Sun, 20 Feb 2022 17:25:45 +0100 Message-ID: <87zgmlo67q.fsf@gnus.org> References: <164529794270.21544.9359599065415833998@vcs2.savannah.gnu.org> <20220219191223.AD5F7C00894@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35700"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 20 17:27:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLp3k-00099B-RY for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Feb 2022 17:27:40 +0100 Original-Received: from localhost ([::1]:57694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLp3j-00062C-BI for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Feb 2022 11:27:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLp2A-0005Fw-Ep for emacs-devel@gnu.org; Sun, 20 Feb 2022 11:26:02 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=46670 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLp25-0004eS-0F for emacs-devel@gnu.org; Sun, 20 Feb 2022 11:26:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Len/FDWbyhF9296oFu9Nv6QKJ2nxv6t5KUZc4taAuPE=; b=Oq9yCkGrc/pmlS6bsbFQ7xPbaT kwpjiZBiUUSIKLKpbgPRkyXobFh+wPEsIOIuk63EZbpJaVdLJWhWspzxJx0jzr31sxCbpjdee6IsF oygEYNCEavzGIZusPN/vudVgh39CWjl+7jEBd9Twah6emoVEPE0FZxDkEa6DiYEDn/w4=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLp1y-0003tS-Cv; Sun, 20 Feb 2022 17:25:53 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEXf3OGinKJeXWV5 fII3PDiTRWKLdIb///+EXnM9AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YCFA84Hk++BzIAAAGqSURB VDjLlZNNVuMwDMfNYw7gj6brWjGs64Q5AELdU17dNfDm5f5HGEl20lDKAm0i++e/JEuOMT/Znbtp 1phfg7tfA4jfd0NmQPgd+CiA2MEfgON43eECNgtg+0fnrwBTXZyonD8aeIqr5N3jdvqErH4S4NdZ U7yE0tNlDv5yCcXffCKaNH6r28+AiIqmDqyYpuntPCn4ywAfS2GS3baovRpO1zE4HHglN2ngXRQC HgSUN3dRSDLJcfioyRUctwp8IvwctB7g0nnf1Kp8gghQL5K7cjqaBiK66KHdgBV2BbyfB9mV4wJg PSd/OtaZs+vyau6+uBkEKQZcg9virD4GXUUgem4KArZ+V0EiWqLxGW6dAs+O3q8NbWC55vCY4nqQ oQE5Gr68KySs5V4bEexvglQVLsT5EkthaG/+N4C3QYB0BUI/cnlPPQxXwHMzsickoP0K+D4xcBvu CNBuAWHkhgHszB9uUEwLCAMosEYUfQM5jAMoiMbsE5IoskxqlBkI2BnzvEFMnEPaN+oMJCm/AxTn xZowjuOQ6j721tyLI78BCJgF0VVgg/0P62eIKa0DbTMAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjIt MDItMjBUMTU6NTY6MzArMDA6MDDworDHAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTAyLTIwVDE1 OjU2OjMwKzAwOjAwgf8IewAAAABJRU5ErkJggg== X-Now-Playing: Humcrush with Sidsel Endresen's _ha!_: "ha! 9" In-Reply-To: <20220219191223.AD5F7C00894@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Sat, 19 Feb 2022 14:12:22 -0500 (EST)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286521 Archived-At: Stefan Monnier via Mailing list for Emacs changes writes: > (loadhist_initialize): Minor refactoring > > Consolidate a bit of code. > > * src/lread.c (loadhist_initialize): New function. > (Fload, readevalloop): Use it. It seems like this makes a number of tests fail: bin/bash: line 3: 3621759 Aborted HOME=3D/nonexistent LANG= =3DC EMACS_TEST_DIRECTORY=3D/home/larsi/src/emacs/trunk/test "../src/emacs"= --module-assertions --no-init-file --no-site-file --no-site-lisp -L ":." -= l ert -l lisp/emacs-lisp/gv-tests --batch --eval '(ert-run-tests-batch-and-= exit (quote (not (or (tag :expensive-test) (tag :unstable)))))' > lisp/emac= s-lisp/gv-tests.log 2>&1 Running 8 tests (2022-02-20 17:21:24+0100, selector =E2=80=98(not (or (tag = :expensive-test) (tag :unstable)))=E2=80=99) lread.c:1175: Emacs fatal error: assertion failed: STRINGP (filename) make[3]: *** [Makefile:184: lisp/emacs-lisp/gv-tests.log] Error 134 make[3]: Leaving directory '/home/larsi/src/emacs/trunk/test' make[2]: [Makefile:341: check-doit] Error 2 (ignored) SUMMARY OF TEST RESULTS ----------------------- Files examined: 395 Ran 5965 tests, 158 failed to run, 5835 results as expected, 0 unexpected, = 130 skipped 5 files did not finish: src/lread-tests.log lisp/simple-tests.log lisp/emacs-lisp/gv-tests.log lisp/emacs-lisp/edebug-tests.log lisp/emacs-lisp/cl-generic-tests.log This is with --with-native-compilation, if that makes a difference. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no