From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support Date: Mon, 07 Mar 2022 17:31:21 +0100 Message-ID: <87zgm1912e.fsf@gnus.org> References: <87mti2env9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11669"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Daniel Nicolai , emacs-devel@gnu.org To: Kjartan Oli Agustsson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 07 17:32:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRGHi-0002os-14 for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 17:32:34 +0100 Original-Received: from localhost ([::1]:43728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRGHg-00067E-Vh for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 11:32:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRGGf-0005HH-AH for emacs-devel@gnu.org; Mon, 07 Mar 2022 11:31:30 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=46712 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRGGd-00053t-7u for emacs-devel@gnu.org; Mon, 07 Mar 2022 11:31:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nt36mZsawE3Ewyldx1m6wYlBe8FOsJvhXPDYvBQnK4U=; b=BWQhTdfurXOT1cl39MSNJaXsfx 7aEuqPoP8OeoJCU818kqrutJzLfJncUsGb1SxCamQHW6B0w+SWzTSAf+Pj4QiHDTEDOZ2MS4I+lWd ojFtUIPnSW9atzH4ldG/vhzWmtkJzdpcglDBsJiZB/AFJVU0zRhBsfXUo0ibhnshf8AA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRGGY-0002hR-Ag; Mon, 07 Mar 2022 17:31:24 +0100 X-Now-Playing: Fad Gadget's _Incontinent_: "Plain Clothes" In-Reply-To: (Kjartan Oli Agustsson's message of "Mon, 07 Mar 2022 00:50:18 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286895 Archived-At: Kjartan Oli Agustsson writes: > This should take care of that. Thanks; applied to Emacs 29. This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? > But now there's something else I'm wondering about. If I'm > understanding `doc-view-custom-set-epub-font-size' correctly, it is > used as the setter for `doc-view-epub-font-size' to regenerate epub > documents when it is changed. Am I understanding this correctly, and > if so would it make sense to do the same for the user stylesheet? When the contents of the user stylesheet changes? I guess that would make sense, and you could use `file-has-changed-p' to implement that. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no