From: Sean Whitton <spwhitton@spwhitton.name>
To: 54429@debbugs.gnu.org
Subject: bug#54429: 29.0.50; message-resend should not use the original sender's address for the envelope-from
Date: Wed, 16 Mar 2022 13:23:26 -0700 [thread overview]
Message-ID: <87zglpy7cx.fsf@melete.silentflame.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
If `message-sendmail-envelope-from' is `header' then the envelope-from
will be the original sender's address, not the resender's. But when
resending, the envelope-from should be the resender's address. Defuse
that particular case.
--
Sean Whitton
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-use-the-original-sender-s-address-as-the-envel.patch --]
[-- Type: text/x-patch, Size: 1578 bytes --]
From 03abba1ccdc8604ff7e59ab8b4c55d18185d0fd1 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Wed, 16 Mar 2022 13:19:57 -0700
Subject: [PATCH] Don't use the original sender's address as the envelope-from
* lisp/gnus/message.el (message-resend): Avoid setting the
envelope-from to the original sender's address rather than the
resender's.
---
lisp/gnus/message.el | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 800c7dcea0..ad04a5e865 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -8016,7 +8016,18 @@ message-resend
(select-safe-coding-system-function nil)
message-required-mail-headers
message-generate-hashcash
- rfc2047-encode-encoded-words)
+ rfc2047-encode-encoded-words
+ ;; If `message-sendmail-envelope-from' is `header' then
+ ;; the envelope-from will be the original sender's
+ ;; address, not the resender's. But when resending, the
+ ;; envelope-from should be the resender's address. Defuse
+ ;; that particular case.
+ (message-sendmail-envelope-from
+ (and (not (and (eq message-sendmail-envelope-from
+ 'obey-mail-envelope-from)
+ (eq mail-envelope-from 'header)))
+ (not (eq message-sendmail-envelope-from 'header))
+ message-sendmail-envelope-from)))
(message-send-mail))
(when gcc
(message-goto-eoh)
--
2.30.2
next reply other threads:[~2022-03-16 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 20:23 Sean Whitton [this message]
2022-03-17 10:57 ` bug#54429: 29.0.50; message-resend should not use the original sender's address for the envelope-from Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zglpy7cx.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=54429@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.