From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master f8b2a01a9e: * lisp/shell.el (shell): Query shell file name from `interactive`
Date: Sat, 28 May 2022 11:19:04 +0200 [thread overview]
Message-ID: <87zgj2vwtz.fsf@gmx.de> (raw)
In-Reply-To: <20220527131450.B347BC01683@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Fri, 27 May 2022 09:14:50 -0400 (EDT)")
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
Hi Stefan,
> @@ -771,7 +773,20 @@ Make the shell buffer the current buffer, and return it.
> (expand-file-name
> (read-directory-name
> "Default directory: " default-directory default-directory
> - t nil))))))))
> + t nil))))))
> + ;; On remote hosts, the local `shell-file-name' might be useless.
> + (when (and (file-remote-p default-directory)
> + (null explicit-shell-file-name)
> + (null (getenv "ESHELL")))
> + ;; `expand-file-name' shall not add the MS Windows volume letter
> + ;; (Bug#49229).
> + (replace-regexp-in-string
> + "^[[:alpha:]]:" ""
> + (file-local-name
> + (expand-file-name
> + (read-file-name "Remote shell path: " default-directory
> + shell-file-name t shell-file-name
> + #'file-remote-p)))))))
> (setq buffer (if (or buffer (not (derived-mode-p 'shell-mode))
> (comint-check-proc (current-buffer)))
> (get-buffer-create (or buffer "*shell*"))
> @@ -782,21 +797,8 @@ Make the shell buffer the current buffer, and return it.
> (pop-to-buffer buffer display-comint-buffer-action)
>
> (with-connection-local-variables
> - ;; On remote hosts, the local `shell-file-name' might be useless.
> - (when (and (file-remote-p default-directory)
> - (called-interactively-p 'any)
> - (null explicit-shell-file-name)
> - (null (getenv "ESHELL")))
> - ;; `expand-file-name' shall not add the MS Windows volume letter
> - ;; (Bug#49229).
> - (setq-local explicit-shell-file-name
> - (replace-regexp-in-string
> - "^[[:alpha:]]:" ""
> - (file-local-name
> - (expand-file-name
> - (read-file-name "Remote shell path: " default-directory
> - shell-file-name t shell-file-name
> - #'file-remote-p))))))
This misses the `with-connection-local-variables' wrapper in the
`interactive' form. Is this intended? It would be a serious regression.
Best regards, Michael.
next parent reply other threads:[~2022-05-28 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165365729037.13166.16983049289085077158@vcs2.savannah.gnu.org>
[not found] ` <20220527131450.B347BC01683@vcs2.savannah.gnu.org>
2022-05-28 9:19 ` Michael Albinus [this message]
2022-05-28 14:12 ` master f8b2a01a9e: * lisp/shell.el (shell): Query shell file name from `interactive` Stefan Monnier
2022-05-28 15:31 ` Stefan Monnier
2022-05-28 16:18 ` Michael Albinus
2022-05-28 17:58 ` Stefan Monnier
2022-05-29 17:13 ` Michael Albinus
2022-05-29 17:38 ` Stefan Monnier
2022-05-29 19:08 ` Michael Albinus
2022-05-29 20:46 ` Stefan Monnier
2022-05-28 13:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgj2vwtz.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.