From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Tue, 14 Jun 2022 23:39:34 +0530 Message-ID: <87zgif15i9.fsf@gmail.com> References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> <877d5j2keu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9980"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55977@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 20:10:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Azj-0002MU-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 20:10:27 +0200 Original-Received: from localhost ([::1]:42292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1Azi-0007Me-6D for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 14:10:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1AzK-0007LQ-A8 for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 14:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1AzK-0006G0-1W for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 14:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1AzJ-0004Cs-RB for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 14:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55977-submit@debbugs.gnu.org id=B55977.165523019116150 (code B ref 55977); Tue, 14 Jun 2022 18:10:01 +0000 Original-Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 18:09:51 +0000 Original-Received: from localhost ([127.0.0.1]:35711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Az7-0004CO-MS for submit@debbugs.gnu.org; Tue, 14 Jun 2022 14:09:51 -0400 Original-Received: from mail-pj1-f65.google.com ([209.85.216.65]:35500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Az2-0004C7-5M for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 14:09:48 -0400 Original-Received: by mail-pj1-f65.google.com with SMTP id v17-20020a17090a899100b001ead067eaf9so945644pjn.0 for <55977@debbugs.gnu.org>; Tue, 14 Jun 2022 11:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3pUDC4TgOh2+0hHTChmyNYvcZZ4xxS1qcNLAmaaEjm0=; b=eo1vMbq1eLKdA7rVutwdM0DG1ohDzXVKekbwkT5uBhgYE+4jqy6T5ByL2dA8lQZZhY l7JcQkIp5NzhUFmYVlEGOKlfL3g/vNA7imWfw9Gd+jqWvKZM8rRxhBhUcZHo1KQDJHk4 8ayrJpGpBBHhCheFHQ39HAtGBPMpmbwCblF8QoBPWQibu5A0wgF3rGCCE6oP1zNORrfT bfw8smOMHfWo8d0dbzVkO3ccbzqUjapvN+z/EcCwL3jwpuJWB4r1YtRmw7QdShyZ4etg IMZ/yizTC8YSqeWPMTPtd6+91rDirP3baYscz9dmSN38ztC9NlTrVo7OvWw4pYMu/Y6L nHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3pUDC4TgOh2+0hHTChmyNYvcZZ4xxS1qcNLAmaaEjm0=; b=auNRjNlN1qaXGUdOwu1GFYCr401WIt+C/Ynk05aB8A8MDf4XxSoHHOP4QkmrKXjNMW fZZHTi42ESiQzgSL02hBZ1Z0F4QAkdNSa1sFlnVCLxL8H+8CbsnRp4rjAiF3zRtrTJsX FpgFpVbb0312EwF8XgwdvuNHU4kvISva4LPPVxSbXpwCTSi/SesaBvxZb9bJUQPZneA8 PILm9FwogiYNbOC1blljuFrtTkIJ3aDFKPOQK+UkqfU7KZUMBW5glHBl/55oXV+dywLZ EF0w0sPMUGHM7CqpHOzostOLBHtsF2pEqJZqWvHaDBlXdrJP7xq8aGrmWJgDR4UAdBhA yoOg== X-Gm-Message-State: AJIora8Ez+s9SrvhcqybLS9SgmwpF0e8pbDEeHnSopWqdCYtJDq5BFbr XgGmdKHom0N9K2sCuJgk+RVYuYDhmQ2PTw== X-Google-Smtp-Source: AGRyM1vRRvVO9yyWpr+j//+seUd/eEylLWK29Svk5Q3GxL9YYID5qTGqng6ZLSiY8F5eyU7rMbxpow== X-Received: by 2002:a17:90a:c7d7:b0:1e8:3d2d:dd67 with SMTP id gf23-20020a17090ac7d700b001e83d2ddd67mr5827993pjb.89.1655230178122; Tue, 14 Jun 2022 11:09:38 -0700 (PDT) Original-Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id r9-20020a170902ea4900b0015e8da1fb07sm7587811plg.127.2022.06.14.11.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 11:09:37 -0700 (PDT) In-Reply-To: <877d5j2keu.fsf@gmail.com> (Visuwesh's message of "Tue, 14 Jun 2022 23:32:17 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234527 Archived-At: [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 14, 2022 23:32] Visuwesh wrote: > [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D= =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 14, 2022 20:40] Eli Zaretskii wrote: > >>> From: Visuwesh >>> Date: Tue, 14 Jun 2022 22:57:48 +0530 >>>=20 >>> repeat-mode echoes unset keys in the help message since it doesn't check >>> for non-nil value of command bound to key; will attach patch once I get >>> the bug number. >> >> Thanks, but can you please show a recipe from "emacs -Q", to >> understand better what problem are you trying to fix? > > Sure. > > 1. M-x repeat-mode RET. > 2. C-h n. > 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). > 4. C-c @ C-n. Notice how the help message still says C-n despite > being unbound, and when you type C-n the repeat map exits > contrary to what the message says. Oh, looks like if I give `define-key' a non-nil REMOVE argument, then C-n is no longer displayed in the help message.