all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55977@debbugs.gnu.org
Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message
Date: Tue, 14 Jun 2022 23:39:34 +0530	[thread overview]
Message-ID: <87zgif15i9.fsf@gmail.com> (raw)
In-Reply-To: <877d5j2keu.fsf@gmail.com> (Visuwesh's message of "Tue, 14 Jun 2022 23:32:17 +0530")

[செவ்வாய் ஜூன் 14, 2022 23:32] Visuwesh wrote:

> [செவ்வாய் ஜூன் 14, 2022 20:40] Eli Zaretskii wrote:
>
>>> From: Visuwesh <visuweshm@gmail.com>
>>> Date: Tue, 14 Jun 2022 22:57:48 +0530
>>> 
>>> repeat-mode echoes unset keys in the help message since it doesn't check
>>> for non-nil value of command bound to key; will attach patch once I get
>>> the bug number.
>>
>> Thanks, but can you please show a recipe from "emacs -Q", to
>> understand better what problem are you trying to fix?
>
> Sure.
>
>     1. M-x repeat-mode RET.
>     2. C-h n.
>     3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil).
>     4. C-c @ C-n.  Notice how the help message still says C-n despite
>        being unbound, and when you type C-n the repeat map exits
>        contrary to what the message says.

Oh, looks like if I give `define-key' a non-nil REMOVE argument, then
C-n is no longer displayed in the help message.





  reply	other threads:[~2022-06-14 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 17:27 bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Visuwesh
2022-06-14 17:30 ` Visuwesh
2022-06-14 17:40 ` Eli Zaretskii
2022-06-14 18:02   ` Visuwesh
2022-06-14 18:09     ` Visuwesh [this message]
2022-06-15  7:25       ` Juri Linkov
2022-06-15  7:36         ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgif15i9.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=55977@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.