all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Matt Huszagh <huszaghmatt@gmail.com>
Cc: Emacs-Orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Remove additional newline at end of results block
Date: Sat, 02 Jul 2022 11:41:33 +0800	[thread overview]
Message-ID: <87zghsi3ki.fsf@localhost> (raw)
In-Reply-To: <CA+X8ke4K0N5fS8Ukr+4kX0aPOv+63eoU3naARMY8DfYTTez_TA@mail.gmail.com>

Matt Huszagh <huszaghmatt@gmail.com> writes:

> +  ;; We deliberately do not insert a newline here since there are
> +  ;; valid cases in which a user does not want a blank line between a
> +  ;; results block and the subsequent text.
>    (beginning-of-line 0)
>    (when hash (org-babel-hide-hash)))

Thanks for the patch! And sorry for the late reply.

Your explanation is quite confusing, but I think I managed to understand
what you referred to:

------
 We can write the simplest equation as
 #+begin_src latex :exports results
 \begin{equation}
   1 + 1 = 2,
 \end{equation}
 #+end_src
the paragraph should continue here.
--------

will be exported as

------
We can write the simplest equation as
\begin{equation}
  1 + 1 = 2,
\end{equation}

the paragraph should continue here.
------

Note the extra empty line below equation environment.

However, I am not confident if the proposed change is going to be safe
for other uses of src blocks.

I'd like to request other people who use export and source blocks
extensively to try the patch and see if it breaks anything.

Meanwhile, could you please reword the commit message and make it more
concise and clear?

Best,
Ihor


  reply	other threads:[~2022-07-02  3:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 15:25 [PATCH] Remove additional newline at end of results block Matt Huszagh
2022-07-02  3:41 ` Ihor Radchenko [this message]
2022-07-08 23:50   ` Matt Huszagh
2022-07-09  7:28   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zghsi3ki.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=huszaghmatt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.