bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

[Sean Whitton]

Hello,

You need a notmuch setup to reproduce this, though maybe other
gnus-search backends would show it too.  Create two nnselect groups
where the query for the second includes some of the messages in the
first group.  This is what I am using:

    first group, nnselect:Weekday, has query
      "to:spwhitton@spwhitton.name or to:spwhitton@arizona.edu"

    second group, nnselect:Weekend, has query
      "to:spwhitton@spwhitton.name".

So, messages addressed to spwhitton@spwhitton.name appear in both.
Ensure there are unread messages addressed to spwhitton@spwhitton.name.
Enter the first group, mark one of those messages addressed to
spwhitton@spwhitton.name as read.  Go to the last message, use 'n n' to
move to the next unread group.

The message that was marked as read reappears, unread, in the second
group.  If you quit to the group buffer and reenter the first group,
it's unread again there.

By contrast, if you mark the message as read in the first group and then
type C-x C-s, and only then do 'n n' on the last message, the marks are
properly saved and the message does not appear unread in the second
group.

I have nnselect-rescan t for the groups, in case that is relevant.

-- 
Sean Whitton

bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

[Sean Whitton]

Hello,

On Fri 15 Jul 2022 at 11:43PM -07, Sean Whitton wrote:

>
> By contrast, if you mark the message as read in the first group and then
> type C-x C-s, and only then do 'n n' on the last message, the marks are
> properly saved and the message does not appear unread in the second
> group.

Looks like this is due to this hack in my init.el:

    (defun spw/gnus-request-group-scan (group _info)
      (when (eq 'nnselect (car (gnus-find-method-for-group group)))
        (gnus-activate-group "nnmaildir+fmail:inbox" 'scan)))
    (advice-add 'gnus-request-group-scan :before #'spw/gnus-request-group-scan)

If I drop that then C-x C-s doesn't help.

-- 
Sean Whitton

bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

[Sean Whitton]

Hello,

On Fri 15 Jul 2022 at 11:43PM -07, Sean Whitton wrote:

> You need a notmuch setup to reproduce this, though maybe other
> gnus-search backends would show it too.  Create two nnselect groups
> where the query for the second includes some of the messages in the
> first group.  This is what I am using:
>
>     first group, nnselect:Weekday, has query
>       "to:spwhitton@spwhitton.name or to:spwhitton@arizona.edu"
>
>     second group, nnselect:Weekend, has query
>       "to:spwhitton@spwhitton.name".
>
> So, messages addressed to spwhitton@spwhitton.name appear in both.
> Ensure there are unread messages addressed to spwhitton@spwhitton.name.
> Enter the first group, mark one of those messages addressed to
> spwhitton@spwhitton.name as read.  Go to the last message, use 'n n' to
> move to the next unread group.
>
> The message that was marked as read reappears, unread, in the second
> group.  If you quit to the group buffer and reenter the first group,
> it's unread again there.

Here's a workaround:

    (defun spw/gnus-summary-exit (&rest _ignore)
      (call-process "notmuch" nil nil nil "new" "--no-hooks")
      (with-current-buffer gnus-group-buffer
        (gnus-group-get-new-news t)))
    (advice-add 'gnus-summary-exit :after #'spw/gnus-summary-exit)

-- 
Sean Whitton

bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

[Sean Whitton]

Hello,

On Sat 16 Jul 2022 at 07:42AM -07, Sean Whitton wrote:

> Here's a workaround:
>
>     (defun spw/gnus-summary-exit (&rest _ignore)
>       (call-process "notmuch" nil nil nil "new" "--no-hooks")
>       (with-current-buffer gnus-group-buffer
>         (gnus-group-get-new-news t)))
>     (advice-add 'gnus-summary-exit :after #'spw/gnus-summary-exit)

An alternative workaround is just to turn on Gnus duplicate suppression.

-- 
Sean Whitton

bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

[Sean Whitton]

Hello,

On Mon 18 Jul 2022 at 01:52PM -07, Sean Whitton wrote:

> Hello,
>
> On Sat 16 Jul 2022 at 07:42AM -07, Sean Whitton wrote:
>
>> Here's a workaround:
>>
>>     (defun spw/gnus-summary-exit (&rest _ignore)
>>       (call-process "notmuch" nil nil nil "new" "--no-hooks")
>>       (with-current-buffer gnus-group-buffer
>>         (gnus-group-get-new-news t)))
>>     (advice-add 'gnus-summary-exit :after #'spw/gnus-summary-exit)
>
> An alternative workaround is just to turn on Gnus duplicate suppression.

A faster workaround than my first, but which doesn't rely on duplicate
suppression:

    (defun spw/gnus-summary-read-group (group &rest _ignore)
      (when (string-prefix-p "nnselect:" group)
        (with-current-buffer gnus-group-buffer
          (save-excursion
            (gnus-group-goto-group group)
            (gnus-group-get-new-news-this-group 1)))))
    (advice-add 'gnus-summary-read-group :before #'spw/gnus-summary-read-group)

-- 
Sean Whitton

bug#56592: 29.0.50; Moving between nnselect groups sometimes fails to save marks

[Sean Whitton]

Hello,

On Fri 15 Jul 2022 at 11:43PM -07, Sean Whitton wrote:

> You need a notmuch setup to reproduce this, though maybe other
> gnus-search backends would show it too.  Create two nnselect groups
> where the query for the second includes some of the messages in the
> first group.  This is what I am using:
>
>     first group, nnselect:Weekday, has query
>       "to:spwhitton@spwhitton.name or to:spwhitton@arizona.edu"
>
>     second group, nnselect:Weekend, has query
>       "to:spwhitton@spwhitton.name".
>
> So, messages addressed to spwhitton@spwhitton.name appear in both.
> Ensure there are unread messages addressed to spwhitton@spwhitton.name.
> Enter the first group, mark one of those messages addressed to
> spwhitton@spwhitton.name as read.  Go to the last message, use 'n n' to
> move to the next unread group.
>
> The message that was marked as read reappears, unread, in the second
> group.  If you quit to the group buffer and reenter the first group,
> it's unread again there.

I have been discussing this with Andrew Cohen and believe, at least for
now, that it's not a bug: the user is required to set the
nnselect-regenerate group parameter non-nil in this sort of case.

-- 
Sean Whitton