From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Tue, 04 Oct 2022 16:06:28 +0200 Message-ID: <87zgeb65uj.fsf@gnus.org> References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> <877dts8cke.fsf@gnus.org> <87y1tvwv9g.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Third , 36403@debbugs.gnu.org, Pip Cet To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 04 16:49:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofjEx-0007bX-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 16:49:47 +0200 Original-Received: from localhost ([::1]:48814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofjEw-0006PZ-6j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Oct 2022 10:49:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofiZa-0003oT-Kt for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 10:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofiZa-0003il-C5 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 10:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofiZa-0007zD-3a for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2022 10:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2022 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.166489240130672 (code B ref 36403); Tue, 04 Oct 2022 14:07:02 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 4 Oct 2022 14:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:54876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiZF-0007yd-Dq for submit@debbugs.gnu.org; Tue, 04 Oct 2022 10:06:41 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofiZC-0007yP-UM for 36403@debbugs.gnu.org; Tue, 04 Oct 2022 10:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wr7uMuKmoeP1nwJhDvDM9sfNlRxJkUSzsKlnFhJZXbo=; b=Wykx4AF5rrc0eDDWX21un2kBsl pTIm5YXc4TBSuoftjtTncmWoufmApnwj39abXwEUpOx6TbReeXAOOp9WhteLiLNHxZ8P2NhzoIVrJ wYbwOk75yOl3z5byiYIgjHClvC9qe7oJeyMi1iaYY3vi7+a5V2oUS3j+HWKSoRDe2Qfs=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofiZ3-0004TQ-3r; Tue, 04 Oct 2022 16:06:31 +0200 In-Reply-To: <87y1tvwv9g.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 04 Oct 2022 16:52:59 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWdkXFgYltBNSxv gX6urpL////1g5C3AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YKBA0qBkfLJ4cAAAGISURBVDjLdZPh kYQgDIXhoAACV4BQAcgWwI70X9O9BHTVc/PDGfKRl5BEpa5GbAn2zT+B/sEZXv8AioB4A1eprzn8 HdBufgJTqLIRhVpD7/09gaYTeF1AGCCAnYEJNbzs9h9o3M6qllCRrB/AKgOgACBW6QDNtgFMgFLN B+i9aZIIgCJFTdAkh6r8naBMYPrGUgBBlDYBrXcGmkYm+BE4cwCQDiajQlwrs1eWQXf8nmb10nUa fUcwcvRsM3RKWt4+0ZAaYHPZKEgsKUUKEmG5qt7IKi8DinGXQqEvPNLhxI7Ic/8AYxw2QULSBSDx mhh4BuUETGBpdt9BphX3JcsH1K6ckWP6Byx6PHLz/sR9tI03hR3k0Ftp1ogA4KctRL8dW/aRyuot b9ZRnkGobYKApoY17T1B3SNHFv4BR47sXMh63TuyV6UwCl6vZ6BOYP8NMDxXz0C6i2kTRyD/FcBB bvxRZW+JSHEnNJ1stlIRPXjvwMdH4GnsyQRjAHL5JCQgzZFeTaUv9gchl3huqTRFngAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMi0xMC0wNFQxMzo0MjowNiswMDowMGSjw44AAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjItMTAtMDRUMTM6NDI6MDYrMDA6MDAV/nsyAAAAAElFTkSuQmCC X-Now-Playing: Latin Quarter's _Modern Times_: "Truth About John" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244438 Archived-At: "Basil L. Contovounesios" writes: > Which means image-test-circular-specs signals: > > (circular-list (:dummy . #0)) > > So how important is it to support image specs with circular property > values? Should the test be marked :expected-result :failed? Hm... don't know. > - (setcdr circ1 circ1) > - (setcdr circ2 circ2) > - (and (equal (image-size spec1 t) (cons 1 1)) > - (equal (image-size spec2 t) (cons 1 1)))))) > + (setcdr circ1 circ1) > + (setcdr circ2 circ2) > + (should (equal (image-size spec1 t) '(1 . 1))) > + (should (equal (image-size spec2 t) '(1 . 1))))) (cons 1 1) is not eq to (cons 1 1), but '(1 . 1) may or may not be eq to '(1 . 1) (depending on whether compiled or phase of the moon), which may be why that code is written that way? But in this case, I can't see how it would make a difference...