From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Sun, 09 Oct 2022 12:15:39 +0000 Message-ID: <87zge52nx0.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> <867d1cjc8w.fsf@mail.linkov.net> <87o7unkggk.fsf@posteo.net> <86edvids93.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , 57400@debbugs.gnu.org, Antoine Kalmbach To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 09 14:16:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohVEV-0007OT-19 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 14:16:39 +0200 Original-Received: from localhost ([::1]:41844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohVET-0003a0-Hu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 08:16:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohVDy-0003YO-3x for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 08:16:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohVDu-0002y4-KG for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 08:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohVDu-0002q5-En for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 08:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Oct 2022 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166531775210889 (code B ref 57400); Sun, 09 Oct 2022 12:16:02 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 9 Oct 2022 12:15:52 +0000 Original-Received: from localhost ([127.0.0.1]:42296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohVDk-0002pZ-EM for submit@debbugs.gnu.org; Sun, 09 Oct 2022 08:15:52 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:35683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohVDh-0002pK-Lf for 57400@debbugs.gnu.org; Sun, 09 Oct 2022 08:15:51 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 782FA240106 for <57400@debbugs.gnu.org>; Sun, 9 Oct 2022 14:15:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665317743; bh=a27cT/PSlhLkqM5qbpMPhFDhWBXWs4lsFl2sDNC/bEo=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=PE57WZFiXZwMpSRFKl5axpRkuozkS1o3rF67miMLWP6n2C27ss5gEdrjEWJ4o1Kz1 +JUvStKB9EdHHDe7LxJrar3oMvPJWzh7Z4LO2sMSj2k7FBVueEeIn4huQpUrHctevV eyIUrcqBPK/5WGjOC6brFe04lDERg9W9Zz++yFwjQEmE+5PYwzCy5yW0NSj09iP65A 0Fk40JUXjnFgOoBG/u2UZlAbZCB6tPaSrsyubrvL+mKDrumNJ7in9eqihC3zG/Zalm f7rR1vNrn+wWu0ZBrdByObBVBMHxLb/B6pkgF8KTUhRwu87DZKHQzRL8U2lNRfOUZG pKplJ6gxg6rGw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mlgx80VLjz6tmJ; Sun, 9 Oct 2022 14:15:39 +0200 (CEST) In-Reply-To: <86edvids93.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 08 Oct 2022 22:34:16 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244953 Archived-At: Juri Linkov writes: >>> Also please note that the most convenient way to select revisions >>> to submit is to show the log buffer, and use 'm' to mark revisions >>> (log-view-toggle-mark-entry). Then 'log-view-get-marked' returns >>> all marked revisions. >> >> This is supported, > > Thanks. Since it's the most convenient UI, shouldn't this be > documented in the Info? IOW, what about copying this from the docstring > to the manual: > > When invoked interactively in a Log View buffer with marked > revisions, these revisions will be used. I can add that. > Also the use of "," to separate revisions needs to be documented > in the docstrings and the manual. Maybe also mention the separator > in the prompt that reads multiple revisions. Actually it is whatever was specified by `crm-separator', right? But yes, that can be mentioned too. >> but currently not in this order. Do you think an option should be >> added that would use recursive editing to prompt the user? > > I see that currently the chronological order of revisions is used from > the log. This looks like the right order. Prompting with the default > value that is set to these revisions from the log would be also nice > to do, so users will be able to change the order manually by moving > revisions between ",". Again, regarding `crm-separator' I don't know if this is a value that people change or not (perhaps it should be changed to a defconst). But setting that aside, that sounds like a good idea. I can also imagine that the initial input outside of a log buffer ought to just be the last commit. > Additional question: shouldn't the behavior of > vc-prepare-patches-separately=nil be equivalent to > vc-prepare-patches-separately=t when only one revision is given? Both > cases create just one mail. So when vc-prepare-patches-separately is > nil, could it extract the subject from the single revision? Or maybe > vc-prepare-patches-separately should support a new customization value > for this? Yes, but the formatting is different. In the one case you attach a patch to a regular message, while in the other case the message is prepared in such a way that (at least when using Git) the entire message is a valid patch, where we can use "git am".