From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58960: 29.0.50; Assert fails when browsing an URL, bug#58960: 29.0.50; Assert fails when browsing an URL Date: Wed, 02 Nov 2022 14:58:23 +0100 Message-ID: <87zgd9mpa8.fsf@gmail.com> References: <87k04dodxs.fsf@gmail.com> <83wn8da4eo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 58960@debbugs.gnu.org, Paul Eggert , tino.calancha@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 15:17:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqEYH-0002MS-Od for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 15:17:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqEGt-000366-Rf; Wed, 02 Nov 2022 09:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqEGk-00035n-Eu for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 09:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqEGk-0006oz-1k for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 09:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqEGj-0005cx-Om for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 09:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58960 X-GNU-PR-Package: emacs Original-Received: via spool by 58960-submit@debbugs.gnu.org id=B58960.166739751321595 (code B ref 58960); Wed, 02 Nov 2022 13:59:01 +0000 Original-Received: (at 58960) by debbugs.gnu.org; 2 Nov 2022 13:58:33 +0000 Original-Received: from localhost ([127.0.0.1]:46872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqEGH-0005cF-Bf for submit@debbugs.gnu.org; Wed, 02 Nov 2022 09:58:33 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:46892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqEGF-0005c0-8y for 58960@debbugs.gnu.org; Wed, 02 Nov 2022 09:58:32 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id bk15so24635999wrb.13 for <58960@debbugs.gnu.org>; Wed, 02 Nov 2022 06:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=sy2n0FyAqKFBb6GzH2zTczZstVyi6b7LoWVUB7EfO0Y=; b=XBpudqh3ay78VglyPlNMgVq3LHnn9XZphNqLiW+uJdMeKZgcfb8zk4/oai5EhsUybR f46I71bBKqaSUIm/GMT5c58I9as2RxhuoiKmBI45Y3VLAdRFEJV3clCiteakfobVWfKh FNVqkcTZHC7Dqb3V0Q2Swu6a4VTxiSW2dUJdNAPhsg+Qy21g0LKR9QkDGl8JecAM1Dbi uySONBZhm63TiYNVjXgAMxTGEXMFVXKxjkGT1wrEL1dLJXTlATAAlEFLH6mogYAP4zkY Df+eOiO3v7zIV67LBBDOBXHlu9Sgzhrt2mlrqj5c5iEkAQtxtp/dUmTHo9W+qkw7+9uO g7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sy2n0FyAqKFBb6GzH2zTczZstVyi6b7LoWVUB7EfO0Y=; b=h+SEl9sS/mCrofriS2J/B/1mh52xystD/x60dB2RfEbJn8q3drvsw0UDEctgCXc81q 5r7zNWOhm95zkdQ+E7C2hLEjHM5qo8BFH/R+xfV1iTNe1zGj4XAot7Qjqw0LXUxsMUFj VMElVzjEGWdkZt8idyH1PUi37H+klA2C79+1Evz0pFt+5brHe8zUdNzNGfb16kMMWTDe DvCIiCSMvy/lHhMQ8OflASyCbrok7L7doXscDiJu2GkUW/bC4OHQi2I89KzLgjos10lE uLQXElS29gKikTZ90G0PQ+hwGJDXnPsBGdvxrvBCSC39zm63c3R/6YUXMybz0GcSaQEv KVsg== X-Gm-Message-State: ACrzQf0+YtgRgqipy7T9SSZi0R4VklS1vvGWunkW6nQWvfvAo8ldxd55 Au+lWEw+aHksruHuq2vMaiVXzorvPHA= X-Google-Smtp-Source: AMsMyM7eTDikCgNrMEiVdjXXkAV0mPrB+LVTs2Js2+ObZ5ZxtGoyOzHowcCjpALvuT40K7tfNKVoxQ== X-Received: by 2002:a05:6000:819:b0:236:8e16:e187 with SMTP id bt25-20020a056000081900b002368e16e187mr15504650wrb.157.1667397504952; Wed, 02 Nov 2022 06:58:24 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id c6-20020a056000104600b0022e344a63c7sm13079285wrx.92.2022.11.02.06.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 06:58:24 -0700 (PDT) In-Reply-To: <83wn8da4eo.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Nov 2022 15:10:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246870 Archived-At: >>>>> On Wed, 02 Nov 2022 15:10:07 +0200, Eli Zaretskii said: >> Cc: Gerd M=C3=B6llmann , >> 58960@debbugs.gnu.org >> From: Robert Pluim >> Date: Wed, 02 Nov 2022 11:20:31 +0100 >>=20 >> Looks like `call-process' needs to ensure the child signal fd=CA=BCs= are >> set up before calling `emacs_spawn'. Eli> Why do we need this? IOW, do you understand how did SIGCHLD cause Eli> this? `browse-url' does `call-process' for `xdg-open' by default. `xdg-open' exits almost immediately, we get SIGCHLD: (gdb) bt #0 terminate_due_to_signal (sig=3D6, backtrace_limit=3D2147483647) at emac= s.c:421 #1 0x00005555555b489e in die (msg=3Dmsg@entry=3D0x5555558d938f "0 <=3D fd", file=3Dfile@entry=3D0x55= 55558d9354 "process.c", line=3Dline@entry=3D7386) at alloc.c:7692 #2 0x00005555555bfec9 in child_signal_notify () at process.c:7386 #3 handle_child_signal (sig=3D) at process.c:7493 #4 0x000055555574e992 in deliver_process_signal (sig=3D17, handler=3D0x555555831b40 ) at sysdep.c:= 1741 #5 0x00007ffff5752140 in () `child_signal_notify' does this: int fd =3D child_signal_write_fd; eassert (0 <=3D fd); and if `child_signal_init' hasn=CA=BCt been called, then this is still true: /* The write end thereof. The SIGCHLD handler writes to this file descriptor to notify `wait_reading_process_output' of process status changes. */ static int child_signal_write_fd =3D -1; so the assert fails. Why can=CA=BCt we just call `child_signal_init' from `init_process_emacs' instead of `create_process'? Robert --=20