From: Robert Pluim <rpluim@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 58909@debbugs.gnu.org
Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save
Date: Wed, 09 Nov 2022 11:06:08 +0100 [thread overview]
Message-ID: <87zgd0fnn3.fsf@gmail.com> (raw)
In-Reply-To: <e5f20365-ed8e-c56e-a09b-ac6e2bc3bbc7@gmail.com> (Jim Porter's message of "Tue, 8 Nov 2022 08:52:10 -0800")
>>>>> On Tue, 8 Nov 2022 08:52:10 -0800, Jim Porter <jporterbugs@gmail.com> said:
Jim> On 11/8/2022 7:29 AM, Robert Pluim wrote:
>> OK. I donʼt see what benefit the *use* of the minor mode in this way
>> brings :-)
Jim> The actual change that I'd like to merge is just to make the minor
Jim> mode activate/deactivate consistently, whereas previously it would
Jim> activate in some situations where you start the Emacs server, but not
Jim> others. I'd classify that as "not working".
That sounds good
Jim> Having the minor mode makes it easier for third-party code (user
Jim> configs or packages) to define key bindings that are only active when
Jim> the server is running. That's useful to me, since I don't *always* use
Jim> the Emacs server.
as does this
Jim> As for the change to how 'C-x C-c' is bound, I don't have any strong
Jim> opinion on merging it. It's probably more risk than it's worth, and if
Jim> we were to merge it, I'd prefer to do so after cutting the 29 branch,
Jim> since then there'd be more time to find any bugs.[1] However, since
Jim> the only real benefit is to clean up some dependencies in the code,
Jim> I'm not sure it's worth the effort.
I think it would be too risky a change.
Robert
--
next prev parent reply other threads:[~2022-11-09 10:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 22:29 bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Jim Porter
2022-10-31 12:44 ` Eli Zaretskii
2022-10-31 17:36 ` Jim Porter
2022-10-31 18:25 ` Eli Zaretskii
2022-10-31 19:38 ` Jim Porter
2022-10-31 19:52 ` Eli Zaretskii
2022-10-31 20:28 ` Jim Porter
2022-11-01 6:17 ` Eli Zaretskii
2022-10-31 19:28 ` Jim Porter
2022-10-31 19:43 ` Eli Zaretskii
2022-10-31 20:01 ` Jim Porter
2022-10-31 20:21 ` Eli Zaretskii
2022-10-31 21:06 ` Jim Porter
2022-11-01 6:39 ` Eli Zaretskii
2022-11-01 16:11 ` Jim Porter
2022-11-01 22:39 ` Jim Porter
2022-11-02 12:16 ` Eli Zaretskii
2022-11-02 16:36 ` Jim Porter
2022-11-02 17:11 ` Eli Zaretskii
2022-11-02 18:17 ` Jim Porter
2022-11-02 18:42 ` Eli Zaretskii
2022-11-02 19:16 ` Jim Porter
2022-11-02 19:23 ` Eli Zaretskii
2022-11-02 19:57 ` Jim Porter
2022-11-02 20:09 ` Eli Zaretskii
2022-11-02 22:09 ` bug#58909: 29.0.50; [PATCH] " Jim Porter
2022-11-03 6:25 ` Eli Zaretskii
2022-11-06 20:23 ` Jim Porter
2022-11-08 14:47 ` Eli Zaretskii
2022-11-08 15:08 ` Robert Pluim
2022-11-08 15:13 ` Eli Zaretskii
2022-11-08 15:29 ` Robert Pluim
2022-11-08 16:52 ` Jim Porter
2022-11-09 10:06 ` Robert Pluim [this message]
2022-11-17 5:17 ` Jim Porter
2023-09-07 21:03 ` bug#58909: 29.0.50; [WIP PATCH] " Stefan Kangas
2023-09-08 1:21 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgd0fnn3.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=58909@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.