From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#59149: Feature Request: Report progress of long requests in Eglot Date: Thu, 10 Nov 2022 15:50:29 +0000 Message-ID: <87zgcy95bu.fsf@gmail.com> References: <87educqkar.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8560"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59149@debbugs.gnu.org To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 16:50:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot9pS-00022s-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 16:50:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot9ob-00062i-2P; Thu, 10 Nov 2022 10:50:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot9oZ-00062Q-B5 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 10:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot9oZ-0007DF-1Y for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 10:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ot9oY-00007T-HT for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 10:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1668095362395 (code B ref -1); Thu, 10 Nov 2022 15:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Nov 2022 15:49:22 +0000 Original-Received: from localhost ([127.0.0.1]:44033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot9nu-00006J-4j for submit@debbugs.gnu.org; Thu, 10 Nov 2022 10:49:22 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot9nq-000069-Ot for submit@debbugs.gnu.org; Thu, 10 Nov 2022 10:49:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot9nq-0005zD-Gz for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 10:49:18 -0500 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot9no-0006WZ-1g for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 10:49:18 -0500 Original-Received: by mail-wm1-x334.google.com with SMTP id t4so1390096wmj.5 for ; Thu, 10 Nov 2022 07:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TpSnxzScyKkmKE4pfMsBO8kIqBjJxPoivKM+Uqc+oHI=; b=PHRRnfoBH08IEnouROcvSUINVTaPNAlJp0TillqvPjFmgm89d960omp3PM9jo6t1A1 orNG1hF5V1ITI5pO/FN2T2f14NghJS1rEFvSO3gKHWqQ/qp85LF3yPSdR+5V0usSEBVy zD5ot5jpHdRbwvoDlH8EspvSOJlHwdq15xSzxLb9r7QtDebYsTEmWzB3EtksFH238fFB +Wf5UhHoywCqL12qoKQStAqA2FJaO9o3btnBOBhEkd4FGEc5sXwAUgGmA+zL/RYBf1Kc dRBELLf9LB+YXBIB8pVfsCzK8s9q7QF9FLRcQD3+MO5ELHQv2qVy5mbfxiFgjvgwX5Ye 9H3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TpSnxzScyKkmKE4pfMsBO8kIqBjJxPoivKM+Uqc+oHI=; b=U+P+0NnLGhCFopiHi7XUZvRy03oirDli4rGSaTytPpiNr640mR9HDxo/2LkcqXTwtQ SnKxADaBO/8afafAoHTqspeEwBNzBd4DY4pT3qf+fF4pAQ7ZBEBV4FfocjU/JZpSl0ta C0g58K451C6zgUSOKWLldFbCUEHnzgnQhDsF3gYmxSDPkifvpNDb3lQcqz0BAzPNDQN3 6CYePdeatttmF89qt/9ndmrVZZ5NFwUqkFJ+zdCSgODw5R8tsJaLoSndwP2qKuQ6NYIY Za4li7cQTxcu7J8zVjRgizPodkMA6Z3pI/lB0QRVIvvyZg35GAoXdDIu3VpXG3EXEfS5 jUhw== X-Gm-Message-State: ACrzQf3Xnk+lrMXvoLt2jp+g0KUZ/sY2FwJaOkA/zjepAgnpCL3quJPv Xq/b9//Dm980snqDnw13JxESkwtPwzg= X-Google-Smtp-Source: AMsMyM647++ckrW3DMOyr1lIhHevjmu55Wwd0bjh+3gMPcWkfgt1WdjooYzn/CuLAClKo4lB37OGPQ== X-Received: by 2002:a05:600c:538b:b0:3c6:b66d:4027 with SMTP id hg11-20020a05600c538b00b003c6b66d4027mr51945215wmb.146.1668095354166; Thu, 10 Nov 2022 07:49:14 -0800 (PST) Original-Received: from krug ([87.196.81.1]) by smtp.gmail.com with ESMTPSA id m189-20020a1c26c6000000b003c6edc05159sm5282747wmm.1.2022.11.10.07.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 07:49:13 -0800 (PST) In-Reply-To: <87educqkar.fsf@dfreeman.email> (Danny Freeman's message of "Wed, 09 Nov 2022 09:13:29 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247523 Archived-At: Danny Freeman writes: > Something I think would be nice to have in eglot is some kind of > progress indicator for long running requests. Attached is my attempt at > implementing these. The patch contains links to relevant LSP specs in > the commit message. > > Here is a link to an old github discussion about progress notifications: > https://github.com/joaotavora/eglot/discussions/835=20 > > It uses the built in progress-reporter to display progress in the > echo area. Something that may be missing is a way for the user to > enable/disable this. Not sure what the right facilities are for that. > The eglot-stay-out-of pattern maybe? I didn't include that because I'm > not sure what to "stay out of". Maybe the symbol `progress-reporter'? > Happy to add something like that. Thanks Danny, this doesn't look bad at all, though I have yet to understand how it works. I can half-see why progress status should be a server property, but it would be better if you provided an automated test, or maybe just a step-by-step sequence diagram (which can be in plain text and language) that clarifies this. An animated gif that might also work. Anyway, the way the user opts out of LSP configuration is via the user variable eglot-ignored-server-capabilities. So there should be some point where you check the associated LSP capability of "progress reporting" with eglot--server-capable. Jo=C3=A3o