From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Fri, 18 Nov 2022 14:20:15 +0100 Message-ID: <87zgcov1ps.fsf@elite.giraud> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> <83o7t4bhk4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11107"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, 59351@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 14:21:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow1Iz-0002dI-2V for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 14:21:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow1Ir-0002a1-EH; Fri, 18 Nov 2022 08:21:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1Io-0002Zr-AM for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:21:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow1Ik-00084Z-Iy for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:21:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow1Ik-0003FA-Ct for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.166877762012394 (code B ref 59351); Fri, 18 Nov 2022 13:21:02 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 18 Nov 2022 13:20:20 +0000 Original-Received: from localhost ([127.0.0.1]:35759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1I4-0003Dp-68 for submit@debbugs.gnu.org; Fri, 18 Nov 2022 08:20:20 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:11253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1I1-0003Dh-SL for 59351@debbugs.gnu.org; Fri, 18 Nov 2022 08:20:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Iz28RUJClZ7wvQ6d aXoYpqY50FQ450aj3sl+7+k+Rxg=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=v6AZHlsrNP9hgzFFR8FV5K0vns5PWOwpAULzIX E/wC0jr6+Uz7DlaNj9f9SatmAcG80hnIJOakAi7C5vHV1tSfYJnaMP/jrrrvYlL8EMJBrp 2vR2m4S/LY2MDyBtguTRvKo4I5KvCvlSXcSKsYpcpbn6uKVp9Q7HA8HJj+cVdPeJkC8FK1 1MQoBq9H0yL4UsW6RNJiopEgpwPDCOx1IK2gPUuT8J7cwESu8fFf2kE+D0bwkBbo1a38+H xhrISFB5DqBR66dsVqlAS0ILh8ABCdiMtmlUpu4oLbqYUXsks5M4smBTiAHAvGwUf4Yif8 19k2Hv5WG8tKIUsAOBqP7tDw== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 0a01f019 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 18 Nov 2022 14:20:16 +0100 (CET) In-Reply-To: <83o7t4bhk4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Nov 2022 13:58:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248232 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Did you test the results on a TTY frame that has a mouse? It doesn't even compile --without-x. So here is a new version of this patch. I even remove the comment as suggested by Po. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-click-position-to-menu-bar-entry-with-no-toolkit.patch >From 225d6eb5cf17587619850ee2143e1e59a1c9fa4e Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 18 Nov 2022 09:24:55 +0100 Subject: [PATCH] Fix click position to menu bar entry with no-toolkit * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to compute correct menu bar position should the menu face change. * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore. * src/dispextern.h: Export x_y_to_hpos_vpos. --- src/dispextern.h | 3 ++- src/keyboard.c | 9 +++++++++ src/xdisp.c | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/dispextern.h b/src/dispextern.h index 2f5f4335fe..2afbdeabaa 100644 --- a/src/dispextern.h +++ b/src/dispextern.h @@ -3495,7 +3495,8 @@ #define TTY_CAP_STRIKE_THROUGH 0x20 extern void tty_draw_row_with_mouse_face (struct window *, struct glyph_row *, int, int, enum draw_glyphs_face); extern void display_tty_menu_item (const char *, int, int, int, int, bool); - +extern struct glyph *x_y_to_hpos_vpos (struct window *, int, int, int *, int *, + int *, int *, int *); /* Flags passed to try_window. */ #define TRY_WINDOW_CHECK_MARGINS (1 << 0) #define TRY_WINDOW_IGNORE_FONTS_CHANGE (1 << 1) diff --git a/src/keyboard.c b/src/keyboard.c index 069cf0627b..716ee973a2 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -5974,8 +5974,17 @@ make_lispy_event (struct input_event *event) in a menu (non-toolkit version). */ if (!toolkit_menubar_in_use (f)) { +#if defined HAVE_WINDOW_SYSTEM + int dummy; + + x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), + XFIXNUM (event->x), XFIXNUM (event->y), + &column, &row, + NULL, NULL, &dummy); +#else pixel_to_glyph_coords (f, XFIXNUM (event->x), XFIXNUM (event->y), &column, &row, NULL, 1); +#endif /* In the non-toolkit version, clicks on the menu bar are ordinary button events in the event buffer. diff --git a/src/xdisp.c b/src/xdisp.c index f6a279636a..0c073c0fb5 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -2330,7 +2330,7 @@ pixel_to_glyph_coords (struct frame *f, int pix_x, int pix_y, int *x, int *y, text, or we can't tell because W's current matrix is not up to date. */ -static struct glyph * +struct glyph * x_y_to_hpos_vpos (struct window *w, int x, int y, int *hpos, int *vpos, int *dx, int *dy, int *area) { -- 2.38.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=--