From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akib Azmain Turja Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] 11 new packages! Date: Sun, 27 Nov 2022 12:40:25 +0600 Message-ID: <87zgccoq7a.fsf@disroot.org> References: <87r0y6ug9z.fsf@disroot.org> <87y1sct2hp.fsf@posteo.net> <87k03vf5m8.fsf@disroot.org> <87edu2narn.fsf@posteo.net> <8735aieqtr.fsf@disroot.org> <87cz9mlq3o.fsf@posteo.net> <875yfdd5ad.fsf@disroot.org> <87wn7hh438.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26984"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Developer List To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 27 15:46:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozIv6-0006qG-1a for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Nov 2022 15:46:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozIuZ-0004OH-7B; Sun, 27 Nov 2022 09:45:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozIuW-0004O1-Ao for emacs-devel@gnu.org; Sun, 27 Nov 2022 09:45:36 -0500 Original-Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozIuU-0007LW-Cg for emacs-devel@gnu.org; Sun, 27 Nov 2022 09:45:36 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 400B14117E; Sun, 27 Nov 2022 15:45:31 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XUm0mxcuHnGA; Sun, 27 Nov 2022 15:45:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1669560329; bh=Lg0WdbtJ774g8XME1j9Pt87yB866xMqaeeT7FPiDcog=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lOroQW0fYmb3hPazl0L0G7LlSsSfawsX+5XnRJkZw799BAAbEOImZngcEjJl6qib1 /xTzvt1A/u2pmbQ1FzBH+a25EAiPDMQ5wmuLz6Hm4LOuFSNqpweP/jDnAU4q480e0Y SpbcCDiJ37TD1vzW9CjO/8dlpJBD5aw3gnx6sW2CY3z/dlShuHsmIo0m1gXLDylCVk lL3BRZDpkrGhdsAMyJ9Bk6GU2WqGqScKaqMl01AuP+KCMWJt6JjZY8TTUHX261L3RL 0wN4E+yZdAbDoNgwVFfMnF5DsbgF0MxOItPdKxZBlqYKF0pf86AZMgir6FjEgZZz/n K7+d44yT3o9kg== In-Reply-To: <87wn7hh438.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 26 Nov 2022 20:07:39 +0000") Received-SPF: pass client-ip=178.21.23.139; envelope-from=akib@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300632 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Philip Kaludercic writes: > Akib Azmain Turja writes: > >> Philip Kaludercic writes: >> >>>>> OK, then adding them to NonGNU ELPA seems like the safer bet. >>>>> >>>>> I'd like to add them, but I'll have to take the time to review them >>>>> first, which might take a bit. >>>> >>>> What do you want to review? The patches, or the packages? >>> >>> The packages, unless you aren't interested in comments. >> >> Review if you wish, I welcome feedback. > > One minor one more: > > diff --git a/minibar.el b/minibar.el > index 983b3ff58b..0eb6fd338d 100644 > --- a/minibar.el > +++ b/minibar.el > @@ -137,9 +137,7 @@ a string to display, or nil in case there is to show." > ;;;###autoload > (define-minor-mode minibar-mode > "Toggle Minibar display." > - :init-value nil > :lighter " Minibar" > - :keymap nil > :global t > (if minibar-mode > (progn Done. > @@ -450,6 +448,9 @@ when it was recorded.") > (lambda (i) > (let ((load (minibar--module-cpu-calculate-load > (format "cpu%i" i)))) > + ;; You should be able to simplify this with an > + ;; `alist-get' call and something like #'> as the > + ;; equality test. > (cond > ((and (char-displayable-p ?=E2=96=88) ; #x2588 > (>=3D load 87.5)) Done with seq-some. > > > The rest looks fine, so I'll push the commits to nongnu.git. > Thank you very much for your hard work reviewing all the packages. =2D-=20 Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5 Fediverse: akib@hostux.social Codeberg: akib emailselfdefense.fsf.org | "Nothing can be secure without encryption." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmODBloACgkQVTX89U2I YWvhpQ/4/lHT6NUTDa494nOIi84O6Oh6D4rPXW0agzniLNByB4CR26ezPta6qqGY KuA4jlZqvYCLwc/4b0KV6RQYCQx7XtjoXzcr8RoM/Eh4AzCS5iq4HwnQD+OFa+eE w/4lpCuU4JndwQlEXPQTGXXLSAebGdhvRzQU8ATww0J/h6Ge2etfs0yPPESMFK2D s7hc0HE7+gLS1MOStNl4s2oK3b1yQagBlqhXQS+veQ1wSVks55DzzzHSuvdA736q EIBtZdRdDDBGILMM56NWXTJ5R4PD9Vr1V8F54uGuTkio4WA52L9kaHRfyUPYqy+R Mfb2WnatmMnPXa4mhtFYk2O9t+VYRp63UXKXLREgkODISPnWkIJiaYkwkJYnq3/B sKUTYk/H3hgI6JUHHYWgjAV/F92YxnBWwtNsgO4GBxc1b9ijeUlVnW6IY5jV4oAD u1cT4EUcTTZfkIrwhf0pcsTz4RRoH64s3GLgpJ7RYFS9TfsUNTTwTa2CrKNGlgCf 7q1oNwSYgIIzgIwH0O7oWBUQYPx7JZ8eEhBftegAN1YxgurJWG3IBc+/Fg1FH6GO x/znQ3JcTw2ZSlaxv5uKUrAkw54B/a/VaOWB2C8ObAwEzsfOWP0l84WE6i72/SVq /ZNMSGmSVPG+F85sEg1o3NqWYKKaeRuNSrnVuby3P2Bv/RgrfQ== =wY00 -----END PGP SIGNATURE----- --=-=-=--