From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: Re: Emacs 30.0 warning from `cl-pushnew' and `memql' Date: Tue, 27 Dec 2022 12:39:15 +0100 Message-ID: <87zgb913fg.fsf@dataswamp.org> References: <878ritgaty.fsf@dataswamp.org> <87o7rprvia.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:FU3ggdlkI/FfGNvSfM/hQ3HWAag= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 28 02:24:13 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pALAy-0007Ss-M7 for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 28 Dec 2022 02:24:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pALAE-0005X7-PH; Tue, 27 Dec 2022 20:23:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pA8In-0005ZA-RS for help-gnu-emacs@gnu.org; Tue, 27 Dec 2022 06:39:29 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pA8Im-0003RC-Ak for help-gnu-emacs@gnu.org; Tue, 27 Dec 2022 06:39:25 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pA8Ik-0003U7-Sj for help-gnu-emacs@gnu.org; Tue, 27 Dec 2022 12:39:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 27 Dec 2022 20:23:25 -0500 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:141983 Archived-At: Michael Heerdegen wrote: >> After the last powerup I see this, it refers to a use of >> `cl-pushnew'. >> >> Warning: `memql' called with literal string that may never match >> (arg 1) > > Yes, these new warnings hint at problematic calls. In case of > cl-pushnew you want to specify a :test function to avoid comparing > strings with an inappropriate test function like the > default memql. This does not render the warning (cl-pushnew "/usr/share/emacs/site-lisp/elpa-src/slime-2.26.1" load-path :test #'string=) but this is not a model I can endorse, this is why you have that level of abstraction to begin with, i.e., not to be bothered all the time with implementation details. Might as well to provide :loop #'cl-dolist how to iterate the list as well ... And after that ... is there anything else to specify before we can get rid of `cl-pushnew' altogether since it amounts to doing everything manually anyway? -- underground experts united https://dataswamp.org/~incal