From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Thu, 29 Dec 2022 14:28:50 +0000 Message-ID: <87zgb6gu71.fsf@posteo.net> References: <6829F6A2-C6FD-4807-B3D2-1E740ED496BC@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25499"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60338@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 29 15:30:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAtv8-0006TE-IH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Dec 2022 15:30:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAtv2-00070v-RN; Thu, 29 Dec 2022 09:30:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAtv1-00070l-Jg for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 09:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAtv1-00033d-BA for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 09:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAtv0-0007A9-Un for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 09:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Dec 2022 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60338-submit@debbugs.gnu.org id=B60338.167232414827443 (code B ref 60338); Thu, 29 Dec 2022 14:30:02 +0000 Original-Received: (at 60338) by debbugs.gnu.org; 29 Dec 2022 14:29:08 +0000 Original-Received: from localhost ([127.0.0.1]:59619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAttt-000785-5s for submit@debbugs.gnu.org; Thu, 29 Dec 2022 09:29:08 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:48175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAttr-00077t-MC for 60338@debbugs.gnu.org; Thu, 29 Dec 2022 09:28:52 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AC3B4240177 for <60338@debbugs.gnu.org>; Thu, 29 Dec 2022 15:28:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672324125; bh=M8pg2Jf3UE9FOgr2HOWgV/kcKY0vWqo3Ud53lYVlbtY=; h=From:To:Cc:Subject:Date:From; b=qVkirpHYN7tusSGUSNYSZZMowTrydHwiTZ/z95T9U2EJ+6C4H15Kq7n+Rt6awMzXT ZB7qI0fo4w+2eIcK6/BkEoVGuVp56T+wiWf8Brcukf7Jcj+8AAcuPEI4b3odH9Il0n 2ByW/1HkU2HXmUBeGrobudsHfbogqNcUbfcohWtXVHGcmcxY8zFA8ECyQ92bz6Fvou o6u1Z+e0TEiHmlgQPO/Ae//Eh9Myr2pta28xy9KvB0vQgKRFbK2lfqDT2rf7NNEVq8 p69xgQbbedA9V47mfPJm7CREOUMS201c/Vlf3ublAH7fZoQ4BW8NldleAaEKHGcJlg 2g0pQIRp6MAbw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NjW3J62GYz9rxG; Thu, 29 Dec 2022 15:28:44 +0100 (CET) In-Reply-To: <6829F6A2-C6FD-4807-B3D2-1E740ED496BC@gmail.com> (Yuan Fu's message of "Wed, 28 Dec 2022 16:01:39 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252037 Archived-At: Yuan Fu writes: > Philip Kaludercic writes: > >> X-CC-Debbugs: >> >> I'd like to propose adding an option that makes server modifications by >> Eglot less invasive. The current behaviour is to make the changes >> directly in a buffer and open the remaining files to make the >> modifications in those as well (?). If `eglot-use-diffs' is enabled, >> all confirmations are prepared as patches in a pop-up buffer that the >> user can review and apply at will. To my knowledge there is no general >> `diff-apply-hunk' that will apply all the changes from a buffer, but >> that is a separate issue that can be fixed in a separate patch. >> >> (Note, I'm still testing emacs-29, so the patch was developed on that >> branch. But it should be applied to master) > > This seems really nice :-) Have you tried it out? My worry is that there are some simple changes that don't warrant a diff, but I don't know how these can be distinguished.