From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#60562: [PATCH] Fix split-string error if there is a space in the filename. Date: Fri, 06 Jan 2023 10:48:43 +0100 Message-ID: <87zgawgfic.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29804"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60562@debbugs.gnu.org To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 06 10:49:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDjLv-0007UC-G4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Jan 2023 10:49:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDjLX-0005HK-62; Fri, 06 Jan 2023 04:49:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDjLS-0005Gr-Jb for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 04:49:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDjLS-0000ja-9o for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 04:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDjLS-0000yU-33 for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 04:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2023 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60562-submit@debbugs.gnu.org id=B60562.16729985333730 (code B ref 60562); Fri, 06 Jan 2023 09:49:02 +0000 Original-Received: (at 60562) by debbugs.gnu.org; 6 Jan 2023 09:48:53 +0000 Original-Received: from localhost ([127.0.0.1]:53818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDjLI-0000y6-Vi for submit@debbugs.gnu.org; Fri, 06 Jan 2023 04:48:53 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:37753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDjLH-0000xu-OX for 60562@debbugs.gnu.org; Fri, 06 Jan 2023 04:48:52 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so3167169wmb.2 for <60562@debbugs.gnu.org>; Fri, 06 Jan 2023 01:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=lrtbGT3mU5gLe+ZtPXwyifHemVU8Qr8ijxzL7g3IeyI=; b=X4hTyD1LmxwU7kjlNmHME0DSEu1oFSHqh/Sz/YvvKqg4502ADlWxwHeRGL9BkM0z86 Br/0QnBKTTEEm+O1qHFRKJPdQbVq1hGuv2tSzOt/e6DcedppF4z0TqWAMhrsVOQS3Iy7 Nr6/4ej54+NTDa/7D+unoHU0UZk29oTOb14AG9BOxIP75dmQ78SODNr/IOKSEmeIdR0k aqC7w4jWiMGJTaFBDqpwOIBmKpv1z3CdO0OynfapZ/iW8F9ACD/H6m4N1qQYxbt04U1Q CVGaT76/uwvcIfNIzXG+2crepxouTLbsu3Y09IAq0UsjkHaF86OEsoFHd1lz0tHy5/Zx 0Q7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lrtbGT3mU5gLe+ZtPXwyifHemVU8Qr8ijxzL7g3IeyI=; b=2DcoXYzC1r2/F3UNsXjnrvCWi1Y220aREW/xAMYXniwSVSVk+SgJfT63mimpTj9zyv Ed876xYwv2H+r/J2PWG9o0DOIBbBmoETMOOuRl/EeIp7sdXOH0wcxmOJue6L9AzajbWy pyflC00JQZh5RX5rDmizYgIoy0aEqoc4X9aShmLGgjSR7ZFOXZxZ43L1YdqEbp/uXRQh XpRKAiE4+l3w+lfxL3k175xBgyzd0AztxMYgkJT8+yXLW1I6lH5U3crQV/lQDE0eJSYI 3bas3d9XJsaFh/AoJL2EeupPB1AS4b2YXKtayyuXu8VMnV4+5MHyaAcU/vSTbTYmfDkf 3+6Q== X-Gm-Message-State: AFqh2kp+HaoweYnNUZJ5JWwc5sLaeGNqW6DUnxWEMaxrxE51+qhxmqTE ovb3RGuYYNdfgV1Nc2nTl+jBM1Qz5tc= X-Google-Smtp-Source: AMrXdXt/qXV+I/xXNyrFQS+btFSsFw3KozX9XjV7UT9tHyVWk5KQ8UAss1HPEzPtQZ6lCDxLYATxRA== X-Received: by 2002:a05:600c:3ca2:b0:3d9:da3a:ef9b with SMTP id bg34-20020a05600c3ca200b003d9da3aef9bmr1578621wmb.31.1672998525192; Fri, 06 Jan 2023 01:48:45 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id q4-20020adff784000000b0026e94493858sm627537wrp.106.2023.01.06.01.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 01:48:44 -0800 (PST) In-Reply-To: (lux's message of "Thu, 5 Jan 2023 06:56:05 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252682 Archived-At: >>>>> On Thu, 5 Jan 2023 06:56:05 +0800, lux said: lux> * lisp/htmlfontify.el (hfy-list-files): Specify separator (\n\r). lux> --- lux> lisp/htmlfontify.el | 5 +++-- lux> 1 file changed, 3 insertions(+), 2 deletions(-) lux> diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el lux> index c989a12d205..be020b6b1c5 100644 lux> --- a/lisp/htmlfontify.el lux> +++ b/lisp/htmlfontify.el lux> @@ -1826,8 +1826,9 @@ hfy-list-files lux> ;;(message "hfy-list-files");;DBUG lux> ;; FIXME: this changes the dir of the current buffer. Is that right?? lux> (cd directory) lux> - (mapcar (lambda (F) (if (string-match "^./\\(.*\\)" F) (match-string 1 F) F)) lux> - (split-string (shell-command-to-string hfy-find-cmd))) ) lux> + (remove-if #'string-empty-p lux> + (mapcar (lambda (F) (if (string-match "^./\\(.*\\)" F) (match-string 1 F) F)) lux> + (split-string (shell-command-to-string hfy-find-cmd) "[\n\r]+")) )) You can avoid the issue (and improve portability) by using `directory-files-recursively' instead of `find' (which is annoyingly hard to remember, since the obvious search leads to `list-directory'. Perhaps we should add `list-directory-recursively' as an alias?) Robert --