From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#61149: 29.0.60; keymap-local-set rejects key sequences Date: Mon, 30 Jan 2023 09:46:49 +0100 Message-ID: <87zga0jtom.fsf@rub.de> References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> <871qndbbrn.fsf@rub.de> <87fsbszc54.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 61149@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 09:47:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMPp9-0009vB-Rl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 09:47:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMPos-0002oV-Nf; Mon, 30 Jan 2023 03:47:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMPod-0002lg-P8 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 03:47:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMPoc-0007pG-A7 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 03:47:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMPob-0006Ci-U3 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 03:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61149 X-GNU-PR-Package: emacs Original-Received: via spool by 61149-submit@debbugs.gnu.org id=B61149.167506842023841 (code B ref 61149); Mon, 30 Jan 2023 08:47:01 +0000 Original-Received: (at 61149) by debbugs.gnu.org; 30 Jan 2023 08:47:00 +0000 Original-Received: from localhost ([127.0.0.1]:46281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMPoZ-0006CS-Tb for submit@debbugs.gnu.org; Mon, 30 Jan 2023 03:47:00 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:43171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMPoY-0006CC-8U for 61149@debbugs.gnu.org; Mon, 30 Jan 2023 03:46:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675068409; bh=MPmLxjiXey7aZ3nNUVYg7OFds5AFZXqYClImjIN81f8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=r8TnRDijPH2j0bXC5Ve0kMadOC9li6jEYxPZIEssgL4Mh/Lyj0k/4EazSD0E0fKDK exOQ52d72PWe2gcHnlmWZQ80QaqgTK+7MmFfimQSQQh8NGFz0mlxiUU8KtNfso5zk8 OIQkR/jboYPfQJAeALmTiAPQ5kvWu5s5RXp9S8ER3fQOp8uinrKMtsyKUGX7Odq8Mh XU/P/Ixm86yKlG5qb2FbUroMJY/ufiFDT64v7oNOssN1Hs+blfH41B04nUx9Z9D9Ko lhvDoevIY/pv/7bnKLn8roCKNaGh4Tff24rk9ifV9xj2E/5k0Da1oKQfv4CEx6Ladt fbB693yksjHmA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([89.246.36.163]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTzf6-1pDANv36l0-00QxEo; Mon, 30 Jan 2023 09:46:49 +0100 In-Reply-To: <87fsbszc54.fsf@gmail.com> (Robert Pluim's message of "Mon, 30 Jan 2023 08:59:03 +0100") X-Provags-ID: V03:K1:9j5flNL0xswTozUpfqhkjt8lv1CD0TyDM1AdopeH0G342um8x6a kaROCWD/LETEN9fEdu9m8vfEqAjfPX62KonkI1g2wCELi10rpV/dAxl9VqBHXvOFsLuR9ni g8Xdqzw1sXGbibGZJqZT8sfqm3Lusnn1Vm6S3lVAbBd/2OfzVLAcEw3Lq2SMDZhFTC3F9GK zNuuSet+vHdnpZEVFViWw== UI-OutboundReport: notjunk:1;M01:P0:UCEvpugyYAU=;rrBtZxBajabXpX9yzeikFazzx3S jWwzfS3voGhf2PjKsHGqsfYGTMp/G4kidBa70xqn6IBYphGRtrj9JW6THY9KiDy25vNJDVrbJ kkiStKw0lwhBZ19ykxXEKX/IYUA36uCB/VYMEN11SAz3ySAxxFWjyHQ/JhBiZ63eE2DaU7hwf NWF71QK14MwxVnEPPJOUdSklByvU/Oeznm9t27zWd0JJfggmGuCJ6rvoozSXwKxd7tRNQMrpx 53KweExwHyf1NYXyQDeADxOilp5DbTraVTKgJlcJlBwFg46TM/XH0q1dME73eXUH4d8ygTXHf kpdorG3fp4YboOu8Ll9QJlF/kqP+AFaG1uhOH31GPSyaN6u8bwkGaa8khHXwixDl9Qr5yzisX v3LuoXgupAfe8UXmoNownDebT6p3PBamAWqwRS5363Gb1/Bhhz1lM9zLfVrDpc6e13Y15mmD/ dCC3AvqJx/+jtOefAXNRwhPjAxVBoJhuIMmA7N6uxhikAb7+y2gsUoIPqzTqbh5aSyppAWWq9 Ps6z7I8qzZqqXOuYS0GlPb2g0qWsO+l73jWZr384Tj4Io0QyfI+PCE4BR/63jVH7BIqr9Rpc6 8gwuxTIT2ttUWl8ZfA6TNWDQT0dcd9s72bn5/TfuVe75GdCzkN9Gq6xnqXKvg9iwMbiIJzJlw uWPyF8DJUyjerfICNu4u6VajcmbnLzvVhK7K95RyrzqEZ4WVU4mIce/4aB3OcEt+z/zX4wgMB t0t8NMbtFyWcjdvdjeSt1YPz7VKjheMTZ82JawfZufNt32jsImDnMHfflKBnkHDNulSazGn4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254396 Archived-At: On Mon, 30 Jan 2023 08:59:03 +0100 Robert Pluim wrote: >>>>>> On Sun, 29 Jan 2023 16:28:44 +0100, Stephen Berman > said: > > Stephen> ... but not in your non-interactive case; so maybe this instead: > > Stephen> diff --git a/lisp/keymap.el b/lisp/keymap.el > Stephen> index 791221f2459..48ec91d03c8 100644 > Stephen> --- a/lisp/keymap.el > Stephen> +++ b/lisp/keymap.el > Stephen> @@ -98,6 +98,8 @@ keymap-local-set > Stephen> (let ((map (current-local-map))) > Stephen> (unless map > Stephen> (use-local-map (setq map (make-sparse-keymap)))) > Stephen> + (unless (stringp key) > Stephen> + (setq key (key-description key))) > Stephen> (keymap-set map key command))) > > `keymap-global-set' has the same type of issue. Thanks, I failed to check that. > How about this > instead: > > diff --git a/lisp/keymap.el b/lisp/keymap.el > index 791221f2459..1a339598f0c 100644 > --- a/lisp/keymap.el > +++ b/lisp/keymap.el > @@ -79,7 +79,7 @@ keymap-global-set > (interactive > (let* ((menu-prompting nil) > (key (read-key-sequence "Set key globally: " nil t))) > - (list key > + (list (key-description key) > (read-command (format "Set key %s to command: " > (key-description key)))))) > (keymap-set (current-global-map) key command)) > @@ -94,7 +94,12 @@ keymap-local-set > The binding goes in the current buffer's local map, which in most > cases is shared with all other buffers in the same major mode." > (declare (compiler-macro (lambda (form) (keymap--compile-check key) form))) > - (interactive "KSet key locally: \nCSet key %s locally to command: ") > + (interactive > + (let* ((menu-prompting nil) > + (key (read-key-sequence "Set key locally: " nil t))) > + (list (key-description key) > + (read-command (format "Set key %s to command: " > + (key-description key)))))) > (let ((map (current-local-map))) > (unless map > (use-local-map (setq map (make-sparse-keymap)))) This also DTRT, but it also gives keymap-local-set the same UI as that of keymap-global-set, which is that at the first prompt the cursor jumps out of the minibuffer (due to read-key-sequence), and then jumps back at the second prompt. I find this quite jarring (and the first time I was quite surprised and thought I had either mistyped or there was a bug). I would prefer it if both commands had keymap-local-set's current UI. Steve Berman