From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Eglot tests on EMBA Date: Fri, 31 Mar 2023 14:14:54 +0200 Message-ID: <87zg7tce2p.fsf@gmx.de> References: <87y1nyi5cq.fsf@gmx.de> <87tty3eide.fsf@gmx.de> <878rfddxeu.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23594"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 31 14:15:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piDey-00062V-SS for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Mar 2023 14:15:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piDem-0007xA-Sn; Fri, 31 Mar 2023 08:15:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piDel-0007wx-Eg for emacs-devel@gnu.org; Fri, 31 Mar 2023 08:14:59 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piDej-0005vi-KZ for emacs-devel@gnu.org; Fri, 31 Mar 2023 08:14:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680264895; i=michael.albinus@gmx.de; bh=x/XejzQ4NeaDPThf8fquJJ/BTvGLiJ+aL2q+jjibfu4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=IGnLv5rLZFW/vLsVcxFr+W0/0vddfGp4meNXA/DUftg17UlSYB1WBhhYX95X6m+xC HCp8M0USTG7zspGScAAtiJizWe6BoB9ucgmG5iRVwuvcH2Q4LJG2sm4u05trLTBgSZ WsDeTaxB6NsfXLoEFvFJaKX7nDmMd03mkFtXmsTv4JdlAnq6uMNBwtBe//5ex408C1 nIvV+Qp2y07seXi/kSR/E0teDKyp9XIhqEDM1l/tw8eACwLd1jzkH1ttyjCsfHZ7ZV SfE1vEVf/j9FzAITj3BLQFN43G5n/KZKs9oPTJJOtvYQ0Y88MCKa/e2jrahq/aoSxH YGlsEKAWEmSmg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3se2-1qQ2ne3V68-00znub; Fri, 31 Mar 2023 14:14:54 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 31 Mar 2023 11:50:46 +0100") X-Provags-ID: V03:K1:HAEp+MnEwNYpJKfU9U5QxqBa1+WLjGxMzoVhMG49aqSRnWsL3eH s6CRvop/61vYkPEr8GWo9MssNXemAEfs70TF8gMWd9+y2REXyRXH8/MvmzlGZSKd3udjcXH n514VxTvB0ybVLma5T8kn12Jp6b8PI6qzVqEwpg9idgKr3J5ut5C5HYJxWtj7hC6bUvXhOc mkYlO9pI7tpRmr2dkSrDA== UI-OutboundReport: notjunk:1;M01:P0:NkAv7j+4ic0=;jgnfXmQRP5dNmdhPKrBx8HIoxVu SY2k2OK8BMiJ2PY0aa1jJJ5y4DEaalTqjS4451at0yKhY1jChMR5KzK9Y74N52RPZSG7XQXf7 Gh631V74cLXxePTOopcUjbDfD37AN7nj0zF+DMlAaTwq6xBuFAt+6v19rWDr+pEigAs7yTvz2 O20GxAkj6D3LQ9MuaTaKgNP/6WdsJKutV8H/V4EHIYx73G0GiSezpGGiS7tnwpgq8XCY52mO6 hcD8/P12im7wkgNhqPhq/4hAphFvWd5rtUmEXwsBkr6mQhDNUbB/QszzxhQ3oqzf17lJFH+mG vxtYV8evItVOcaFVEIhaZE5hih8DxHCivDnDoUVSc/l1ZMukQBeY+xyWeB4CjnmrMioWXbNV5 cmpLqC0LwOxx3KD6Bl/1EKFh2tSJXY8dirE+p9vVVRSycLyUSDSj6AkvztvcFU5cfWGty6c64 Hh0XqytU3YJKnQLdkM4jOd/SpdNcLUHcwJ1kJVetxRt2loKyM4zhtmmyl1mh0DCF7mNALs0e3 Kj0txq4DBVe3VAHn5eOBcI4OVwEebnRpjlSzU/Fl3530BmfqLHxv5i2aXsPsR6clyBXJTmnk+ 6bJiMsDgabBju9L9F9TShK8x+AcdzcigJE/7fr7Ynqn21V8uKrz9PA9prJmWzm+akxj2FJ9Bz wNbzQKl8xTGeGnMc5cVULrsYqAlEIJPjjGYDbbkc4xa47LZx/oxgDQ09nCUV/HcLUNc1mwkYe YxTxjpgVq54q1A87PMEnhZIRUwfTHA5LI0C0M+lXgHo0b1CHB/UEb0EF+7sIzhKSKxhe06kf Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304914 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >> I'm not happy with this. EMBA installs a conservative list of software; >> they shall be available as Debian bullseye package. > > Then you should complain to Debian and uninstall pylsp on EMBA is the > meantime. Nothing to complain to Debian. They offer pylsp in the testing version; we have simply decided not to use it. We use the stable version. >> Since Debian bullseye does not offer the package python3-pylsp (which >> will be available with a later Debian release), I install on EMBA >> python3-pyls. This shall be sufficient, because (according to >> eglot-server-programs) "pyls" is supported. >> >> eglot-tests.el does not dertect this, it checks only for "pylsp". I >> believe this shall be changed, > > No, it shan't :-) I'm not even sure how to do so portably. The most simple way would be --8<---------------cut here---------------start------------->8--- (skip-unless (or (executable-find "pylsp") (executable-find "pyls"))) --8<---------------cut here---------------end--------------->8--- But this is a sledge hammer approach I guess. > Just undo your installation of pylsp on EMBA and I'll look > into replacing that test with some other language server. > > Or run `pip install "python-lsp-server[all]"` in the dockerfile. > > Let's not overcomplicate eglot-tests.el with these things. eglot-tests.el run for your environment. But there are people with other environments (like Debian stable), which could errors running eglot-tests.el. >> the check shall be for all alternatives >> configured in eglot-server-programs. And not only for python, but also >> for other languages. > > No, that's an immense amount of work and that's not what these > tests are really for. People add stuff to eglot-server-programs > liberally: it's a huge database now. I'm not crazy about that but > is has always been the most fair practice to acommodate server > preferences, and people seem like to see their favourite server at > least represented there. Is it that hard to extract all relevant server executables for a given major-mode, and iterate over them with executable-find? > But some of these servers don't work, are deprecated, have > inconsistent executable names on different platforms: it's > a mess. Testing that is way beyond the scope of eglot-tests.el. In such a case, the test shall fail. And that would be OK, by this you get feedback what doesn't work (given people write bug reports). > You may lobby for a eglot-server-program-tests.el instead, > and I won't oppose it, but I personally don't have time for that, > nor do I see a lot of value at the moment. > > eglot-tests.el is testing the server-agnostic Elisp logic in > eglot.el -- Eglot _is_ server agnostic. We just happen to need > someone speaking LSP to be able to exercise features. We could just > as well have a (compliant) Elisp LSP server simulator and not worry > about external language servers in eglot-tests.el at all. But that's qu= ite > a bit of work. So some common installations of language servers are need= ed. Sure, possible. I was just speaking about the given state of eglot-tests.el. > `clangd` seems to be a fairly reliable one so I've been looking > at transferring most of the tests that I can to clangd. But it > doesn't exercise _all_ the features that Eglot supports, like > file watching. > > I'll look into adapting this test for clangd instead of pylsp. OK. > In the meantime, just uninstall python-lsp-server on EMBA and > let this test be skipped for now. Or install it like I suggested. Will do. Best regards, Michael.