#o544 is user rw?

#o544 is user rw?

[Ruijie Yu via General discussions about Org-mode.]

I'm looking at this `defcustom', and its docstring looks wrong.  It says
that #o544 corresponds to "u=rw,g=r,o=r", but shouldn't it be
"u=rx,g=r,o=r"?  Something is wrong, unless there is another definition
of permissions that I'm not aware of.

--8<---------------cut here---------------start------------->8---
(defcustom org-babel-tangle-default-file-mode #o544
  "The default mode used for tangled files, as an integer.
The default value 356 correspands to the octal #o544, which is
read-write permissions for the user, read-only for everyone else."
  :group 'org-babel-tangle
  :package-version '(Org . "9.6")
  :type 'integer)
--8<---------------cut here---------------end--------------->8---

This is lisp/ob-tangle.el:161, in recent master.

-- 
Best,


RY

Re: #o544 is user rw?

[Timothy]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Hi Ruijie,

> I’m looking at this `defcustom’, and its docstring looks wrong.  It says
> that #o544 corresponds to “u=rw,g=r,o=r”, but shouldn’t it be
> “u=rx,g=r,o=r”?  Something is wrong, unless there is another definition
> of permissions that I’m not aware of.

You are correct. I have a feeling that the value should be changed to #o644 to
match the docstring though, rather than the docstring being updated,
particularly as execution can be set via :shebang.

Any objections?

All the best,
Timothy

-- 
Timothy (‘tecosaur’/‘TEC’), Org mode contributor.
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/tec>.

Re: #o544 is user rw?

[Ihor Radchenko]

Timothy <orgmode@tec.tecosaur.net> writes:

> Any objections?

Fixed, by Timothy, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6a96054f0

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>