From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Wed, 14 Jun 2023 11:27:12 +0000 Message-ID: <87zg52e12n.fsf@posteo.net> References: <87ilhy1dub.fsf@posteo.net> <877cs97kgb.fsf@posteo.net> <83jzw8yjv5.fsf@gnu.org> <877cs8g8oy.fsf@posteo.net> <83fs6wyhak.fsf@gnu.org> <87y1koerm6.fsf@posteo.net> <83bkhkyeze.fsf@gnu.org> <87v8fr6o86.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60338@debbugs.gnu.org, joaotavora@gmail.com To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 14 13:28:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9Ofe-0008sk-Vj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jun 2023 13:28:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9OfU-0003CW-J8; Wed, 14 Jun 2023 07:28:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9OfS-0003CL-MK for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 07:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9OfS-00020D-Ac for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 07:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9OfS-0006ov-0Q for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 07:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 11:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60338-submit@debbugs.gnu.org id=B60338.168674204126164 (code B ref 60338); Wed, 14 Jun 2023 11:28:01 +0000 Original-Received: (at 60338) by debbugs.gnu.org; 14 Jun 2023 11:27:21 +0000 Original-Received: from localhost ([127.0.0.1]:43864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Oen-0006nv-AM for submit@debbugs.gnu.org; Wed, 14 Jun 2023 07:27:21 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:60075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Oel-0006nd-I5 for 60338@debbugs.gnu.org; Wed, 14 Jun 2023 07:27:20 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 53DD824002B for <60338@debbugs.gnu.org>; Wed, 14 Jun 2023 13:27:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686742033; bh=fjuxAxQbGGhfokbUF/1jiIma1/o6vY8bJhPyWmQz8Kg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=beKNK8+xGbNR9yb1eYimy7tuWOu7pe1EM0WPewRM4CWMeqHtEHFc7hDjh43FaLgVF fdGbcK1t4L77kcAkgfhYCeH2hRgtUqT4R1zL8RvV8EdiqoImrebvs9CkP7vxtdksXN 7VJXHLk29U0Wnm0OAVxZHz56VOIquyxvEXiueyjZQpJnV/wrxybuJbMIRKfHgTn72q R2vk2IUIAjNKPuaQOIQT+oO66PpXlmbjDeji6YFDQv3898AJh7WJIdBrmnyt0EpcoP zTWq0M+nQtZbFaCekfC0ZeO0zvaY9BJTKWQsI/ba65RydUaQ2QqE694btBZ1wiBuwL IJHMPbuFM46Kw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qh36m3Wrwz6tvh; Wed, 14 Jun 2023 13:27:12 +0200 (CEST) In-Reply-To: (Eshel Yaron's message of "Wed, 14 Jun 2023 09:00:27 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263361 Archived-At: Eshel Yaron writes: > FWIW I'd definitely want to use this feature when it lands. > >>> It doesn't necessarily have to be the full-fledged diffs, it could be >>> something approximate. After all, this is for human consumption. >> >> Not really, the point is that you can apply these diffs directly. Also, >> I would not say that diffs are not for human consumption. > > I agree, it'd be nice to get a proper diff buffer with all the benefits > of `diff-mode`. Right. > I also see how it would be useful for Emacs to be able to generate such > a diff buffer directly from the change description that the LSP server > provides, without applying the change and running the diff program, but > it doesn't seem quite trivial so I hope that can be implemented as an > enhancement down the line. (I'd be happy to help with that, BTW.) Yes, and we were to do this, I'd rather add it to a pure-elisp `diff' to diff.el so that it can be transparently reused anywhere where the "diff" program is missing.