all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Akira Kyle <akira@akirakyle.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-html.el: Fix relative links with :html-link-use-abs-url
Date: Sun, 18 Jun 2023 11:25:08 +0000	[thread overview]
Message-ID: <87zg4x812j.fsf@localhost> (raw)
In-Reply-To: <m2sfapx66v.fsf@akirakyle.com>

Akira Kyle <akira@akirakyle.com> writes:

> I'm pretty sure this fixes a bug and that the intended behavior is 
> that when publishing with, say, ~:html-link-use-abs-url t~ and 
> ~:html-link-home mysite.com~, one would expect a link like 
> ~[[file:my/page.org]]~ to be exported to ~mysite.com/my/page.com~.
> ...
> -			 (file-name-absolute-p raw-path))
> +			 (not (file-name-absolute-p raw-path)))

Looks right.
Would you mind also adding a test to testing/lisp/text-ox-html.el ?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-06-18 11:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-17 19:01 [PATCH] ox-html.el: Fix relative links with :html-link-use-abs-url Akira Kyle
2023-06-18 11:25 ` Ihor Radchenko [this message]
2023-07-10  8:18 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg4x812j.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=akira@akirakyle.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.