Re: [PATCH] org-capture.el: Allow `(here)' as a template

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[No Wayman]

`org-capture-store-last-position' will signal an error if a 
template with a target of (here) is invoked from a buffer which is 
not backed by a file.

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[Ihor Radchenko]

No Wayman <iarchivedmywholelife@gmail.com> writes:

> `org-capture-store-last-position' will signal an error if a 
> template with a target of (here) is invoked from a buffer which is 
> not backed by a file.

What kind of error?
I was able to trigger an error when capturing from non-Org buffer, but
that's expected - org-capture is not designed for such scenarios.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[No Wayman]

No Wayman <iarchivedmywholelife@gmail.com> writes:

> Evaluating the following source blocking an org mode buffer with 
> no backing file:

Interesting. I'm only able to reproduce it some of the time.
I'll look into it more when I have time, but it may have been an 
artifact of my Emacs session.

>> I was able to trigger an error when capturing from non-Org 
>> buffer, but
>> that's expected - org-capture is not designed for such 
>> scenarios.

This seems unnecessarily restrictive considering there is a 
"plain" entry type, but that's another issue/design consideration.

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[Ihor Radchenko]

No Wayman <iarchivedmywholelife@gmail.com> writes:

> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
>> Evaluating the following source blocking an org mode buffer with 
>> no backing file:
>
> Interesting. I'm only able to reproduce it some of the time.
> I'll look into it more when I have time, but it may have been an 
> artifact of my Emacs session.

I saw

Debugger entered--Lisp error: (error "Buffer not visiting a file or directory")
  error("Buffer not visiting a file or directory")
  bookmark-buffer-file-name()
  bookmark-make-record-default()
  bookmark-make-record()
  bookmark-set-internal("Set bookmark named" "org-capture-last-stored" overwrite)
  bookmark-set("org-capture-last-stored")

Was it the same for you?

>>> I was able to trigger an error when capturing from non-Org 
>>> buffer, but
>>> that's expected - org-capture is not designed for such 
>>> scenarios.
>
> This seems unnecessarily restrictive considering there is a 
> "plain" entry type, but that's another issue/design consideration.

Hmm. plain entry type actually works, except the above error, which is
likely Emacs bug.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[No Wayman]

Ihor Radchenko <yantar92@posteo.net> writes:

> No Wayman <iarchivedmywholelife@gmail.com> writes:
>
>> No Wayman <iarchivedmywholelife@gmail.com> writes:
>>
>>> Evaluating the following source blocking an org mode buffer 
>>> with 
>>> no backing file:
>>
>> Interesting. I'm only able to reproduce it some of the time.
>> I'll look into it more when I have time, but it may have been 
>> an 
>> artifact of my Emacs session.
>
> I saw
> Was it the same for you?

Yes, that's the same error. (Sorry, looks like an intermediate 
message of mine got dropped)

> Hmm. plain entry type actually works, except the above error, 
> which is
> likely Emacs bug.

Could be.

Re: [PATCH] org-capture.el: Allow `(here)' as a template

[Ihor Radchenko]

No Wayman <iarchivedmywholelife@gmail.com> writes:

>>> Interesting. I'm only able to reproduce it some of the time.
>>> I'll look into it more when I have time, but it may have been 
>>> an 
>>> artifact of my Emacs session.
>>
>> I saw
>> Was it the same for you?
>
> Yes, that's the same error. (Sorry, looks like an intermediate 
> message of mine got dropped)

Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=94c2c8d92

The error was only triggered when debug-on-error is non-nil.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>