From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64242@debbugs.gnu.org, daniel@dsemy.com
Subject: bug#64242: [PATCH] Fix VC package build when there is no docs dir
Date: Sat, 24 Jun 2023 15:34:40 +0000 [thread overview]
Message-ID: <87zg4oeuwf.fsf@posteo.net> (raw)
In-Reply-To: <83pm5lywci.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jun 2023 13:43:09 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: 64242@debbugs.gnu.org, Daniel Semyonov <daniel@dsemy.com>
>> Date: Sat, 24 Jun 2023 10:24:47 +0000
>>
>> Regarding Daniel's patch, I don't believe we need `file-name-directory'
>> at all, the variable `docs-directory' is just passed to makeinfo -I, and to
>> my knowledge it should make a difference if the argument ends with a
>> directory delimiter or not.
>
> Are you thinking about directory-file-name instead of
> file-name-directory?
Eh, yes of course I didn't try the patch and expected that to fail.
> The latter returns the parent directory of its
> argument, it doesn't affect the trailing slash. The FILE argument
> passed to package-vc--build-documentation is a file, not a directory,
> so the file-name-directory call seems justified if we want to pass the
> directory to makeinfo.
Right, my bad.
> Or what am I missing?
No, it is all my fault. I'll try the patch our and if it all works I'll
push it to emacs-29. Ok?
--
Philip Kaludercic
next prev parent reply other threads:[~2023-06-24 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 5:45 bug#64242: [PATCH] Fix VC package build when there is no docs dir Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 6:02 ` Eli Zaretskii
2023-06-23 6:32 ` Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23 7:10 ` Eli Zaretskii
2023-06-23 7:35 ` Philip Kaludercic
2023-06-24 10:24 ` Philip Kaludercic
2023-06-24 10:43 ` Eli Zaretskii
2023-06-24 15:34 ` Philip Kaludercic [this message]
2023-06-24 17:07 ` Eli Zaretskii
2023-06-25 21:41 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg4oeuwf.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=64242@debbugs.gnu.org \
--cc=daniel@dsemy.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.