From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Thu, 13 Jul 2023 21:00:18 +0000 Message-ID: <87zg3zcysd.fsf@localhost> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="326"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 23:01:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK3RB-000AU4-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 23:01:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK3Qt-0006VV-QA; Thu, 13 Jul 2023 17:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK3Qs-0006VM-Pf for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 17:01:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK3Qs-0002ci-He for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 17:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qK3Qs-0006U0-1P for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 17:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168928202524843 (code B ref 64596); Thu, 13 Jul 2023 21:01:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 13 Jul 2023 21:00:25 +0000 Original-Received: from localhost ([127.0.0.1]:40920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK3QH-0006Sd-EL for submit@debbugs.gnu.org; Thu, 13 Jul 2023 17:00:25 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:48313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK3QC-0006SB-Vs for 64596@debbugs.gnu.org; Thu, 13 Jul 2023 17:00:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AE0C3240101 for <64596@debbugs.gnu.org>; Thu, 13 Jul 2023 23:00:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689282014; bh=/q4HZFegT/P0Kq5N56WR5k9Ogv08YvFvNW/2ptB1qRE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=ZseDEfJaYYRp4foy33RrAbgT4xsI5a6Dw4CH8bGAhhXs9E/07R1XYtc3qZS33obLm tM4D///SWZiFjSBpVZ2K1ZD5+t1+E6ERMhEPYvQshnSyLysGY0M7kDBq3iWYsp/XEo CUQp17FS9wsXNUpf43GWr28Cuwm/gGpERUCEMWLZ85/jmh+a4NVBPROwcth8jnMaP3 4N6M77m6rk5HijWL+v5XVoPq5VDe09k+tm8QVtEXEKxyHc6wELL3W1027bsDOwQTJG TgzXQM+twJ0Ieh4SStGQ0sfzz/bGSSvXSzVeiosSWL9IcpteZB/5qPefREQQShsA7W p+DjObJNjF+9A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R26SY3v1yz9rxD; Thu, 13 Jul 2023 23:00:13 +0200 (CEST) In-Reply-To: <83lefj4okb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265048 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Then I guess you or Ihor (or both) should try removing that line and > run with that for a while. Yup. That's what I am already doing. See the attached diff. Beware though that I still haven't looked closely into your and Stefan's emails (it is late here) and I have no idea what I am doing in this diff. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=test.diff diff --git a/src/buffer.c b/src/buffer.c index 0c46b201586..db7dc5c3c68 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -1476,16 +1476,9 @@ DEFUN ("force-mode-line-update", Fforce_mode_line_update, (Lisp_Object all) { if (!NILP (all)) - { update_mode_lines = 10; - /* FIXME: This can't be right. */ - current_buffer->prevent_redisplay_optimizations_p = true; - } else if (buffer_window_count (current_buffer)) - { bset_update_mode_line (current_buffer); - current_buffer->prevent_redisplay_optimizations_p = true; - } return all; } @@ -1502,6 +1495,8 @@ DEFUN ("set-buffer-modified-p", Fset_buffer_modified_p, Sset_buffer_modified_p, { Frestore_buffer_modified_p (flag); + if (!flag) current_buffer->prevent_redisplay_optimizations_p = true; + /* Set update_mode_lines only if buffer is displayed in some window. Packages like jit-lock or lazy-lock preserve a buffer's modified state by recording/restoring the state around blocks of code. --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--