From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#64619: [PATCH] Add toggle-window-dedicated command Date: Fri, 14 Jul 2023 23:58:38 +0000 (UTC) Message-ID: <87zg3yhwpe.fsf@catern.com> References: <87jzv2p9e0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1839"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , Philip Kaludercic , "64619@debbugs.gnu.org" <64619@debbugs.gnu.org> To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 01:59:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKSgu-0000DZ-I5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 01:59:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKSgi-0001J0-1Z; Fri, 14 Jul 2023 19:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKSgf-0001Is-Vz for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 19:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKSgf-00055K-Np for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 19:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKSgf-0002BH-KH for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 19:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2023 23:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64619-submit@debbugs.gnu.org id=B64619.16893791278351 (code B ref 64619); Fri, 14 Jul 2023 23:59:01 +0000 Original-Received: (at 64619) by debbugs.gnu.org; 14 Jul 2023 23:58:47 +0000 Original-Received: from localhost ([127.0.0.1]:43653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKSgQ-0002Ad-Oj for submit@debbugs.gnu.org; Fri, 14 Jul 2023 19:58:47 -0400 Original-Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:32512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKSgO-0002AH-5y for 64619@debbugs.gnu.org; Fri, 14 Jul 2023 19:58:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=D59AkhxIJnXY60LGHwl04+mogHFuthseeqLvxKGmFJU=; b=EJcA3GIgikHGIeuRvLDuJ6EF01y6mtsztRnx7zx/uSIEWdZruE4JiKTUpP5Jxo36s4eu lkdYzUY/g9VPAJsvNS2zT+jkPvkjMARzFPrLS0HncWWO/FU9Sk19a8jkIpUm0bp8kjyRXt iNhL7Qpavywm6huFC3tqX2+MTm0nwvF/wqmVyLaMW9TZxwpQ1hAhZqBFNY9B026+zHH3RJ jusXOJgJjzraH2ACGzB6ecece2Wmta2ye/7BoEkX8asb/xCCMEeVyrIl821CfzXaMEv/nl CjvpU+J8LIOZGKhvE21lPfBf2NuB2oEN6ME6FWmT8EhcnuZKHTXuXaVW7lzHZ90A== Original-Received: by filterdrecv-65f68489c8-xfp5j with SMTP id filterdrecv-65f68489c8-xfp5j-1-64B1E12E-10 2023-07-14 23:58:38.184149357 +0000 UTC m=+5617356.790099461 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-39 (SG) with ESMTP id KahIYBqVSSiCwaGGX6_ZTw Fri, 14 Jul 2023 23:58:38.114 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=oracle.com Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 67C716015A; Fri, 14 Jul 2023 19:58:37 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Fri, 14 Jul 2023 21:17:18 +0000") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbLhDeYyk111yqx5sKsMgT2Dk5Ac0O6LZfLp4x7UzeEcL2gUl7rmfpDN+XCCMIBnF9unQ/EZxxu8bHjUrWnOuQE2xSM1WBkDrzfzqzqDXER30fqv52diTSfG8ZbsRA6aN1Hui7/lcGvJLG1P27Vh/D7R5lQlk3G7kuyKxXmUHcmYiw== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265133 Archived-At: Drew Adams writes: > Some minor comments. > >> + (if (window-dedicated-p window) >> + (progn >> + (set-window-dedicated-p window nil) >> + (when interactive (message "Window can now be used to display other buffers"))) >> + (set-window-dedicated-p window 'dedicated) >> + (when interactive (message "Window will now display only its current buffer")))) > > 1. Why _weakly_ dedicated? AFAIK, the difference is that if you explicitly try to switch buffer with e.g. C-x b, you succeed when the dedication is weak, and fail with an error when the dedication is strong. I find that if I explicitly hit C-x b, I want to actually switch buffers in the current window, I never want the switch to fail. Making it fail seems useful for Lisp programs, sometimes, but not so much interactive usage. > 2. Why not just this? > > (let ((before (window-dedicated-p window))) > (set-window-dedicated-p window (not before)) > (when interactive > (message "Window is %s dedicated to buffer %s" > (if before "no longer" "now") > (current-buffer)))) > > If someone might not know what it means for a > window to be dedicated, put that info in the > doc string, not in the message. Will do. > 3. The toggle, as OP proposed it, imposes weak > dedication, and the toggle as I wrote it above > imposes strong dedication. What if you want > a toggle that respects whatever non-nil FLAG > (weak or strong) might have already been used > for the window? > > IOW, what if the window is dedicated to start > with, before you first use the toggle, and you > want to get back that same dedicated behavior > (weak or strong) when you toggle it back again? > The toggle (either definition) doesn't do that. That would be nice, but I don't see a way to do it. At the same time, I think it's probably fine for the user to explicitly choose whether they want it to be weak or strong. After all, this way it allows the user to change the dedicated mode. > Shouldn't the doc make clear that the toggling > behavior is always between weak & undedicated > (OP version) or always between strong & > undedicated (my version, above)? IOW, let a > user know that any original dedicated behavior > is lost, once you use the toggle. > > Or if you want to let a user specify whether > to use weak or strong, maybe do that with a > prefix arg? Good point, I'll add a prefix arg for strong dedication.