From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Tropin Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon. Date: Tue, 25 Jul 2023 08:39:31 +0400 Message-ID: <87zg3kk3jw.fsf@trop.in> References: <877cqpsnct.fsf@trop.in> <83fs5dsd0g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 25 13:11:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOFwO-0004s8-Bs for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jul 2023 13:10:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOFvT-0008US-Oc; Tue, 25 Jul 2023 07:10:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qO9rx-00024F-Iw for emacs-devel@gnu.org; Tue, 25 Jul 2023 00:41:58 -0400 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qO9rv-0006gN-21; Tue, 25 Jul 2023 00:41:57 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id DFC3FC0005; Tue, 25 Jul 2023 04:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1690260109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N3E2PYJBh42JFlHmIx+Vs5bgw4XqRvfwYbQ+q1R0rbU=; b=o6MyEYyxDl3cofUoxRq0RgBoxdPi+uUbfikQZzRRB4TKZjF5JS7j6aYkzQ2qZdjZmDsWRu vXPgcwas5L+SMLk92cr8gZRHUOm/HfTX1tggmpXGOQ5cLWxV3QpvaRYwx7zZP/9U9TO98j UfP/47+l5Rf/zum3BJWuYjwTu9kEwjTeHrY7FzbtH5yadL+LfWL3BRIEAHYCki9dGb9Z1v 6psi5g5+/MwZ35uEiJf8Y1pR8wp8kAAvKoJjmHSsfhDkp+fwuVzv+3d7wP97HuZ4B1M5+B KSOW2YtQuw6VrtHxkkWCNbYEn+ctoPQPr2ql6Cy8fxkQhgTvq1uDSFrysVgCxQ== In-Reply-To: <83fs5dsd0g.fsf@gnu.org> X-GND-Sasl: andrew@trop.in Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=andrew@trop.in; helo=relay6-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 25 Jul 2023 07:09:57 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308089 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-07-24 15:35, Eli Zaretskii wrote: >> From: Andrew Tropin >> Date: Mon, 24 Jul 2023 12:39:06 +0400 >>=20 >> Icon is not always a file name, but can be just an icon name. >> https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec= -latest.html >>=20 >> * lisp/notifications.el (notifications-notify): Don't expand-file-name >> app-icon. >> --- >> Otherwise it not possible to send a notification similiar to: >> notify-send -i multimedia-player "I am playing music" >>=20 >> lisp/notifications.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/lisp/notifications.el b/lisp/notifications.el >> index 984ddbec5e9..c314858d0ae 100644 >> --- a/lisp/notifications.el >> +++ b/lisp/notifications.el >> @@ -304,7 +304,7 @@ notifications-notify >> notifications-application-name) >> :uint32 (or replaces-id 0) >> :string (if app-icon >> - (expand-file-name app-icon) >> + app-icon > > Thanks, but won't this break the cases where app-icon _is_ a file > name? Tried it and it doesn't, at least both=20 :app-icon (expand-file-name "emblem-default.png") and :app-icon "emblem-default.png" work with new implementation, when file in the cwd. I don't see other use cases that can break, so I guess it's backward compatible change. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmS/UgQACgkQIgjSCVjB 3rBg4g/8DFeUrcF+CRnM1OXMC444uhmJLVTRaOf4c59q3XSa4jWUy90XVSoil9OQ q5brPaQ5Ey1l3k17WNdpkK5xqnnCkl54+O7xI97hi563KnrITdXdzi0FrerO/vTl o2aXBCpYn1KZexOWLcBFAdAY9I36KjWPN+dFMYMpvVy6v6h/BoJxUYJSriZ73BSK FAe0w2HLGf8xmet37aPEVyWXV3S863zv6jSfcYjHr0SqMXUxfdGYkN3ZowBrFCSS p06CTmb7qASWIqnJvuPsDEC9kVZtIcKwZszjnVUXO5GYdgLcPMZb1yoLpXU8EmP/ iTed0nSzqxuWXjawRNMiRxQ35+sEwThBC98RqJKA4bd9FqH6W2eu/O2srkecrEqr Wpq9mG45GGXFpD9zP6pVFIfT9PiujUOn+rwrqzGm4rkUUx5J4fKKUogu5hHfmrzP X8LJjQ6MinT+V+9lgKUGzwAsI3YgDTOZwW4YjiHpDDkXY4EAtyPGCXaJ+EJIuL3B 8E6sZbiopNZYICiw4z2SWTc4icEYZK3Ib6guMMNzV47UWZe+/x2UuMzJ0InjrPDl 0IqTHtBDTlzadkuUc+Kv9OfYZklfqxiKsmuo04W9lgYWpynMS8LB5+5p0r9NWe4V KggVVm/FAbG13+Sox7l/fV713/eK8RERpr41pnsRT4V31AMKG0U= =Ue4o -----END PGP SIGNATURE----- --=-=-=--