bug#64942: 30.0.50; Header Bar remains white in GNOME's Dark Style

bug#64942: 30.0.50; Header Bar remains white in GNOME's Dark Style

[Utkarsh Singh]

Hello,

I have been using master with `-with-pgtk` option for the past 6
months. But recently, I think there is
a bug in PGTK build as it Header Bar remains white even when switching
to GNOME's Dark Style mode.

Thank you,
Utkarsh Singh

In GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-07-29 built on ideapad330
Repository revision: 65c4e3002e0824a7d081d2b326a93acbf718d0c3
Repository branch: makepkg
System Description: Arch Linux

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
 --with-modules --without-libotf --without-m17n-flt --without-gconf
 --with-native-compilation=yes --with-xinput2 --with-pgtk
 --without-xaw3d --with-sound=no --with-tree-sitter --without-gpm
 --without-compress-install
 '--program-transform-name=s/\([ec]tags\)/\1.emacs/'
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection'
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
 'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK
PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER
WEBP XIM GTK3 ZLIB

Important settings:
  value of $LANG: C.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr comp comp-cstr warnings icons rx cl-seq cl-macs
gv cl-extra help-mode bytecomp byte-compile emacsbug message mailcap
yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache
epa derived epg rfc6068 epg-config gnus-util text-property-search
time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip
cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq
simple cl-generic indonesian philippine cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
gtk pgtk lcms2 multi-tty move-toolbar make-network-process
native-compile emacs)

Memory information:
((conses 16 79096 13213) (symbols 48 7178 0) (strings 32 19406 2015)
 (string-bytes 1 582529) (vectors 16 14665)
 (vector-slots 8 266977 19190) (floats 8 27 63) (intervals 56 264 0)
 (buffers 984 10))

bug#64942: 30.0.50; Header Bar remains white in GNOME's Dark Style

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Utkarsh Singh <utkarsh190601@gmail.com> writes:

> Hello,
>
> I have been using master with `-with-pgtk` option for the past 6
> months. But recently, I think there is
> a bug in PGTK build as it Header Bar remains white even when switching
> to GNOME's Dark Style mode.
>
> Thank you,
> Utkarsh Singh

Emacs isn't a GNOME app, and doesn't use the library they use to
implement GNOME's global style switch.  If you want to change the style
used by Emacs's title bars, use GNOME Tweaks to modify the GTK
stylesheet instead.

Since this not a bug, I'm closing this ticket.  Thanks.

bug#64942: closed (Re: bug#64942: 30.0.50; Header Bar remains white in GNOME's Dark Style)

[Utkarsh Singh]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Hello Po,

> > Hello,
> >
> > I have been using master with `-with-pgtk` option for the past 6
> > months. But recently, I think there is
> > a bug in PGTK build as it Header Bar remains white even when switching
> > to GNOME's Dark Style mode.
> >
> > Thank you,
> > Utkarsh Singh
>
> Emacs isn't a GNOME app, and doesn't use the library they use to
> implement GNOME's global style switch.  If you want to change the style
> used by Emacs's title bars, use GNOME Tweaks to modify the GTK
> stylesheet instead.
>
> Since this not a bug, I'm closing this ticket.  Thanks.

First of all, thank you for your contribution to Emacs in general.

I think there is some confusion. Earlier PGTK build and current GTK+
build changes the title bar color when switching to dark mode in
GNOME. I thought this was an regression and if not can you please tell
more about GTK stylesheets.

Also please find the attached screenshots of PGTK and GTK+ build.

[-- Attachment #2: gtk+.png --]
[-- Type: image/png, Size: 111776 bytes --]

[-- Attachment #3: pgtk.png --]
[-- Type: image/png, Size: 102971 bytes --]

bug#64942: closed (Re: bug#64942: 30.0.50; Header Bar remains white in GNOME's Dark Style)

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Utkarsh Singh <utkarsh190601@gmail.com> writes:

> I think there is some confusion. Earlier PGTK build

Probably dating from before GNOME implemented their global dark style
option, I presume?  In that case, you must've changed the stylesheet
through a preference that applies to all applications in the past.

> and current GTK+ build

Under X, the window manager provides window decorations, whereas they
are provided by GTK under Wayland.  You witness WM decorations adhering
to your desktop preferences since GNOME's own window manager naturally
respects its own style options.

> changes the title bar color when switching to dark mode in GNOME. I
> thought this was an regression and if not can you please tell more
> about GTK stylesheets.

I suggest installing the GNOME Tweak Tool and changing the stylesheet
used for so-called Legacy Applications (a definite misnomer!) to
Adwaita-dark.

bug#64942: closed (Re: bug#64942: 30.0.50; Header Bar remains white in GNOME's Dark Style)

[Utkarsh Singh]

On Mon, Jul 31, 2023 at 7:24 PM Po Lu <luangruo@yahoo.com> wrote:
>
> Utkarsh Singh <utkarsh190601@gmail.com> writes:
>
> > I think there is some confusion. Earlier PGTK build
>
> Probably dating from before GNOME implemented their global dark style
> option, I presume?  In that case, you must've changed the stylesheet
> through a preference that applies to all applications in the past.
>
> > and current GTK+ build
>
> Under X, the window manager provides window decorations, whereas they
> are provided by GTK under Wayland.  You witness WM decorations adhering
> to your desktop preferences since GNOME's own window manager naturally
> respects its own style options.
>
> > changes the title bar color when switching to dark mode in GNOME. I
> > thought this was an regression and if not can you please tell more
> > about GTK stylesheets.
>
> I suggest installing the GNOME Tweak Tool and changing the stylesheet
> used for so-called Legacy Applications (a definite misnomer!) to
> Adwaita-dark.

Thank you! In my case I didn't had 'Adwaita-dark' installed.

For reference, on Arch Linux you need 'gnome-themes-extra' package.