From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Changes to make in elpa-packages file for nongnu elpa Date: Wed, 16 Aug 2023 10:10:46 +0000 Message-ID: <87zg2ri9g9.fsf@posteo.net> References: <87r0oftgye.fsf@posteo.net> <87350vt1wz.fsf@posteo.net> <871qgen1ln.fsf@posteo.net> <87edke4mou.fsf@posteo.net> <87wmy6kuan.fsf@posteo.net> <87wmy6w070.fsf@posteo.net> <87zg2sjleg.fsf@posteo.net> <87pm3nlbm7.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 16 12:11:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWDVI-0004wS-1R for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Aug 2023 12:11:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWDUM-0004Nm-9P; Wed, 16 Aug 2023 06:10:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWDUL-0004Ne-1g for emacs-devel@gnu.org; Wed, 16 Aug 2023 06:10:53 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWDUH-0000ja-V2 for emacs-devel@gnu.org; Wed, 16 Aug 2023 06:10:52 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 45E86240106 for ; Wed, 16 Aug 2023 12:10:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692180647; bh=b8fywRyjqu2fOGvSiZ66IdbDUNDcF+QL73zcJbuwXus=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=oVsDb5n7yC41uV1nWGjWeFwaViwZey18Em/tqqKAZtuhOCYfuARokf0C2pv+alvXc s9II9SrGb3VREwJXDduadKqGMsBOaorPoPSyfEC9Bxj5PSsHE2RhfoJ/Dj2CnIWG5U uUCdiqNrq+fw8yPYqhfbLVZI2URoT91zPcHuZl15u+3Nsb8qzNjOQT2y3tg5mVDauC BNrye3Nt4MdtMEkadcwQWXSW+tfy9OjLGhzZgLh+P/kalO/i6YQlbpuPw1ltUVOb6o EslyjodgJVMIK3AM17iT+2wjsY6GdiS2YyoTHVUDOHNIADiVKafhEH0/FNrvMFlx11 VN6bvTNYmf1Cg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RQkRV60jWz6twR; Wed, 16 Aug 2023 12:10:46 +0200 (CEST) In-Reply-To: <87pm3nlbm7.fsf@posteo.net> (Thierry Volpiatto's message of "Wed, 16 Aug 2023 06:51:29 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308803 Archived-At: --=-=-= Content-Type: text/plain Thierry Volpiatto writes: > Philip Kaludercic writes: > >> Philip Kaludercic writes: >> >>>>>> It is used specially for reproducing bugs in a clean environment, see it >>>>>> as emacs -Q for Emacs when reporting bugs. This script starts Emacs -Q >>>>>> with only Helm loaded, this ensure the bug if one comes from Helm and >>>>>> not another package. This is important especially nowaday people are >>>>>> using "Emacs distribution" with the world list of packages installed. >>>>>> Apart that the script is useful to quickly launch Emacs with helm, one >>>>>> can use it from the Helm directory or symlinked to e.g. ~/bin. >>>>> >>>>> I see. In that case is there any reason you implement this as a shell >>>>> script? >>>> >>>> Well when I wrote the script, packages where not existing and from >>>> outside emacs it is actually the only way to run a package isolated. >>>> >>>>> (It might be interesting to provide something like this for >>>>> package.el, to test packages in a generic way.) >>>> >>>> Yes, this would be interesting, it would be something like this: >>>> >>>> Emacs -Q >>>> M-x >>> packages nuisances> >>> >>> I was actually thinking of a command like >>> >>> M-x package-isolate RET foo,bar,baz RET >>> >>> and a new instance of Emacs using -Q is spun up, with all the packages >>> you have listed loaded, and nothing else... Sounds like a fun little >>> weekend project ;^) >> >> Here is my first attempt at providing this kind of a command. Any >> comments? > > Why not reusing package.el functions? > Why do you want to start in an isolated elpa directory? > Isn't something like this suffice? (just missing to fallback to CRM when > helm is not available) I don't know much about Helm, but does it not support CRM? > (defun package-isolate (packages) > "Start an uncustomised Emacs and only load a set of PACKAGES." > (interactive > (list (let ((helm-comp-read-use-marked t)) > (completing-read "Packages: " (mapcar #'car (package--alist)))))) This doesn't allow selecting specific package versions, in case multiple are installed (which might easily happen if you use package-vc). I stole the code in my patch from package-delete, and I guess it would be possible to generalise it into a utility function. > (let* ((name (concat "package-isolate-" (mapconcat #'identity > packages ","))) This doesn't work, because the above returns a string, not a list of strings. > (deps (cl-loop for p in packages > for sym = (intern p) > append (package--dependencies sym)))) > (apply #'start-process (concat "*" name "*") nil > (list (file-truename (expand-file-name invocation-name invocation-directory)) > "--quick" "--debug-init" > (format "--eval=%S" > `(progn > (require 'warnings) > (add-to-list 'warning-suppress-log-types 'initialization) > (require 'package) > (setq package-load-list > ',(append (mapcar (lambda (p) (list (intern p) t)) packages) > (mapcar (lambda (p) (list p t)) deps))) > (package-initialize))))))) This is actually a good idea, assuming there are no issues with lexical scoping that might arise from --eval. I didn't think of using package-load-list here, but it seems that this only works if we don't add --init-directory, because otherwise the elpa/ directory is not populated. It seems to me, that for a proper isolated environment, we should add a --init-directory option. This is easy to fix though, we just need to specify `package-user-dir' at startup. Here is my updated patch, merging our approaches: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-command-to-start-Emacs-with-specific-packages.patch >From 6ae48d6d28112d487ea09ca905814da47c2a26cf Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 15 Aug 2023 18:39:14 +0200 Subject: [PATCH] Add command to start Emacs with specific packages * lisp/emacs-lisp/package.el (package--dependencies): Extend function to handle and return package descriptors. (package-isolate): Add new command. * etc/NEWS: Announce new command. --- etc/NEWS | 6 ++++ lisp/emacs-lisp/package.el | 57 ++++++++++++++++++++++++++++++++++---- 2 files changed, 57 insertions(+), 6 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 57f04609679..c374695a571 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -505,6 +505,12 @@ project, that you can quickly select using 'project-switch-project' When non-nil, package specifications with side-effects for building software will be used when building a package. +--- +*** New command to start Emacs only with specific packages +The command 'package-isolate' is equivalent to starting Emacs with the +-Q flag and loading specific packages (and their dependencies) +manually. + ** Flymake +++ diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index b3062d2608b..9e969ce1024 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2330,12 +2330,26 @@ package-upgrade-all (mapc #'package-upgrade upgradeable)))) (defun package--dependencies (pkg) - "Return a list of all dependencies PKG has. -This is done recursively." - ;; Can we have circular dependencies? Assume "nope". - (when-let* ((desc (cadr (assq pkg package-archive-contents))) - (deps (mapcar #'car (package-desc-reqs desc)))) - (delete-dups (apply #'nconc deps (mapcar #'package--dependencies deps))))) + "Return a list of all recursive dependencies of PKG. +If PKG is a package descriptor, the return value will consist of +a list of package descriptors. If PKG is a symbol, designating a +package, the return value will be a list of symbols designating +packages." + (when-let* ((desc (if (package-desc-p pkg) pkg + (cadr (assq pkg package-archive-contents))))) + ;; Can we have circular dependencies? Assume "nope". + (let ((all (named-let more ((pkg-desc desc)) + (let (deps) + (dolist (req (package-desc-reqs pkg-desc)) + (setq deps (nconc + (catch 'found + (dolist (p (apply #'append (mapcar #'cdr (package--alist)))) + (when (and (string= (car req) (package-desc-name p)) + (version-list-<= (cadr req) (package-desc-version p))) + (throw 'found (more p))))) + deps))) + (delete-dups (cons pkg-desc deps)))))) + (remq pkg (mapcar (if (package-desc-p pkg) #'identity #'package-desc-name) all))))) (defun package-strip-rcs-id (str) "Strip RCS version ID from the version string STR. @@ -2625,6 +2639,37 @@ package-autoremove removable)) (message "Nothing to autoremove"))))) +(defun package-isolate (packages) + "Start an uncustomised Emacs and only load a set of PACKAGES." + (interactive + (cl-loop for p in (cl-loop for p in (package--alist) append (cdr p)) + unless (package-built-in-p p) + collect (cons (package-desc-full-name p) p) into table + finally return + (list (cl-loop for c in (completing-read-multiple + "Isolate packages: " table + nil t) + collect (alist-get c table nil nil #'string=))))) + (let* ((name (concat "package-isolate-" + (mapconcat #'package-desc-full-name packages ","))) + package-load-list) + (dolist (package (append packages (mapcan #'package--dependencies packages))) + (push (list (package-desc-name package) + (package-version-join (package-desc-version package))) + package-load-list)) + (apply #'start-process (concat "*" name "*") nil + (list (expand-file-name invocation-name invocation-directory) + "--quick" "--debug-init" + "--init-directory" (make-temp-file name t) + (format "--eval=%S" + `(progn + (require 'warnings) + (add-to-list 'warning-suppress-log-types 'initialization) + (require 'package) + (setq package-user-dir ,(expand-file-name package-user-dir) + package-load-list ',package-load-list) + (package-initialize))))))) + ;;;; Package description buffer. -- 2.39.2 --=-=-= Content-Type: text/plain >> [2. text/x-diff; 0002-Add-command-to-start-Emacs-with-specific-packages.patch]... >> >> [3. text/x-diff; 0001-Add-a-function-to-query-the-Emacs-executable.patch]... I have slightly modified your version, fixing issues I had, in case anyone else wants to try it out: (defun package-isolate (packages) "Start an uncustomised Emacs and only load a set of PACKAGES." (interactive (list (mapcar #'intern (completing-read-multiple "Packages: " (mapcar #'car (package--alist)))))) (let* ((name (concat "package-isolate-" (mapconcat #'symbol-name packages ","))) (deps (mapcan #'package--dependencies packages))) (apply #'start-process (concat "*" name "*") nil (list (file-truename (expand-file-name invocation-name invocation-directory)) "--quick" "--debug-init" (format "--eval=%S" `(progn (require 'warnings) (add-to-list 'warning-suppress-log-types 'initialization) (require 'package) (setq package-load-list ',(mapcar (lambda (p) (list p t)) (append packages deps))) (package-initialize))))))) --=-=-=--