From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karthik Chikmagalur Newsgroups: gmane.emacs.devel Subject: Re: Proposal to add Popper to ELPA Date: Tue, 05 Sep 2023 13:12:34 -0700 Message-ID: <87zg20crbh.fsf@gmail.com> References: <874jk8ef0k.fsf@gmail.com> <87y1hkcygb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15425"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 05 22:13:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdcQF-0003qr-Vd for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Sep 2023 22:13:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdcPp-00044o-8x; Tue, 05 Sep 2023 16:12:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdcPn-00044P-Du for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:12:47 -0400 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdcPi-0002tm-6C for emacs-devel@gnu.org; Tue, 05 Sep 2023 16:12:47 -0400 Original-Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bf1935f6c2so1714755ad.1 for ; Tue, 05 Sep 2023 13:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693944761; x=1694549561; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=HWrv9M5awr3YjQQUiD3JXAfg6HBXFP9eNmOnx/fmSqo=; b=aTAJPKAqtHyCjFUakGpPtkWbgUre96ePEsNXHAFr7Ds+xX06NkpwCoZn5PfB/T64ii iSSMtVzndVnpJ771ZZljpqNo8OgXgcoAwcn9jtWhXVbzj36ahtzUs67zCiKD0WaP7ZUG mgXLhHGcsJUID3u1+yLV48+/lhAcpdZkl0SiNz7U0X13ea1rlVsGYslDr666LjHqsX47 mdNBWGU0Q0xlN6wgIQxKKJchLzofMspbcsd/jG25GONqliHRuVWOWPYZjVnSDK3dnfRY HMgsWBf35Yds2f6lLwF0a98DRH4wmZhqwvo4yae7wYrt2A3XwE8+4igiEsL4uahC5J7P IckQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693944761; x=1694549561; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HWrv9M5awr3YjQQUiD3JXAfg6HBXFP9eNmOnx/fmSqo=; b=UjZagEENXCeE7C5reoFOLdYRpA8SCbv8ra5Mvkdvi9HNisH6itIkl8dpQSslnDpHy/ cmcopVhm5KPHr+Hct2wtehc3VihyqDy9/qjcB1XpDPt5tLB5UZh2AwEL9PyWVV8mximi mq5k57VZ0m+IUzDEabm54ddIvegCW11zD/7b6RRk+OXbNX0UAnXkaHBG/8UwAG3jhHCw bPVqQSJ5bPIureCETRPpMGyHuGz9uZ4lz00O/2D03Vek0kR5iIcbSTeeUsMin01nAq4S xoDZmn5NSOVAg7pKXjrI812CRlI1IGrO5ROqyncQ0LxR6JM7llfFF1jZzVrlkPApAkzK ws1A== X-Gm-Message-State: AOJu0YyjnMxZk3IA0JUArHs6YO5bJOsyTu5XoTgranrNHJbQ3zxTBukn HjSgPWgqDZoQnN/K3F5TV9Bm4u/F400= X-Google-Smtp-Source: AGHT+IHfyWKNK9vb70yhdp3pxI2kdYVxjHcfwnYU+A/h+VD1Wz8qPPnnm/St0wpCj7pfLF/q3ScLrw== X-Received: by 2002:a17:902:ce84:b0:1bf:8132:d19f with SMTP id f4-20020a170902ce8400b001bf8132d19fmr19411913plg.27.1693944760700; Tue, 05 Sep 2023 13:12:40 -0700 (PDT) Original-Received: from localhost (ip184-189-240-75.sb.sd.cox.net. [184.189.240.75]) by smtp.gmail.com with ESMTPSA id m2-20020a170902db0200b001b9e86e05b7sm9693633plx.0.2023.09.05.13.12.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 13:12:40 -0700 (PDT) In-Reply-To: <87y1hkcygb.fsf@posteo.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=karthikchikmagalur@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310149 Archived-At: Thank you for the review, especially for the changes to the defcustoms. I'm not very familiar with the many options the customization interface provides. I have applied all changes except the one in the defcustom for `popper-reference-buffers' (which see below). In case you missed it during the review, the package has two files: `popper.el' and `popper-echo.el'. (The latter provides `popper-echo-mode', which adds echo-area display of available popups and allows for quick selection using a transient keymap.) > +;; If you are interested in depending on Compat, you could use > +;; `buffer-match-p' here. > (defcustom popper-reference-buffers '("\\*Messages\\*$") > "List of buffers to treat as popups. I would like to avoid depending on Compat for one utility function. > - :type '(restricted-sexp :match-alternatives (stringp symbolp functionp consp)) > - :group 'popper) > + :type '(repeat (string :tag "Regular Expression") > + (symbol :tag "Major Mode") > + (function :tag "Predicate Function") > + ;; What is the consp in (restricted-sexp :match-alternatives (stringp symbolp functionp consp))? > + )) The `consp' here is for specifying additional behavior per popup. Presently this is limited to requesting that (initial) display of the popup be suppressed, but support for other special behavior could be provided in the future. Examples of this are in the README in the section "Suppressing popups". An example: `("\\*Compilation\\*" . hide)' How do you suggest incorporating this into the defcustom? > Also, it seems adding a .elpaignore file would be nice to remove > unnecessary files from the tarball: For now a file just containing > "images" should suffice. Done, thank you. > Also also, by default the README file will be used to generate a package > description (as seen in C-h P). I feel that the current file is just a > tad too long for this indent, and the description in the commentary > section might be preferable. Would you be fine with using that instead? Yes, that should be fine. The commentary section explains the purpose of the package and the main functions. >> What is Popper? >> >> Short for "Popup Buffer", > > FWIW I don't think I would have understood this. Perhaps it is just me, > but despite fearing a general discussion about package names, do you > think renaming the package to something like "popup-buffers" would be > imaginable. If not, it is fine, just wanted to bring it up /briefly/. I took my cue for the name `popper' from Emacs' built-in `winner-mode'. At 16K+ downloads, Popper is a reasonably well known package and I think renaming it now will create more confusion than clarity. The byline for the package is "Summon and dismiss buffers as popups", which shows up in package listings and should help discoverability. >> There are other features, and a few video demos at the link. > > Is the video mirrored on some other platform as well? It's not. Do you have a suggestion for where you'd like the videos to be available? I can make that happen. Karthik