From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ert-font-lock Date: Mon, 20 Nov 2023 22:45:19 -0600 Message-ID: <87zfz7k8ya.fsf@thelio.lan> References: <87v89zz4v4.fsf@posteo.net> <87v89zjmcx.fsf@yahoo.com> <83fs13mduq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27347"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Po Lu , philipk@posteo.net, emacs-devel@gnu.org To: Vladimir Kazanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 21 12:21:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5Op8-0006sL-SJ for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Nov 2023 12:21:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5OoB-0000Tc-DG; Tue, 21 Nov 2023 06:20:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5Igx-00082J-Tp for emacs-devel@gnu.org; Mon, 20 Nov 2023 23:48:55 -0500 Original-Received: from out-176.mta1.migadu.com ([2001:41d0:203:375::b0]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5Igv-0007yk-RV for emacs-devel@gnu.org; Mon, 20 Nov 2023 23:48:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1700542129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nB6QhgplELKA/c56XGlGj+vbh+Ojpub439kaxKZ+9Sc=; b=epJGV+tIsD+TsTh6n2z5Uy/YKLtD5v//W7jKqroPzvLl5OfDiz/dkCzqeSDLDgCxX3URKd +RJwwW3iAfYgcVcol2/ch2DASmSh6AcaP7cUaJEEvbuJniaVv9A2SWJFX0NiVjMvlplyko 7yq0VLa3CEYpAHt5zB7ckKGh5mLvdxk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b0; envelope-from=jm@pub.pink; helo=out-176.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 21 Nov 2023 06:20:45 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313104 Archived-At: Vladimir Kazanov writes: > Hi everyone, > > Just bumping this thread for visibility. > > I've made most of the changes that were suggested earlier and > clarified how my package differs from faceup.el. I'm also considering > if it's feasible to lower the Emacs version requirement to 27.1 and > planning to run some more tests for edge cases. Other than that, the > tool is pretty much set and shouldn't see major changes. > > Could you let me know what I should do next to move forward with > adding the package to ELPA (or Emacs itself if Eli doesn't mind)? > > Thanks a lot for your help! FWIW I used it to add tests for lua-ts-mode=E2=80=99s font-lock rules. It works well and feels to me like it would be a nice addition to Emacs. Thanks for working on it. > On Sun, 19 Nov 2023 at 10:08, Vladimir Kazanov wrot= e: >> >> > I won't object to including this, FWIW. >> >> Would this require any additional changes to the way the code is structu= red? >> >> There were also some questions around ert-font-lock.el being similar >> to faceup.el. I covered these elsewhere. >> >> On Sat, 18 Nov 2023 at 12:43, Eli Zaretskii wrote: >> > >> > > From: Po Lu >> > > Cc: Vladimir Kazanov , emacs-devel@gnu.org >> > > Date: Sat, 18 Nov 2023 20:07:42 +0800 >> > > >> > > Philip Kaludercic writes: >> > > >> > > > ELPA shouls be fine. >> > > >> > > Since this is an adjunct to ERT, which is plausibly useful for the u= nit >> > > testing of Emacs fontification code itself, I think such code should= be >> > > part of Emacs proper. >> > >> > I won't object to including this, FWIW. >> > >> > > BTW, this code requires cl-lib for a meager one macro. Please repla= ce >> > > >> > > (cl-incf curline) >> > > >> > > with >> > > >> > > (setq curline (1+ curline)) >> > > >> > > that cl-lib might not be loaded either at compile-time or runtime. >> > > There is no rationale for requiring cl-lib so as to employ a single >> > > macro once. >> > >> > Doesn't this library require ert? if it does, cl-lib is already >> > loaded by ert. >> > >> > But if people like cl-incf so much, we could just add incf to subr.el >> > or something. >> >> >> >> -- >> Regards, >> >> Vladimir Kazanov