From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sat, 02 Dec 2023 09:52:41 +0000 Message-ID: <87zfytdj86.fsf@posteo.net> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87v89hufbw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11928"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , 66394@debbugs.gnu.org, stefankangas@gmail.com, monnier@iro.umontreal.ca To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 02 10:54:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9MhN-0002td-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Dec 2023 10:54:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9Mh8-0006Hj-RM; Sat, 02 Dec 2023 04:53:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9Mh7-0006Gj-1Z for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 04:53:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9Mh6-0007b8-Pq for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 04:53:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9MhG-00057j-0Y for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 04:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2023 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170151078919626 (code B ref 66394); Sat, 02 Dec 2023 09:54:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 2 Dec 2023 09:53:09 +0000 Original-Received: from localhost ([127.0.0.1]:56653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9MgP-00056U-5x for submit@debbugs.gnu.org; Sat, 02 Dec 2023 04:53:09 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:41047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9MgK-00055y-CV for 66394@debbugs.gnu.org; Sat, 02 Dec 2023 04:53:08 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B3C6F240104 for <66394@debbugs.gnu.org>; Sat, 2 Dec 2023 10:52:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1701510768; bh=aEqEJkzyVstcGkGJ8JF7ZiNSqNsZIArBMA6YMTfacg0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=nBAoo4rZ6/jmuRXHMr69dNSBbqTzLeZyMz3alU7JHggYoXgt9ObbyezLnJ4mAfhk7 zsqSLBa7U6XlrWk4xoLyA1DmT/6Kkyvo5bAXThRVHKOxuRgSDpIVtRg/CgIz0Ir4G7 jk2kkFNs2yweljru66BxplgDWqK779sQEKbfMxmCNh7EdeRbTgmic/J+iAhDpf5XsU CSqAWGC6DiuoyXQKeMnXrGNvrxAPtWvkmDYjUjrGDvUKqjDoH704OKpswmkqUfe95D lvYDVfmJsqG4iYKOzAFh8ogd6gDgxYmOCtdhP2eHYB2/0dBPoJ8PFlCiAmi9Hc6uEa yQ6he+vomc9WQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Sj4ws3Hl2z6ty6; Sat, 2 Dec 2023 10:52:44 +0100 (CET) In-Reply-To: <87v89hufbw.fsf@gnu.org> (Bastien's message of "Sat, 02 Dec 2023 10:24:51 +0100 (15 minutes, 42 seconds ago)") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275365 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Bastien writes: > I use registers ~100 times a day, so enhancements here are very > welcome, thanks! > > Thierry Volpiatto writes: > >> A minibuffer is used now instead of read-key. > > I wonder about this, though. It badly hinders my usual flow, where I > do remember what registers I use and like to store new ones quickly. > > When a register is empty, I believe it's more efficient to just read > the key and store the content in the register directly. > > E.g. if the "a" contains "A string" and "b" is an empty register: > > - C-x r s would display the preview and copy the region to the "b" > register as soon as the "b" key is hit (using read-key). I suggest you use M-n RET instead if you want to be sure you don't overwrite a register. Also don't forget you can now use C-n/p or / to navigate in previ= ew. > - C-x r s would display the preview and if the user hits "a", it will > warn about overwriting the existing register and RET can confirm. It is what it is doing actually with minibuffer. Hitting "a" highlight register "a" and send a message "overwriting register", then you can hit RET if you want to overwrite. > This supposes using read-key by default and switch to using a > minibuffer when the user hits keys for existing registers. > > What do you think? I think using read-key+minibuffer would be very complicated and would need much more code, this for a small benefit: Saving one key (RET). Also I think hitting RET in any case is better as it does a kind of "confirm I want to do this". Also using read-key leads to bug like we had previously as we must mimic a keymap which is often wrong. Thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmVq/mkTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkww1C/4/OV42MVSNxUOABRKViWUOXWu3rmcE OZ4Jy9RmzR5LjOmCuam5ANMO9GAuBb0gzkZTBKbLQ+Ckm8gG3fdIf8E5W4xVFwK4 /difhvIsq1iQb3ZUikxypZw57iKTFAPAVRMQkmwE7sgM+1Ja5bnKaoX4b/1wcpMD c4H7aHFx6R6ri8gpR6tLmuhSMBVGT2lb3VYyR1umiXCINTsDy7gvdr1Byje7zWxA iVYc69MdUjwp04E2lKhVjOKol/7Pc9l8bTUmklDpA8YqGxQh9mXL8H3zFbMTcFt5 qHsyoZ5oPFfHaMzyE50zum/lNL5dlUk6XuQWNTcIvwMyFOoGvhJeRTcbjkOhFW23 eWHgznwyA6xtq9DCewFk6A3pwL3AhfewAuFrWih+HN0GCHRx6D4YtMQbrHn+BaAE Br7YnkggWf8lGY/xsIvFDx2FOJUdpI8divkxSOxRantDPaYYI/16mm2b04Vb0DJl YEYdM6yKk+w2TPduKIgRcooZJhIbua5h5S4= =wchH -----END PGP SIGNATURE----- --=-=-=--